From: "Alastair D'Silva" <alastair@d-silva.org>
To: "'Christoph Hellwig'" <hch@infradead.org>
Cc: "'Peter Zijlstra'" <peterz@infradead.org>,
"'Andrew Morton'" <akpm@linux-foundation.org>,
"'David Hildenbrand'" <david@redhat.com>,
"'Oscar Salvador'" <osalvador@suse.com>,
"'Michal Hocko'" <mhocko@suse.com>,
"'Pavel Tatashin'" <pasha.tatashin@soleen.com>,
"'Wei Yang'" <richard.weiyang@gmail.com>,
"'Arun KS'" <arunks@codeaurora.org>, "'Qian Cai'" <cai@lca.pw>,
"'Thomas Gleixner'" <tglx@linutronix.de>,
"'Ingo Molnar'" <mingo@kernel.org>,
"'Josh Poimboeuf'" <jpoimboe@redhat.com>,
"'Jiri Kosina'" <jkosina@suse.cz>,
"'Mukesh Ojha'" <mojha@codeaurora.org>,
"'Mike Rapoport'" <rppt@linux.vnet.ibm.com>,
"'Baoquan He'" <bhe@redhat.com>,
"'Logan Gunthorpe'" <logang@deltatee.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <linux-nvdimm@lists.01.org>
Subject: RE: [PATCH 5/5] mm/hotplug: export try_online_node
Date: Mon, 17 Jun 2019 18:00:00 +1000 [thread overview]
Message-ID: <068d01d524e2$aa6f3000$ff4d9000$@d-silva.org> (raw)
In-Reply-To: <20190617071527.GA14003@infradead.org>
> -----Original Message-----
> From: Christoph Hellwig <hch@infradead.org>
> Sent: Monday, 17 June 2019 5:15 PM
> To: Alastair D'Silva <alastair@d-silva.org>
> Cc: Peter Zijlstra <peterz@infradead.org>; Andrew Morton <akpm@linux-
> foundation.org>; David Hildenbrand <david@redhat.com>; Oscar Salvador
> <osalvador@suse.com>; Michal Hocko <mhocko@suse.com>; Pavel Tatashin
> <pasha.tatashin@soleen.com>; Wei Yang <richard.weiyang@gmail.com>;
> Arun KS <arunks@codeaurora.org>; Qian Cai <cai@lca.pw>; Thomas Gleixner
> <tglx@linutronix.de>; Ingo Molnar <mingo@kernel.org>; Josh Poimboeuf
> <jpoimboe@redhat.com>; Jiri Kosina <jkosina@suse.cz>; Mukesh Ojha
> <mojha@codeaurora.org>; Mike Rapoport <rppt@linux.vnet.ibm.com>;
> Baoquan He <bhe@redhat.com>; Logan Gunthorpe
> <logang@deltatee.com>; linux-mm@kvack.org; linux-
> kernel@vger.kernel.org; linux-nvdimm@lists.01.org
> Subject: Re: [PATCH 5/5] mm/hotplug: export try_online_node
>
> On Mon, Jun 17, 2019 at 05:05:30PM +1000, Alastair D'Silva wrote:
> > On Mon, 2019-06-17 at 08:59 +0200, Peter Zijlstra wrote:
> > > On Mon, Jun 17, 2019 at 02:36:31PM +1000, Alastair D'Silva wrote:
> > > > From: Alastair D'Silva <alastair@d-silva.org>
> > > >
> > > > If an external driver module supplies physical memory and needs to
> > > > expose
> > >
> > > Why would you ever want to allow a module to do such a thing?
> > >
> >
> > I'm working on a driver for Storage Class Memory, connected via an
> > OpenCAPI link.
> >
> > The memory is only usable once the card says it's OK to access it.
>
> And all that should go through our pmem APIs, not not directly poke into
mm
> internals. And if you still need core patches send them along with the
actual
> driver.
I tried that, but I was getting crashes as the NUMA data structures for that
node were not initialised.
Calling this was required to prevent uninitialized accesses in the pmem
library.
--
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva msn: alastair@d-silva.org
blog: http://alastair.d-silva.org Twitter: @EvilDeece
next prev parent reply other threads:[~2019-06-17 8:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 4:36 [PATCH 0/5] mm: Cleanup & allow modules to hotplug memory Alastair D'Silva
2019-06-17 4:36 ` [PATCH 1/5] mm: Trigger bug on if a section is not found in __section_nr Alastair D'Silva
2019-06-17 6:46 ` Mike Rapoport
2019-06-17 4:36 ` [PATCH 2/5] mm: don't hide potentially null memmap pointer in sparse_remove_one_section Alastair D'Silva
2019-06-17 6:49 ` Mike Rapoport
2019-06-17 7:26 ` David Hildenbrand
2019-06-17 4:36 ` [PATCH 3/5] mm: Don't manually decrement num_poisoned_pages Alastair D'Silva
2019-06-17 6:52 ` Mike Rapoport
2019-06-17 7:17 ` David Hildenbrand
2019-06-17 4:36 ` [PATCH 4/5] mm/hotplug: Avoid RCU stalls when removing large amounts of memory Alastair D'Silva
2019-06-17 6:53 ` Mike Rapoport
2019-06-17 6:58 ` Alastair D'Silva
2019-06-17 7:47 ` Michal Hocko
2019-06-17 7:57 ` Alastair D'Silva
2019-06-17 8:21 ` Michal Hocko
2019-06-17 15:49 ` Oscar Salvador
2019-06-17 4:36 ` [PATCH 5/5] mm/hotplug: export try_online_node Alastair D'Silva
2019-06-17 6:59 ` Peter Zijlstra
2019-06-17 7:05 ` Alastair D'Silva
2019-06-17 7:15 ` Christoph Hellwig
2019-06-17 8:00 ` Alastair D'Silva [this message]
2019-06-17 13:14 ` 'Christoph Hellwig'
2019-06-17 7:16 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='068d01d524e2$aa6f3000$ff4d9000$@d-silva.org' \
--to=alastair@d-silva.org \
--cc=akpm@linux-foundation.org \
--cc=arunks@codeaurora.org \
--cc=bhe@redhat.com \
--cc=cai@lca.pw \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=mojha@codeaurora.org \
--cc=osalvador@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=peterz@infradead.org \
--cc=richard.weiyang@gmail.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox