From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B024C76195 for ; Mon, 27 Mar 2023 10:27:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 332266B0071; Mon, 27 Mar 2023 06:27:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E353900003; Mon, 27 Mar 2023 06:27:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18344900002; Mon, 27 Mar 2023 06:27:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 056F46B0071 for ; Mon, 27 Mar 2023 06:27:23 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C259940637 for ; Mon, 27 Mar 2023 10:27:22 +0000 (UTC) X-FDA: 80614301124.16.CCA543E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf14.hostedemail.com (Postfix) with ESMTP id A5B5D10000C for ; Mon, 27 Mar 2023 10:27:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZZLqyqej; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Ogoao4Yp; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679912841; a=rsa-sha256; cv=none; b=abwekzV8thXYVV7HsBw6yz/NAxDhBYDkK6RUxTte3u/Db4hEhIBgbQPbNUzh+V1ZyzfbFk tNLXXXW6XULTj4kSNdW95W0UTKjxBSMN/76drXyq/QCu7VCICuvWWOJNY48kLxkfgnY1Id WEf6+5zzVZI2gcG7QyB/rQkq63/j7/Y= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZZLqyqej; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Ogoao4Yp; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679912841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6zeAapTweggWvHmqJXKCAVkq4U6iU7yqVvakxDRPJlY=; b=O4/4XFO0Ra4IfCQcwjLUILHjIVQ3ObLhxZ+eA6qOsBDlxOXKRGsVLmzSF4qHDS6Etojmko YOhJdu/rhtZ3kZ+G05ZCo792nvoZWls6WfP484LPLhm+WUmVtbQeZIyqSRyQW1XnteW6uN 7XHl80VL9UhWSlFT6ckCjsc0JLXtPuo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1E78121C2D; Mon, 27 Mar 2023 10:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679912839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6zeAapTweggWvHmqJXKCAVkq4U6iU7yqVvakxDRPJlY=; b=ZZLqyqejDT1+lC/IQ0gMRG3AlrSFychR3wkDlFd5FSCq4EHG5rTAB/qYAVNJQbOIZaa/tE 9cEv58WBEa0T1IlSWuMEanv6r13TJnifohbH+RP8aLpowMFBupa8uoRGKOlpODLKZ3rmVy pQUpQMYyyQA6DFVHIlMKLaykAM7kom4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679912839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6zeAapTweggWvHmqJXKCAVkq4U6iU7yqVvakxDRPJlY=; b=Ogoao4Ypl7iEHpBZ/JQCvSxu+zhkwLijk7xqr9zPLv5AZW9ZPSzECLFMgU2/19hvPq5spU YIMBoNA3iXeoSNBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D3BF313329; Mon, 27 Mar 2023 10:27:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NGBvMoZvIWTTBgAAMHmgww (envelope-from ); Mon, 27 Mar 2023 10:27:18 +0000 Message-ID: <067f7347-ba10-5405-920c-0f5f985c84f4@suse.cz> Date: Mon, 27 Mar 2023 12:27:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file Content-Language: en-US To: ye xingchen , mcgrof@kernel.org Cc: akpm@linux-foundation.org, chi.minghao@zte.com.cn, hch@infradead.org, keescook@chromium.org, linmiaohe@huawei.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, ye.xingchen@zte.com.cn, yzaikin@google.com References: <20230327024939.75976-1-ye.xingchen@zte.com.cn> From: Vlastimil Babka In-Reply-To: <20230327024939.75976-1-ye.xingchen@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: A5B5D10000C X-Rspamd-Server: rspam01 X-Stat-Signature: 9njqu3dhfxhxse1887tpy5gngtdt9kj3 X-HE-Tag: 1679912840-321058 X-HE-Meta: U2FsdGVkX1/eqrltoGw1p2DcGMRUUPp2GdUASP2/HPLYumOAZt55+fntYXPmSONeOXRhkQU6OEOu3DHoxUhjdYe3kwFvRNx6ND34wY0U+Tts81bGAw2ndTHe8pgEWpzx+nEVU0q5zpLw7yPtDyZp0N6JrTVtsju7OvCl6EZFOpVqhwGJcHQw8dQEkfZIJgHml3w1dtRk0NEzqcL3JFYaCBlRR/P64/KlObaUXK9dtUyPpcY6DcoUrSAbTFcHsbEBngRRYIMqe3xupgRFCue5bTC3sXlVx3EEEoj15Eivf7o3z3G1jeuIM6/GRxt8uGZHSnFh5vJ52QA0fAylOaf55/i0WYQ5vpGoAe2ohvpAbEYTAM32goLWDMS84jERKxDekprDC28tmk8qLss+fkLIIxRgr4+opzzx/I9vAzj0nyY4ozpVrdpgZvxnGia+oreRsddvkwFEqXos7bhXdRc5CpY7beRQjb7NDPhL2k1uaQ5oDB1e1lkDV9GseuKt7fKs0+Rp3uj9kIuzATjIgcyct6LAZ+rN38Ozet4lA/x9V4qbtVS3lXfFeD5iVClvC2cQtVk0aQtOJO6TID3V7tGaNzJEeXBxCnsAL6Yove6iWRif+aB6FdsOi+SqAAgY4lpiiyxVLqC+OS4Tpe5VnDIOOO+/eg5I8pNMuSZsPveoOn1LlpT6AzOi1S0fSEYN8dofJyB4nb6kfID9k3bJp0krC+gSDrjJTt26T9w1EvrXKVtGI14DiXhrV9HnXr34yXx4vSSMUt6S8jYOn9BjZ2lUZDnFTJT9WxHyYoRgTmU9U1/7yaxrSVVnu4QngISf43UdYT0bLglolB+A8R3Q985qKgeEYHFp+w+iVG+XSXRs5tpUR0o6hEaZkQaF3GOwu84sLJ9p+aNZZFtf2uoEy+412fzcHC4wh2/c9MhsBmL1fHes2H+cMWCS4pX5waCp9hSioGZ3JImKlhZ3mMBaa0L Zo5wTYiB Hjwb6UHVl9VqbB3SPYXFyGaozhhoxNY+xaNorp946H+Fc/oKBnUrhkVbH3SLcvhODijkS1uxSReGJyYOUna/mZOYnkGbz0wgo6k+CN+KbQxVueojAz+7vnrNwloffViL+VPVC7F/Tf+bnApx9WMQdKToLiaseJi7jd9/cZmIca2LYuHSIv5K6LvHWYx56HFmwaBXlrW9XbcetdXRD3wym2fNLtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/27/23 04:49, ye xingchen wrote: >>> >$ ./scripts/bloat-o-meter vmlinux.old vmlinux >>> >add/remove: 1/0 grow/shrink: 1/2 up/down: 346/-350 (-4) >>> >Function old new delta >>> >vm_compaction - 320 +320 >>> >kcompactd_init 167 193 +26 >>> >proc_dointvec_minmax_warn_RT_change 104 10 -94 >>> >vm_table 2112 1856 -256 >>> >Total: Before=19287558, After=19287554, chg -0.00% >>> > >>> >So I don't think we need to pause this move or others where are have savings. >>> > >>> >Minghao, can you fix the commit log, and explain how you are also saving >>> >4 bytes as per the above bloat-o-meter results? >>> >>> $ ./scripts/bloat-o-meter vmlinux vmlinux.new >>> add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94) >>> Function old new delta >>> vm_compaction - 320 +320 >>> kcompactd_init 180 210 +30 >>> vm_table 2112 1856 -256 >>> Total: Before=21104198, After=21104292, chg +0.00% >>> >>> In my environment, kcompactd_init increases by 30 instead of 26. >>> And proc_dointvec_minmax_warn_RT_change No expansion. >> >>How about a defconfig + compaction enabled? Provide that information >>and let Vlastimal ACK/NACK the patch. > I use x86_defconfig and linux-next-20230327 branch > $ make defconfig;make all -j120 > CONFIG_COMPACTION=y > > add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94) > Function old new delta > vm_compaction - 320 +320 > kcompactd_init 180 210 +30 > vm_table 2112 1856 -256 > Total: Before=21119987, After=21120081, chg +0.00% No savings then, but to me the patch still seems a worthwile cleanup. But if others think the 94 bytes are an issue, it can wait for the new APIs.