From: Vlastimil Babka <vbabka@suse.cz>
To: ye xingchen <yexingchen116@gmail.com>, mcgrof@kernel.org
Cc: akpm@linux-foundation.org, chi.minghao@zte.com.cn,
hch@infradead.org, keescook@chromium.org, linmiaohe@huawei.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, willy@infradead.org, ye.xingchen@zte.com.cn,
yzaikin@google.com
Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file
Date: Mon, 27 Mar 2023 12:27:18 +0200 [thread overview]
Message-ID: <067f7347-ba10-5405-920c-0f5f985c84f4@suse.cz> (raw)
In-Reply-To: <20230327024939.75976-1-ye.xingchen@zte.com.cn>
On 3/27/23 04:49, ye xingchen wrote:
>>> >$ ./scripts/bloat-o-meter vmlinux.old vmlinux
>>> >add/remove: 1/0 grow/shrink: 1/2 up/down: 346/-350 (-4)
>>> >Function old new delta
>>> >vm_compaction - 320 +320
>>> >kcompactd_init 167 193 +26
>>> >proc_dointvec_minmax_warn_RT_change 104 10 -94
>>> >vm_table 2112 1856 -256
>>> >Total: Before=19287558, After=19287554, chg -0.00%
>>> >
>>> >So I don't think we need to pause this move or others where are have savings.
>>> >
>>> >Minghao, can you fix the commit log, and explain how you are also saving
>>> >4 bytes as per the above bloat-o-meter results?
>>>
>>> $ ./scripts/bloat-o-meter vmlinux vmlinux.new
>>> add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94)
>>> Function old new delta
>>> vm_compaction - 320 +320
>>> kcompactd_init 180 210 +30
>>> vm_table 2112 1856 -256
>>> Total: Before=21104198, After=21104292, chg +0.00%
>>>
>>> In my environment, kcompactd_init increases by 30 instead of 26.
>>> And proc_dointvec_minmax_warn_RT_change No expansion.
>>
>>How about a defconfig + compaction enabled? Provide that information
>>and let Vlastimal ACK/NACK the patch.
> I use x86_defconfig and linux-next-20230327 branch
> $ make defconfig;make all -j120
> CONFIG_COMPACTION=y
>
> add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94)
> Function old new delta
> vm_compaction - 320 +320
> kcompactd_init 180 210 +30
> vm_table 2112 1856 -256
> Total: Before=21119987, After=21120081, chg +0.00%
No savings then, but to me the patch still seems a worthwile cleanup. But if
others think the 94 bytes are an issue, it can wait for the new APIs.
next prev parent reply other threads:[~2023-03-27 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 2:46 ye.xingchen
2023-03-22 8:35 ` Christoph Hellwig
2023-03-23 16:19 ` Vlastimil Babka
2023-03-23 19:39 ` Luis Chamberlain
2023-03-24 6:24 ` ye xingchen
2023-03-24 18:11 ` Luis Chamberlain
2023-03-27 2:49 ` ye xingchen
2023-03-27 10:27 ` Vlastimil Babka [this message]
2023-03-27 3:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=067f7347-ba10-5405-920c-0f5f985c84f4@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=chi.minghao@zte.com.cn \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=willy@infradead.org \
--cc=ye.xingchen@zte.com.cn \
--cc=yexingchen116@gmail.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox