From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2EFC3DA6E for ; Thu, 21 Dec 2023 02:55:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43EA96B0075; Wed, 20 Dec 2023 21:55:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EF016B007B; Wed, 20 Dec 2023 21:55:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B6CA6B007D; Wed, 20 Dec 2023 21:55:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1B2A46B0075 for ; Wed, 20 Dec 2023 21:55:43 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DC576120581 for ; Thu, 21 Dec 2023 02:55:42 +0000 (UTC) X-FDA: 81589310124.07.8CCDF48 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf01.hostedemail.com (Postfix) with ESMTP id F24C04000E for ; Thu, 21 Dec 2023 02:55:40 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Q3s704m2; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703127341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h690bWax6yOVJQKGadfFFXWsV5kXgvfQum64XdRnI8k=; b=ePTwZUf7pSiUXGll740phVyQj2isYKhm6fh+okIOdxLCqXIx+w/Pac9sETcP0SucX8075k 4UvY+KiI/eBa9Dut5v9HcKG+BtSKRQQWrGzMaBvJxKJ9ztm/LyVJ6T3U3eVsJCc2z9BI6A +UTwuXdQTj06AiJ8wGlHw01G/oQufkU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Q3s704m2; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703127341; a=rsa-sha256; cv=none; b=aOV9PiiIAV11lhMI4pSaRWHjKh0GLcucdpQGzU8axQJAn54yl/oj4iCbeaSf1yq6bx3wfD 1s3na+cNESoydKqphSxao6J2J5rn20PpsQu2A6iVdF56gU9idFl2eQyOmfJltIbzkKloIg M3JUEhRrG8Xe5fqAwsD9NPhblKf4yZU= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1703127339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h690bWax6yOVJQKGadfFFXWsV5kXgvfQum64XdRnI8k=; b=Q3s704m2bPeTWEOwmanmPMW48lD2m7QW6OaviD1J+XcWfNk9RPgtfELZLEZ95BwamrPb4b uE1y8jI+fa30kE9frMnMQDL9A0htEhvjTKuxaI/31vuNzqz3IfkwiYXjpVhUMCQN8uSWFu a/VLEuZF60ZYvmRXnn359JR6u/3i1wE= Mime-Version: 1.0 Subject: Re: [PATCH v2 02/40] mm/rmap: introduce and use hugetlb_remove_rmap() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20231220224504.646757-3-david@redhat.com> Date: Thu, 21 Dec 2023 10:54:30 +0800 Cc: LKML , Linux-MM , Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Yin Fengwei , Mike Kravetz , Peter Xu Content-Transfer-Encoding: 7bit Message-Id: <06731287-9E14-4623-9280-B9C43E12E021@linux.dev> References: <20231220224504.646757-1-david@redhat.com> <20231220224504.646757-3-david@redhat.com> To: David Hildenbrand X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: n1hskhoxpf4bw4waiip8rbq9tjtn7p7k X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F24C04000E X-HE-Tag: 1703127340-89004 X-HE-Meta: U2FsdGVkX1/vqUxqYyW9xfyUDocTu3a6rh6q65sZ/Yp+afBwajxlQ5YuCKN7M8gifgDyCUZvKlXTp/f/hiP7uIERsn0mr91ey1RdvRgrtBnA9PoP/BCFoNKuJ6hmS+p6argJwyd36WrHqYjnQ32zKQXw8Xc2K6xIn1fDedvEQUA7A6WbC1ckHPG+WnnpT/pc9hB0SPV2cS+pmq9EOeJCgzVOgKheMIOEzxCv/blIC7+mLGlwL7BF60CxpFH+MtZSdD8uafrJ9CrJuPG1UU8cs+AQgnNZ+B0CU0nYsz3trBIx6k31lFt/jdHYSgQCczIax3I2lF7QrTCkjo0myRQQVs853s7BedHAtuC565TilSjg0qXzWxYQQJMFPl3wBvpvpyMjAkAZLPRLO/NCuqhGdszc8ELojboMZs630BE/jWN3Buo8vGOd8zTWtKisGe4Z9GyXRyGjVXvZmLFR6X8O+qr/ND8gj9ib4RS2QwQN5qW//fYn7nvD6NU62UNaUStq1rVCpSnLuhza72oGzXK1KcrloF8GpX9cMQPdq8wvo7mU9n/ojed8Oy9Q+Rlsgfr1lgMKr1t3QP7ED8jbpwlN+hBlnNyklzokw7wPMiVu/QoHeNfLngVWcQFMrNw8YJFOnVnmK6DjRChZPviHKIeD7c0DIJ9SjS49SkEv2YZunA+E4/f+LeVSc9XQjEZ0VGZ+zZ9DuDybOP4WNv8/fkxR9BEPpql7Bo1ZHWNUT2S3G0UU7qajE0xg3IVJwRspM69L0GzYpbD30zhOFcVHHzJQ8CmKC/BE4Jmj2bTr409rzLkOraJEQHVMysSOuah9vpxXrv1ZEOp5OSnarCIsSZv6jqFxofnliJlC3p+NXSQ2F90cpPqvGWwyu2dwbNkNbwYzeKXkugtG0i5K9g5Ue3QWoF1odCj0z8Tpv6ja0xJ7t561HmuIxOl0Fs7h3rEtIUAS+X5PKe2mH0cVXY/8Trm r9FgaY52 nwgZQASMhD3KGl9xzdggNl63f79WGQDaDv0eNDl1OD259hphCDjrL+04ybHtX2c4X6M8NWwGKutf2OvudgQsIuwz3yayq3c6soMGzVqpiuwMWdzI+Fs5a7+3Lnqf8S/1ixKjtwO0Nry/X5n/sEb3DngrGkICogAWLHJMRSwmo7jyI0/rw3p2SjHEWlf04tPdDLK191E27nCNot5g1NxzMBfVlPkIkDYaIrOf4kxbGVur9ei9f1XTyf4dF/N50TG5UJC62UbMX1D/WL0jtKeMKbgbLsYbzmLu0W+JZgZxBj1UgoIzt6GXb75wNdz/hdccnNN/az6JLuOOduLmKOnY9mcoKMgJxpoZYj6LLg8nJBSG3LcJUzj+H/2qMoGKDCaoFdQfp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Dec 21, 2023, at 06:44, David Hildenbrand wrote: > > hugetlb rmap handling differs quite a lot from "ordinary" rmap code. > For example, hugetlb currently only supports entire mappings, and treats > any mapping as mapped using a single "logical PTE". Let's move it out > of the way so we can overhaul our "ordinary" rmap. > implementation/interface. > > Let's introduce and use hugetlb_remove_rmap() and remove the hugetlb > code from page_remove_rmap(). This effectively removes one check on the > small-folio path as well. > > Add sanity checks that we end up with the right folios in the right > functions. > > Note: all possible candidates that need care are page_remove_rmap() that > pass compound=true. > > Reviewed-by: Yin Fengwei > Reviewed-by: Ryan Roberts > Reviewed-by: Matthew Wilcox (Oracle) > Signed-off-by: David Hildenbrand Reviewed-by: Muchun Song Thanks.