From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by kanga.kvack.org (Postfix) with ESMTP id 21C5C8E0001 for ; Thu, 27 Dec 2018 06:31:24 -0500 (EST) Received: by mail-pg1-f198.google.com with SMTP id d3so17337625pgv.23 for ; Thu, 27 Dec 2018 03:31:24 -0800 (PST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id x15si36505900pgq.378.2018.12.27.03.31.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Dec 2018 03:31:22 -0800 (PST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wBRBTBRX022245 for ; Thu, 27 Dec 2018 06:31:21 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2pmwm2gr7x-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Dec 2018 06:31:21 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Dec 2018 11:31:19 -0000 Subject: Re: [PATCH v37 0/3] Virtio-balloon: support free page reporting References: <1535333539-32420-1-git-send-email-wei.w.wang@intel.com> From: Christian Borntraeger Date: Thu, 27 Dec 2018 12:31:11 +0100 In-Reply-To: <1535333539-32420-1-git-send-email-wei.w.wang@intel.com> Content-Language: en-US Message-Id: <0661b05a-d9d0-d374-44e8-2583463e94c2@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: Quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Wei Wang , virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org, dgilbert@redhat.com Cc: torvalds@linux-foundation.org, pbonzini@redhat.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com, peterx@redhat.com, quintela@redhat.com This patch triggers random crashes in the guest kernel on s390 early during= boot. No migration and no setting of the balloon is involved. On 27.08.2018 03:32, Wei Wang wrote: > The new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT, implemented by this > series enables the virtio-balloon driver to report hints of guest free > pages to host. It can be used to accelerate virtual machine (VM) live > migration. Here is an introduction of this usage: >=20 > Live migration needs to transfer the VM's memory from the source machine > to the destination round by round. For the 1st round, all the VM's memory > is transferred. From the 2nd round, only the pieces of memory that were > written by the guest (after the 1st round) are transferred. One method > that is popularly used by the hypervisor to track which part of memory is > written is to have the hypervisor write-protect all the guest memory. >=20 > This feature enables the optimization by skipping the transfer of guest > free pages during VM live migration. It is not concerned that the memory > pages are used after they are given to the hypervisor as a hint of the > free pages, because they will be tracked by the hypervisor and transferred > in the subsequent round if they are used and written. >=20 > * Tests > 1 Test Environment > Host: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz > Migration setup: migrate_set_speed 100G, migrate_set_downtime 400ms >=20 > 2 Test Results (results are averaged over several repeated runs) > 2.1 Guest setup: 8G RAM, 4 vCPU > 2.1.1 Idle guest live migration time > Optimization v.s. Legacy =3D 620ms vs 2970ms > --> ~79% reduction > 2.1.2 Guest live migration with Linux compilation workload > (i.e. make bzImage -j4) running > 1) Live Migration Time: > Optimization v.s. Legacy =3D 2273ms v.s. 4502ms > --> ~50% reduction > 2) Linux Compilation Time: > Optimization v.s. Legacy =3D 8min42s v.s. 8min43s > --> no obvious difference >=20 > 2.2 Guest setup: 128G RAM, 4 vCPU > 2.2.1 Idle guest live migration time > Optimization v.s. Legacy =3D 5294ms vs 41651ms > --> ~87% reduction > 2.2.2 Guest live migration with Linux compilation workload > 1) Live Migration Time: > Optimization v.s. Legacy =3D 8816ms v.s. 54201ms > --> 84% reduction > 2) Linux Compilation Time: > Optimization v.s. Legacy =3D 8min30s v.s. 8min36s > --> no obvious difference >=20 > ChangeLog: > v36->v37: > - free the reported pages to mm when receives a DONE cmd from host. > Please see patch 1's commit log for reasons. Please see patch 1's > commit for detailed explanations. >=20 > For ChangeLogs from v22 to v36, please reference > https://lkml.org/lkml/2018/7/20/199 >=20 > For ChangeLogs before v21, please reference > https://lwn.net/Articles/743660/ >=20 > Wei Wang (3): > virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT > mm/page_poison: expose page_poisoning_enabled to kernel modules > virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON >=20 > drivers/virtio/virtio_balloon.c | 374 ++++++++++++++++++++++++++++++= ++---- > include/uapi/linux/virtio_balloon.h | 8 + > mm/page_poison.c | 6 + > 3 files changed, 355 insertions(+), 33 deletions(-) >=20