From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1780CD1284 for ; Tue, 2 Apr 2024 13:41:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D93D96B0082; Tue, 2 Apr 2024 09:41:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D45236B009D; Tue, 2 Apr 2024 09:41:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBD3A6B009E; Tue, 2 Apr 2024 09:41:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9DCE16B0082 for ; Tue, 2 Apr 2024 09:41:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 303DF1604D3 for ; Tue, 2 Apr 2024 13:41:41 +0000 (UTC) X-FDA: 81964704402.26.CE69A1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id E0C1512001F for ; Tue, 2 Apr 2024 13:41:38 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YXNHl5Yw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712065299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kTgWJA2PPXYKYHFI+8ELZvKCTBO0FwIIovgJVmEtaDg=; b=WtkqtM3rqSeOY2ZqRyVrCHZSJ8k7O9QWuM7KF2cSc75zRJo6XuZpLwLo/CY8iKrCbnm9Vb xzr6PYap4sLP2pbWhIqv0noHXXncWLffISIhc0L7BhglNA5vzaODV1lap9Eo2pj1cTNo/G lfvP0GWsH5lEkMh9sRRRl+8nHjmSx4A= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YXNHl5Yw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712065299; a=rsa-sha256; cv=none; b=L/kYHKL6LVKmSpAffsHqwB14+7Tsyd574hhwFF5g4ioxb1zwM4fy+fviJhXHPJm9UJMANk BtaT1ktwScGpkiuMbZn/lByPWV5TWH9nJJMiYGIFjPXa44rMdkZHxOz6NwwqcaApAZONhF jvdWmrn2rSaKVuZra+6W2Pzq4DWjA48= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712065298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kTgWJA2PPXYKYHFI+8ELZvKCTBO0FwIIovgJVmEtaDg=; b=YXNHl5YwgHdQWO32bArkkLYBrgumJmNGAqhdTtvgQBAlAhSHnvl4JjmB8SLKvaVNs5KgVT B6Awk7Nvw/724uKcmkbM3dsCj3vDDZ/Dc3dDMvBeLdfInyzsutKuUhUIhJXvnd6ONSS7b2 FohjpYtTUctAC/Ytkc1q+Bie5foyTdU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-5EednS3GPAK5HH3Z_z6sfg-1; Tue, 02 Apr 2024 09:41:36 -0400 X-MC-Unique: 5EednS3GPAK5HH3Z_z6sfg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3436714e286so484735f8f.0 for ; Tue, 02 Apr 2024 06:41:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712065295; x=1712670095; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kTgWJA2PPXYKYHFI+8ELZvKCTBO0FwIIovgJVmEtaDg=; b=RMfiZXcn5rVKLfimOapzas1VxWS+Eq7DmzVFwzzR/GGGJHdzH+IXdaUPCLS8GsYPhp hMp3ZO4f+gM9Q6CaEZQVZ9k/mhovv6wp6weltlvUFLoak8heSI8eugGYT0HjtinWoK9I FY0VVUFBxprYlVOwgInPn+T4nm4v28Xa0UQSX3iEuZBG9aZBDCCZYwobDTFN8GbVZWDP 8WQPysnfc1CtaZF0np4gwGz7TvryXFvSIO/kV7XGTWNkhEu/ymu8B3D4yPsSVwxB04ZV bXjl5knn8rQ1Fy5wQasT2aIO4nLYg9q50WG9PNSN4TPt7f09+z4nPcYJLdAMOMjCXiQp 7cxQ== X-Gm-Message-State: AOJu0YwX1qbh4OIcKDOZgoceij/nZmpV1acswtkA53bTAweX7jdDjKdk 65IqHBwAKHrkEGibAo5IMJ5h7BVFelmlIjNg6ojyOJWIHOXz3TCCurTHr23ti9LZPrDaBvTLqEJ xS4AUWSkV/NrW3mWJhyIA+9kbcBgFMkVcAtlRFS5u0HySx7XoCnSjkpq5 X-Received: by 2002:adf:face:0:b0:343:6b1f:8249 with SMTP id a14-20020adfface000000b003436b1f8249mr1128753wrs.4.1712065295738; Tue, 02 Apr 2024 06:41:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbDXPDb0TDjyEvGhnBg/ksEdkV+fWowvLSbQL10uXWA3/2a/MsY/RBEEaVLbUGAd+S67rieA== X-Received: by 2002:adf:face:0:b0:343:6b1f:8249 with SMTP id a14-20020adfface000000b003436b1f8249mr1128737wrs.4.1712065295323; Tue, 02 Apr 2024 06:41:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c732:e600:4982:2903:710f:f20a? (p200300cbc732e60049822903710ff20a.dip0.t-ipconnect.de. [2003:cb:c732:e600:4982:2903:710f:f20a]) by smtp.gmail.com with ESMTPSA id r8-20020adfb1c8000000b0033e206a0a7asm14246093wra.26.2024.04.02.06.41.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Apr 2024 06:41:34 -0700 (PDT) Message-ID: <0657a919-f56c-494f-b127-4fac213603db@redhat.com> Date: Tue, 2 Apr 2024 15:41:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Use rwsem assertion macros for mmap_lock To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240327190701.1082560-1-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240327190701.1082560-1-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E0C1512001F X-Stat-Signature: ooop7xym6jiagfrjcpkdx3o5sygapa3p X-Rspam-User: X-HE-Tag: 1712065298-167800 X-HE-Meta: U2FsdGVkX1/YQAyMem1809ShM1tfscykkW6N/8DZ5fNGfpub5tOQCfveiHmCRxZOIauSm/jLstBTFg2vsccIm3rwojPeRZk/NjAFCq3SIa6mt27szszSqlcCm88X9ePDUk+ujLaFzBo0eRM9gD5kWf6vsK0TVM1aiuMwWceLzCSqIuDfi8cEMKvsDIn8sgZl5rfbPHA5dpFRbc71PHbRcQY7LSpEX4EYN7W7gq9YRAXAr5IzD9ix5r4N8FZiRkwAdgdi2a8h4lgYIHzLtCB90QZI922Iix4iAsf90/7992V6aHMM1rBvFRu+n9q4nFdksnUtBTlb/re4/SHdWDCKfQ9d4QKuWDo+xiKuFx/UsN1JuTU4XtYLXV52CcLLHXEc28GazOsocpeZfV92pST17djgBcMg1AEkAfR7Eywsivy8XqXKqeK03hdT7xM2Z1SNnO56ZwsNLc7/TNOfqdyG2uLyJ1Lkd9OOY1I/joyvCwf59FUh8cFNbL7FNwjofNUu0hcqpWusZRb6+W6YfHMruoAsifAgWe8ffv+gFtmonm2dXoduJ8/8PBln+J3TrJqEdlGV9smb38LUnZrzn99zQ8uD6GJ5GcH5eB8f4Bnl08WGH+W3wkBpsiqT7dwQMn0CPtnUjJFb48DVm3q4j2k5RRPWGYlCNMOs7tQXBaKi8deJ6DDsV9UhofEgpYjOpCUJmazJywZkZgSRgGloMLpWdeEcdofy5BbGxiHvgk9Xjs/cIvMrZ9XH7gszA1VloF3sg/mligfR8QQWBGQHBRxS2o/I1lZeBvDywTGWNHVf6GabHRP/QdtKcT1Ek3JjgwAdf7SW0pS5ugtujILJ7OaPdmJXAO4LevpQfoB9Xru+xizRC3S0Q45EqSotZphE4PTnwIzCshAX5RL1yQLlMUTOCgc91whIzcl6rwoe6egfj/mENJCKF5KnCgjsDu1XBPfsCSAKRRME4WKW1lG56V7 iJQK+QQh MxqvA6AWJRksjIny9t9TT55LsMn8VGeKQJoiA121vzJPtmO42EcLCxxH+J8CMeuSRLm8MbkdzgwN7TOvdA381zlC+VG7ntNDHD4vtd9wl+LIyAzGoylCA/IAnXTc3LFB3NMamirFvX7VmFWmGhWSOED4BYPE4KJJuWMUShf5wK55/lH34mKvnQGPLYLzaZmR05cccwNNPdvtBpO8sn1WHKsItgSwiO7OZhI5hyMO6rRujKJdtkIQyw+gSa+OKc1UHhaFOhnY4/I6geji+9yX/EjqUqnepKG0h1TYe0jFZLI9Mh8gkq0nTxAopYRqocdX29M5eAwJxRzuhRRPw9PUmIfo8WninjwBE2s6LPptVoGUtEmk3NrHUamb8ip1QAZVKx1U1ucyskTrz36NaxTjVeXHq/x0JIxcnQisYOknpMRfUDXuNyOel48iCgwFUpSvJ+U1UFrdh+XyyMtCm6FesO0RMQ0QkIJiKNxdOHMJ+TPybWGF00o1WrMI2dr8rd3NXFAGBkqUbBfAzhpG8jtZk7W2MLKlo+jtKqsJRiTj0A9vnVmU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.03.24 20:06, Matthew Wilcox (Oracle) wrote: > This slightly strengthens our write assertion when lockdep is disabled. > It also downgrades us from BUG_ON to WARN_ON, but I think that's an > improvement. I don't think dumping the mm_struct was all that valuable; > the call chain is what's important. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mmap_lock.h | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/include/linux/mmap_lock.h b/include/linux/mmap_lock.h > index 8d38dcb6d044..de9dc20b01ba 100644 > --- a/include/linux/mmap_lock.h > +++ b/include/linux/mmap_lock.h > @@ -60,16 +60,14 @@ static inline void __mmap_lock_trace_released(struct mm_struct *mm, bool write) > > #endif /* CONFIG_TRACING */ > > -static inline void mmap_assert_locked(struct mm_struct *mm) > +static inline void mmap_assert_locked(const struct mm_struct *mm) > { > - lockdep_assert_held(&mm->mmap_lock); > - VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm); > + rwsem_assert_held(&mm->mmap_lock); > } > > -static inline void mmap_assert_write_locked(struct mm_struct *mm) > +static inline void mmap_assert_write_locked(const struct mm_struct *mm) > { > - lockdep_assert_held_write(&mm->mmap_lock); > - VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm); > + rwsem_assert_held_write(&mm->mmap_lock); > } > > #ifdef CONFIG_PER_VMA_LOCK Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb