From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BDEEC32771 for ; Mon, 27 Jan 2020 10:43:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2ECAD207FD for ; Mon, 27 Jan 2020 10:43:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ECAD207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=I-love.SAKURA.ne.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF99B6B0003; Mon, 27 Jan 2020 05:43:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CAB066B0006; Mon, 27 Jan 2020 05:43:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B99386B0007; Mon, 27 Jan 2020 05:43:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id A4F706B0003 for ; Mon, 27 Jan 2020 05:43:27 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 660E72DFD for ; Mon, 27 Jan 2020 10:43:27 +0000 (UTC) X-FDA: 76423077654.05.beef54_755d12bc3f715 X-HE-Tag: beef54_755d12bc3f715 X-Filterd-Recvd-Size: 2900 Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Jan 2020 10:43:26 +0000 (UTC) Received: from fsav102.sakura.ne.jp (fsav102.sakura.ne.jp [27.133.134.229]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 00RAh5iL081253; Mon, 27 Jan 2020 19:43:05 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav102.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav102.sakura.ne.jp); Mon, 27 Jan 2020 19:43:05 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav102.sakura.ne.jp) Received: from [192.168.1.9] (softbank126040062084.bbtec.net [126.40.62.84]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 00RAgwbk081074 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 27 Jan 2020 19:43:04 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Subject: Re: [PATCH 1/1] mm: sysctl: add panic_on_mm_error sysctl To: Grzegorz Halat Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, ssaner@redhat.com, atomlin@redhat.com, oleksandr@redhat.com, vbendel@redhat.com, kirill@shutemov.name, khlebnikov@yandex-team.ru, borntraeger@de.ibm.com, Andrew Morton , Iurii Zaikin , Kees Cook , Luis Chamberlain , Jonathan Corbet References: <20200127101100.92588-1-ghalat@redhat.com> From: Tetsuo Handa Message-ID: <063e702f-dc5f-b0ca-fe26-508a9f1e8e9a@I-love.SAKURA.ne.jp> Date: Mon, 27 Jan 2020 19:42:56 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200127101100.92588-1-ghalat@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/01/27 19:11, Grzegorz Halat wrote: > diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst > index def074807cee..2fecd6b2547e 100644 > --- a/Documentation/admin-guide/sysctl/kernel.rst > +++ b/Documentation/admin-guide/sysctl/kernel.rst > @@ -61,6 +61,7 @@ show up in /proc/sys/kernel: > - overflowgid > - overflowuid > - panic > +- panic_on_mm_error Maybe panic_on_inconsistent_mm is better, for an MM error sounds too generic (e.g. is page allocation failure an error, is OOM killer an error, is NULL pointer dereference an error, is use-after-free access an error) ? Also, should this be in /proc/sys/vm/ than /proc/sys/kernel/ ? > - panic_on_oops > - panic_on_stackoverflow > - panic_on_unrecovered_nmi