From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3213AC83F04 for ; Wed, 2 Jul 2025 13:52:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1806940007; Wed, 2 Jul 2025 09:52:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC875900005; Wed, 2 Jul 2025 09:52:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB99C940007; Wed, 2 Jul 2025 09:52:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A82E900005 for ; Wed, 2 Jul 2025 09:52:56 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 124241A0458 for ; Wed, 2 Jul 2025 13:52:56 +0000 (UTC) X-FDA: 83619465552.08.9932DEE Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf09.hostedemail.com (Postfix) with ESMTP id 3D67B14000A for ; Wed, 2 Jul 2025 13:52:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=IHSgeDF1; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf09.hostedemail.com: domain of usama.anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1751464374; a=rsa-sha256; cv=pass; b=R28zxPClWei3f2LkV8azwVTMjf2d7Ic8/4Cz5Td1nfh3RhUxLFl26EDk9ozpTS3tSG0F1B UuvoO98QamHm0p6/+bpaNo42CJmeAfQjsAt0c9e3U2Sm7SDEpcsA1KhjTxqYGTiybsW3mV gGXeW/CpvGGSFh6+BGKpXumZZMcxMaY= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=IHSgeDF1; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf09.hostedemail.com: domain of usama.anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751464374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WLop5YRYnvk33yfjiMinSUU35LkJkYkPTMm6xoYpTH8=; b=4ZHTmGfkIVv2lw7xfPWpWdSx1pe0WAQtaDYN7+u82m7fzhgP7Ko30ZNbJLCbfGQiv4rkoy M4LCuK/DXnDTlzJ5EaeHwSyWjbjzHZlTH3epgpkYtX1gOzPkJQa9k+IbjvPDFixHfJ+u/x TcHEKMEi3esomyjsPxxLUHpWRXymvWc= ARC-Seal: i=1; a=rsa-sha256; t=1751464354; cv=none; d=zohomail.com; s=zohoarc; b=COZR+/xkzqEj1RABaicuY/8T1zPmqotCQzMCaKFLGravjvW0y1DoA+f13S2RRSI88LjKHGzhDmf7gNSjgUwUNnAiHah5U6IeG2XAl0gwypkDeNed8ulY3p8HdYq2gXTZIXLC1BkgELblQXYMtSLdg8EZWxhTN74Vm57YXiVxz10= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751464354; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=WLop5YRYnvk33yfjiMinSUU35LkJkYkPTMm6xoYpTH8=; b=hzbJra6e/ITbMa4/vW9G46syohTHyLepEZQhDQpVPWLetntW2wXLtfikySwUL+PoiVRJ8trEtlTRpaOSL8Dl/l7yg9uiNIGaHPm5sVulNLG4w1n752M5X6ds1CMHL6+wNqO0ublRIVInGGtdlRxBYeZ/BtXKOEEAWUKtIkPvSmM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1751464354; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=WLop5YRYnvk33yfjiMinSUU35LkJkYkPTMm6xoYpTH8=; b=IHSgeDF153RnX53qjHTW6p/HUKgisTXQY09YQPRA6suBtQwJFIkoAkhd5ryO63sR qF5jyjQUbDheEcitvEq+YwOlmaOdZidMSqy1aZWqqePLl+kWpJCJpj95v4Xda7D7af4 Ql5O5hGBIdoQutH+t966LOxKp0dp769j4wrvNkeE= Received: by mx.zohomail.com with SMTPS id 1751464351413899.9669762890401; Wed, 2 Jul 2025 06:52:31 -0700 (PDT) Message-ID: <063b278a-ab6b-4c10-9ecf-f4ad7dbc8c14@collabora.com> Date: Wed, 2 Jul 2025 18:52:28 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: pagemap_scan ioctl: add PFN ZERO test cases To: David Hildenbrand , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250630102443.137809-1-usama.anjum@collabora.com> <20027e0c-f43b-4d10-a4d6-41dcc38145bd@redhat.com> <6846faf7-20b5-4f08-a8f0-9946f993b0e9@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3D67B14000A X-Stat-Signature: ur5a8iqbidkxbz9xzozqobma76yp6oxw X-Rspam-User: X-HE-Tag: 1751464374-279213 X-HE-Meta: U2FsdGVkX19MYHF4EyR0KELJDYI76++N/5JkxmKscJ8aFFxWpXJU2Qgja8mb/zDbddU7tLZ+XoZjduSSeqDvRPiDrYmlzkCWoj3z8zTJ6rV0nW437zckGXF/f9G1RZsYbdD2zbTyucrMNZlVvfrjBNvTEXQtaEBsXI02dQm7JAF2ItrYyOu/u0UsSKxie1xXzPwLX8a4nUkBQGD+dJXR89Ko4mVV9FSS2qBYgouLx96WPkFellH2sfw3xjRGGYSYxdGuigRdVh+apZ01vtAh4hH6X6Z5Ywz25DoHEVXusz4R0+MeoonlQooL7u79pak4Acn1kr3sNIreuo0+GP7HV79oGOJejBIs2fQGgfeq++uqdawd66ZKMpoFspnd89XNr0BE9dEWBwZrx0MNQXo9vfcNGc2+DEtRa6r19soGgBTIdMLkG0Y0ITa825XcsigFP7IcribRMOxszwl6xdiJq7VGEnIjKRHeFtkihUV09xcb+z60AN6fW28RZbpL3Koy0lE22rFTVmKgqE1Wxh+4lbkHM0P18onP21wBO5NOe3jaILcJvTVa+QCUc3k5Uov2BpRUrdS3KuADKdmtMAFaD6r9Yi22OSRpCQfe6w3wLyDGAZzwdYcary/zEWd9+ZzJCNWqC6H5HjxKzM633FLuIyQmkvkinW662LoKm0nRdvKcALH9Docg3klRCurNzbkZfe0BKOIXNFKj0KQFEqAi88hJZqQAX4yhU+wF5SUFTn1S3JpowQtVv6b2LO6fUR8kRKIbY0XTUUQE+MOzTz1nL4pZ97DEUPdJKfbAAMPLPJQKdu1EPKZAz2RK738aUj4sYLxg9tLWTxWDa5+lyMAObk4wDJ3EKo7HOLFYidCMRfUecr75AtQWsd4kDyUXuq6lYIOJz2pKTzVwS6rdV9KnZZc1AK2HEq+m6odth2CkY3R5+dmxBAaanaLTU2x9rgzvJr5GHRtLYxpCNF1gcHa 01zvHURi 7Mm/V7M6cc0h4TtxyN+5plRRqnW+k30KRR8sJWSbkJXgAdX0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ... >>> >>>> + >>>> +    free(mem); >>> >>> >>> Shouldn't this be an munmap() ? >> free() is being used to free memory allocated by memalign(). > > Oh, I missed that detail. > > I'm afraid memalign+free that might not be what you want: there is no guarantee that what you are getting hasn't been used before and is not already filled with other pages? I'm not sure I've been using memalign() to allocate aligned memory and the using madvise(). I'll switch up to mmap() for this test. I'll send v2. >