From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE00C5B543 for ; Tue, 10 Jun 2025 07:20:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBC606B008A; Tue, 10 Jun 2025 03:20:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6E2C6B008C; Tue, 10 Jun 2025 03:20:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B35696B0092; Tue, 10 Jun 2025 03:20:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9473D6B008A for ; Tue, 10 Jun 2025 03:20:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 469D41413B4 for ; Tue, 10 Jun 2025 07:20:12 +0000 (UTC) X-FDA: 83538642264.27.6096723 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 7C334C0003 for ; Tue, 10 Jun 2025 07:20:09 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RRheUhoW; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749540010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lrkpWK2U6JUfo5rI7RmYsKcjVK1dhQgwY8EFVlFCij0=; b=dAtbakwdqytm9dQ/+Geet+ECiEbl6jq6lxQo62awh2Azgzcd4jIXZXiX3859wzKa1p5Uvc okM8/HT2pmXw8i0uHHU99L0QB+JQK7OTgQAsb7oxDVydu7/vZl99vNVhBofdnlII1rE2ob 5KtoxxLBTNWOq9l5JOXZ7a4yXMUcmBI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RRheUhoW; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749540010; a=rsa-sha256; cv=none; b=xIOY0auq5pkZNwtSgH5arTUD3riSCU+r4asxIjE3wY5vHMz/B8z17YP47/F+KxGByH52n8 lPzlgCEiPoUIJFGqVrim4d9DinLZe6LSlnt7rR3gZAAeNSlMVZBsJfxSGd0zfbfP8Os9Y/ 13VFMe69ze57LKJdKCczmcRAEI60IOI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749540008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lrkpWK2U6JUfo5rI7RmYsKcjVK1dhQgwY8EFVlFCij0=; b=RRheUhoWF0x/Kd4euehduBkfReHwEuWJhLSwSMusjWpS/GdRCUyr0T7sXehJovQEcTfNgg j0hqQUnDsVPaYA28GGIai0pjlUuiLJbrmg1rVGO3piYnsaNnbtRBuNIrTHuUc8AJNd7ONY 9ROXPI4KiP0RGyIbbEiQOdEtFLTZEAs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-178-0mv_aQsINFaoO2MSI-mEMQ-1; Tue, 10 Jun 2025 03:20:05 -0400 X-MC-Unique: 0mv_aQsINFaoO2MSI-mEMQ-1 X-Mimecast-MFC-AGG-ID: 0mv_aQsINFaoO2MSI-mEMQ_1749540004 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4530c186394so9578335e9.0 for ; Tue, 10 Jun 2025 00:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749540004; x=1750144804; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lrkpWK2U6JUfo5rI7RmYsKcjVK1dhQgwY8EFVlFCij0=; b=a24/8CdeeslTDp/T2fWJkMEbIg4ok93AMmUdbZZxSvNFd0NPo2Ms/d8UHNoI6jHeEZ KDAiJ0C7wjbZY6PtAvV7fpMbqu6UoTbPctPMTM98o2aYegAisZ17GzuP5IQFVaXSOOeA SjgtMQX6hYndHNwlHNHakmqbXNwEzxWIZvgMqlf+v6/veQdInG1Y34Zhu2hapOQz/WKh 1j8PtobPa9qiVgif9dctQ8cWANPXy9NIIAgP+Xr2ZvFXHzbOqOzZjqwcJ5IMjkVoSUyd sGHb7QqCNqnAILWvKRR1IpktXv12tRbpHL8vvNdolPZsQyBt0m2aLiEC37MAApqULSQd smFQ== X-Forwarded-Encrypted: i=1; AJvYcCUkOjROj/0l1q/GokAC+hnBLEaUPq++gm9DxVSOTZHsabSAmUWcIV3rGw3GnyszQldgauhNCUbDyQ==@kvack.org X-Gm-Message-State: AOJu0YyRy4B4HZAocxpJQxaxqeBhqTV90I0mLuB2ABMPXND4sOjcP1R1 jXJ5MaczkqMvYQCQybuHekbWxjKj6jWS/Ar2PFzLq6R5Txzfx+0NaZ3RpjyzR2xPyLrH2nYqTlO n/XI/RZQG51sh6eZYH84jD4es0ZGNrUk+JFzRCQ1ejR9sLs/RCRYC X-Gm-Gg: ASbGncsBI6hG7Vvxc01cC8QXPClMk7jpMba3en7Us+utjunDMwQXy88ZIwbh8ze4BfG /1ZAJYBAbF1F5YIp2ieqZRR8JBT1n0ub2XMuPXO1NfBoQzFldd95LXDJFTOed4ty7KPLFvrhwqO qOpYjLEU5GvJe0CApldMzFTEuAD2Xz44FqKV1adfeubY/FUwgkizjy+ajlkJA5n7tQIS/M0MONn wrh/wmj1JuIHbh5TNkNt7b/hyWwBQ3aJO+UZGU3+bJJfI4qM8/Jw8EL3s3hJE9jsa6PgPnV3sOQ UraCyiNRRFjXOIBBNcEM33p3/fLLfSoVcihJ16e0DHqS1Sg07DIVuis= X-Received: by 2002:a05:600c:c119:b0:453:78f:faa8 with SMTP id 5b1f17b1804b1-453078ffbbamr61001555e9.6.1749540004222; Tue, 10 Jun 2025 00:20:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHViFKIB0RWSE0EdSBXJYyv2jdRztoVq/E6i/xbuG9PnxEvu7mKobFeXcECNG61rrdnCZhdAQ== X-Received: by 2002:a05:600c:c119:b0:453:78f:faa8 with SMTP id 5b1f17b1804b1-453078ffbbamr61001235e9.6.1749540003871; Tue, 10 Jun 2025 00:20:03 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4521370961csm131639105e9.22.2025.06.10.00.20.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jun 2025 00:20:03 -0700 (PDT) Message-ID: <06369558-6b58-4e0f-9f5d-e50dc693d53f@redhat.com> Date: Tue, 10 Jun 2025 09:20:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2] mm: use per_vma lock for MADV_DONTNEED To: Qi Zheng , Lorenzo Stoakes Cc: Jann Horn , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng References: <20250530104439.64841-1-21cnbao@gmail.com> <0fb74598-1fee-428e-987b-c52276bfb975@bytedance.com> <3cb53060-9769-43f4-996d-355189df107d@bytedance.com> <7cb990bf-57d4-4fc9-b44c-f30175c0fb7a@bytedance.com> <5fac6f20-2643-4d98-a29a-06471f156762@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5fac6f20-2643-4d98-a29a-06471f156762@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kQs45B408QdyxJWXiHMmMhkTWkWEMbFzX2VTQoMScQw_1749540004 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7C334C0003 X-Stat-Signature: yk1j3znji5s364mmgd5xqjzzjfrh6q1e X-Rspam-User: X-HE-Tag: 1749540009-385401 X-HE-Meta: U2FsdGVkX19Xj9OeQ35KAUc/URf4gqzzma/8VD+dlsyjyu+hFOiJlMNHMjE3J833wdCVJZeZES9i1vnn6TpRPQ0IcCB4YiV/x8U7nBv5+AsSjGcJ/1nNHWYdpoUaTD9XiArDsaAPGCXUfOwk8EzCjI/sxe9HdtEI0iUk+JIIi2i553zsJlfm/8O6YWVOq6YWzeb/bAvhZg9s7nw+nWaR/U4CKDoNQDuDBMVC0p60C67wuEkLjSzvW0o3uGtdHX4cS8Vbwy05nf3QREKXo4f2Fkv3OFjg12im3xqVAzSfHqACfKgvzPpZtB2RqtKhyJKgxqIeYOit7qDXq3H4pJBaZ/3XnXQuuJ6AqH5ZFw6uQynmpOkHVS1u/JAFNiSANxGBUxdQeFm43mvZ90PVsBBReKSLtdsDqA6ixo0jGkX/pg7vkDXD+iggj32ZvAdJOiU/YTFj1SiLkYiATlof1xpoWhXX3KZWiUMkGkKDetbOvevhhwiHpgCaeM7/FspWksJBUtq3OM88JiKX8ZyoLriGRL3QYf0TQlFdtIXfYUF4yg0T4xfivFaLJGK/F7pEHN50Cyc+4d/C2p+AenbZvZrE1QMDyc1hrF0LRIFtlguAd5s7x1IMXX+ICxJX485zfWFzSL2UyFgSN+iAvonyOaQv+zdVr2SQWzyfm94IMNmvI/hQJP5A2yUNIfx8Zi5Gdltc//zwBJUfsPj4jUGcOpIZqxjbD+458jUhdUNycxJCOmXoecU5lahXIB2X5udXS6R45yN8t631jd7SGzBOREPmZk0Y000d+tDUwgWolSGiwDMfx093bwoywLnR2zxlbxlCF0qW0K4IUXX7nyZKQljZmh0e/UoTT1RbIc/TY93wpRPmSwN68TcqIJQ36dO3Eewu3xry7nKEmVVJPp5473cBvbvFKDofDCChJaPKTvD/Ld2owTVwXpkVf7IUJHdkxqNjvRGKsqBOlUOBOvRJ88G UY1NcJI7 Y+FobU/tL6EvaFOhrJETwF3XYNqGzMeoN7f5ki7r4JnrogzxvlIT/ZkDXFzeX87r9xDaX4ebJCF/7nCZf/9GK7Njrm4dh6mKttbmVR/vdWOc+hPvI0Fk5y351mlGi9VNsxO1f9ZFcdWFHvCm9DDT93/HgS2jeN+Qv4hFJYXXuzukb1QkLBdr2aeTaqljk3glgXfROyzCLOI+zTX/8hTTth15bMk5VjxKoc73AvcLVvKtop23AlU5w0aa9z60k1poo/IuyPozMvCg0F6f05rlhk5q9Kk554BTB6Miu4RXK50OJtFEI2Zwz75bD97OJ9WJRlVjMwlJ9RyxUkGFUI71QC3GqX1Z1XQPh+LxLbIOjsMr9CGKC5CJvN4+3Srnj1Eq70a9yKloxDA3cKaCF0aKCq8SH5SCbm/Cp8wkKZdnLrexkG1ZOj4p/EqsK8Ua74f+Rta4ZuoJWH1R7746IAeJNsZxeGUeTQ41Fv9zFscPRNsUTk3wxvHuHUz7Ai/EvUyD0DwfWAmujvFTPxQg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.06.25 08:40, Qi Zheng wrote: > Hi Lorenzo, > > On 6/6/25 6:44 PM, Lorenzo Stoakes wrote: > > [snip] > >>> >>>> >>>> We could in theory always add another callback .pmd_entry_sleep or >>>> something for this one case and document the requirement... >>> >>> Maybe, but the SRCU critical section cannot prevent the PTE page from >>> being freed via RCU. :( >> >> Idea is we'd fall back to non-RCU in this case and take locks... but then >> ugh we'd race everything RCU and no it's all or nothing isn't it? > > So maybe the RCU+refcount method is feasible. We can release the RCU > lock after incrementing the reference count, which can ensure that the > page table page is not freed. I'll not that maybe after the memdesc rework, page tables will no longer have a refcount. Maybe. I mean, it kind-of makes sense, because nobody should really be taking references on page table. So finding something that doesn't depend on page-table refcounts might be better. -- Cheers, David / dhildenb