From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6049CC001E0 for ; Wed, 2 Aug 2023 02:32:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB8C4280118; Tue, 1 Aug 2023 22:32:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A679A280112; Tue, 1 Aug 2023 22:32:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 956A6280118; Tue, 1 Aug 2023 22:32:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 86683280112 for ; Tue, 1 Aug 2023 22:32:26 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 49C801206EC for ; Wed, 2 Aug 2023 02:32:26 +0000 (UTC) X-FDA: 81077590692.21.3E65F48 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 740FA40009 for ; Wed, 2 Aug 2023 02:32:23 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf17.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690943544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3pnJdhBwRWUq6HBnCx2cmZ1tuDZQpcYMzFaenOdYS00=; b=oYnabAU4YZYY+gEqYK5zCBOpf8+0ZjdhexjOxwj0bMfZ+3/KafexTHmw1yBRDHrVgp1F45 m9LoHczR4HE2CtP0s3oWL3bZJ4+WKY2aV4tYM8QOV4SIyljE3N3B9mWMAxcNbRgnsWSQG1 wQw9dTYD8iRKb3IbvwDxQcDkhzcO2QU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf17.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690943544; a=rsa-sha256; cv=none; b=uqit4aBaN1EIlFocNDwIMANdYSmZZxs/c4ipvvxizfBjHRNh8j8/9MohMId/XEpcjiazoz KuGh2LXiardRwZ1EA/PLwCNKtxRS5fvAdK/oEYY7KiIqHOKXokxF1iwHGyKSx1m8263Qwc HnIfurBb9VI+DuNpAr4iqlc+LWRJtP0= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R671e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Vot7YLG_1690943537; Received: from 30.97.48.77(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vot7YLG_1690943537) by smtp.aliyun-inc.com; Wed, 02 Aug 2023 10:32:18 +0800 Message-ID: <062e3adc-6d01-aa9a-8480-a4d845d4d4fe@linux.alibaba.com> Date: Wed, 2 Aug 2023 10:32:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/5] mm/compaction: set compact_cached_free_pfn correctly in update_pageblock_skip To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: mgorman@techsingularity.net, willy@infradead.org, david@redhat.com References: <20230729174354.2239980-1-shikemeng@huaweicloud.com> <20230729174354.2239980-3-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230729174354.2239980-3-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 740FA40009 X-Stat-Signature: agjnimpgcyo5t9nwza5xrr3r55dhdp3y X-HE-Tag: 1690943543-795445 X-HE-Meta: U2FsdGVkX19VNhm5WO8i5TAflg4kZzuhg3Uit2SlUpbege/e2ILC2DiTaGpR5nF7BR/TA6OM1OpWvkKeawJqkgCYw8kuiICvakOJw3LO/Z0UbtDzI4+2fwHrUlAm1xujhICkfnpBW6b7Nm4SKbCUwoa1AikrvdeaQp44XapW/VSE6lwOXXhC9Kjz7QOPWKPqMavxv+cpYQ9YFNg1uXOw+W+VunXxxayTb+u+AKX+ZOgRZ9Adeuehg1lcLccZgF4FgSkUHM2UiYK9tyv8EHgmGqNTv4a5qVwI1nbmN0tp2lb0zuRBVTP/dEZoRxa4rXvKaG6zXUFb+3cwvPgXyWHDjRadk/BLueSc3Ebo4ioR578x8xhhzIn8KgimO38FxIaV10gHFGe768ftqJnyBduWHHEu3PAWow3kkGVMnd418uNpYTZCp+EagbJq14u7cKDDQ8iv7biSAB+DKbyse+j0AjGyZIkwneOstLIRkMGe6L3Ids9qV1Jk+JSXWaugdqfFigTeFsbiT0yX0NeK1Qr55D9GMUCQPO+ZeZYMbcHU4MwhXQ/Xxdq1UiyVWuUnehkwMD7kvzli/ol/y/n7TQOW+FOZvuUAc00wDGa4EV1Y0sQNOVXLU3muJvmcIRwRrCaS5TNwo6yyZyj4YMDCc8ma+j/wp5y9lRex/d0plus3/ojsV5NODwwdHp6YW82iwxzoqZGQkqpNeT2mZbGtdKQx8N3dKvSjyBkQTobDFD3HZlPjMJmaQMB6J8DO4/Zz04uTv1z4meLORAtqeeb4I5ixnlyb74Wy8tCEMakE7ky4/6tra5fgLN+7RHDb2u3CejKPYBTRyYSvmNKA7VF7L8IfjhGjfHFo7o+h4ZxkRkRddu9HJgDuKro/uKgsQX94TQboQ6frHqVF9K3mgbOF7qF/Ss7nm6PjjpTQNZoutq6VT0gu5QB7Cdn7olQ3nEFtMlqQobeVodXgoYpciN1OOwM ZbxHLbIU F4kZq52QQAUQA4Jdmnuke4CBYG4UqJlaoB0G/ocgz/sRrhZMA4q8lykqYDatDBIDu4BX3pIKFGqf8GtFnMjRD3SNF5pt/IMqCg0UQTapzPEp9tmZsGq3baG4IhGVkH+HcYZOi7F53A/wj8bJQYEgQJTfiXNTq7D56NnP6i+ELeub0AYlju5Gb7qEW7qlSHau2jatm6Rv9T/IxvWKO9lY6ujL3Sw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/30/2023 1:43 AM, Kemeng Shi wrote: > We will set skip to page block of block_start_pfn, it's more reasonable > to set compact_cached_free_pfn to page block before the block_start_pfn. Looks reasonable to me. Reviewed-by: Baolin Wang > Signed-off-by: Kemeng Shi > --- > mm/compaction.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index d1d28d57e5bd..4a784872565a 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1690,7 +1690,8 @@ static void isolate_freepages(struct compact_control *cc) > > /* Update the skip hint if the full pageblock was scanned */ > if (isolate_start_pfn >= block_end_pfn) > - update_pageblock_skip(cc, page, block_start_pfn); > + update_pageblock_skip(cc, page, block_start_pfn - > + pageblock_nr_pages); > > /* Are enough freepages isolated? */ > if (cc->nr_freepages >= cc->nr_migratepages) {