From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2A5FC531DC for ; Fri, 16 Aug 2024 06:10:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EB3B6B02B4; Fri, 16 Aug 2024 02:10:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19BA46B02B6; Fri, 16 Aug 2024 02:10:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 063246B02B8; Fri, 16 Aug 2024 02:10:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DC0176B02B4 for ; Fri, 16 Aug 2024 02:10:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EAF68C18DF for ; Fri, 16 Aug 2024 06:10:38 +0000 (UTC) X-FDA: 82457084556.17.5D45ED2 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf07.hostedemail.com (Postfix) with ESMTP id DEBE740019 for ; Fri, 16 Aug 2024 06:10:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723788623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vr+UH8vJ00PTjflMa33d3G7BkKHQfnhwtSDm+eo5RE8=; b=xGT75uR2rGFTfHIsRY9+Zg6Hpf/j4hFlYzG8uP1sNevXua0S0ChPfz3qfK0I3Wvj4FxPva PFr5VCO7ek/vo/9VNoFt+YGVcI5UHFJcqVoJO4c+SnhnMrh1IAOqzeE926pv21V/Aipn0Z 27CMGyTE4cJzO3mrKaDlV6QV1mm6I9E= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723788623; a=rsa-sha256; cv=none; b=WkPcSjcySn8hKzz8Ui+cS+TWyrnIt7w154aT3egVepM1LYRbfFERUGq//3uR+vzhbK7ykw 9u+6KJLZctFYGLoF6eQ8+9QezcH6uKQWPxu5O4oyNYnmaG5Oj0bjqYfT8snAi0x4Dt4vT4 uMFFrSXr4uTk69Y+TqUvPibVaRgbeGY= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4WlWjk2lq6z1HG8l; Fri, 16 Aug 2024 14:07:22 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id B9E701400FD; Fri, 16 Aug 2024 14:10:28 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 16 Aug 2024 14:10:28 +0800 Message-ID: <062e2b55-d448-4f89-9a50-fbce995467ff@huawei.com> Date: Fri, 16 Aug 2024 14:10:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove migration for HugePage in isolate_single_pageblock() Content-Language: en-US To: Andrew Morton CC: David Hildenbrand , Oscar Salvador , Zi Yan , , Matthew Wilcox References: <20240816040625.650053-1-wangkefeng.wang@huawei.com> <20240815215808.c2086dfe013cf2e2360e8bd6@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20240815215808.c2086dfe013cf2e2360e8bd6@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Stat-Signature: ruibj47x5gbkn68hu9ftow33r6bw7qim X-Rspamd-Queue-Id: DEBE740019 X-Rspamd-Server: rspam11 X-HE-Tag: 1723788635-216342 X-HE-Meta: U2FsdGVkX18NeGRsw/UYgePu7GU9Nt5H/S0ACy0iLa5+mBgJxkSu2IJ4wqErBaK1N2gfi3hmT+qlAx/7iqL6ZoC+Dxw1fyf/rAl6k7HYmhKSQ/pIAtbMbVjufzleyMNtbvxRP5+5QAgsZtOSQjAL9rEzL3Aa4ecZC1AiEhqq77DLvPm49xc3Op6CpUzCcyX/e33C7xg6gdDxJHFMNE9tDBVKc0OzVTttdq0HwvoAu5EprLeTIAQaJ7G9Eh42I2gHZ8vP6MeP5VroUpWtZ7RJy1JaMDpvcF8b5TCEmTX6U0Ng/g8wTPxnJAVVkTkjXcA9C3vq3eOYLbuR/6GSWxzvu91w9gRdZvmJSmnETMV7+Q5FgmBMwj1bAKsz1M6jubbXAalflvFh1VFYFiO0VgnoBoJi3QzSwuxHQl3XGEJKY4A8s56hBkz8P5yStyMrVcuR0ih5DyyKbBeHJqGdzNR44VwtXKCmzbIIpcGB3pdzkhlZl3ZkQlAv65mUgA3RGWcv0sR8NxkIpvr2wU48AhLR0ZoF3oPNycMb/FGicBi4firSj5NmLFjjnCSA7C259BQNT/G9dXrNG0z26XsTu6nU4q6XQqkwnUFoC4mskkl5TFRVr6Cl8lSenqduvAtHtKX4sMbTc4cYeWbRq6ohp+E03T63OL4IPKIadGUpmrc2WDJLkPZey+NbtPXhV/y/bnxugitJrWXD9PidzrdzlILGi4FroNqz84yIVb2qWEk3PpeRBEYLoYVnsH+FtviXt51q5J2Y5GaTmNn/m27hqPUvyXT6ThjjjOwNg5IA2z/3o83M402yn0p0B7bMmg0GiV4EveyxsiROaDBNbPIxEFdveH6Nvd19mRP6NhxMUXnH5+4YnFJs9BOIwy/dHrK3HVogi/LuamGcuNkRv368h9HVRX7PXxVI7UiMbdRG0+qfkdQmDaOWPd8rJZIMfPEOl5NmW6Vt9oHFWxNr27gqdVo g1b9HGsj m10MnFQ3sIpwpC6dFU/Ukgv2UguPu+y3NIC24umBcvN+KbgTNxCgd5jgVuf1J0Q+cOBCi9/ARkUnl9QbSwckTUgZdWArJJW4yFEHP4vvXJmRnc29tTnbY8h8xi4eZB0uUPHOEwtRexRx30ltPqEcIpTnN5lUsSKEV5Rp2IFUCy1lgBwwSnDbLB4qS9LlqV+j3qUulpmgswQpWfVakULZc5wdhddYlqoxjDdX2BJ758CNfSBU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/16 12:58, Andrew Morton wrote: > On Fri, 16 Aug 2024 12:06:25 +0800 Kefeng Wang wrote: > >> The gigantic page size may larger than memory block size, so memory >> offline always fails in this case after commit b2c9e2fbba32 ("mm: make >> alloc_contig_range work at pageblock granularity"), >> >> offline_pages >> start_isolate_page_range >> start_isolate_page_range(isolate_before=true) >> isolate [isolate_start, isolate_start + pageblock_nr_pages) >> start_isolate_page_range(isolate_before=false) >> isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock >> __alloc_contig_migrate_range >> isolate_migratepages_range >> isolate_migratepages_block >> isolate_or_dissolve_huge_page >> if (hstate_is_gigantic(h)) >> return -ENOMEM; >> >> In fact, we don't need to migrate page in page range isolation, for >> memory offline path, there is do_migrate_range() to move the pages. >> For contig allocation, there is another __alloc_contig_migrate_range() >> after isolation to migrate the pages. So fix issue by skipping the >> __alloc_contig_migrate_range() in isolate_single_pageblock(). >> >> Fixes: b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock granularity") > > Should we backport this into -stable kernels? Better to backport to stable since memory offline always fail in this case. >