From: "zhangpeng (AS)" <zhangpeng362@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<sidhartha.kumar@oracle.com>, <akpm@linux-foundation.org>,
<wangkefeng.wang@huawei.com>, <sunnanyong@huawei.com>
Subject: Re: [PATCH 5/6] mm/page_io: convert count_swpout_vm_event() to take in a folio
Date: Tue, 18 Jul 2023 20:56:45 +0800 [thread overview]
Message-ID: <06241e10-e7f6-64c8-ef9a-1336d56b21b8@huawei.com> (raw)
In-Reply-To: <ZLVGqCwN3FxoQ7cy@casper.infradead.org>
On 2023/7/17 21:48, Matthew Wilcox wrote:
> On Mon, Jul 17, 2023 at 09:26:01PM +0800, Peng Zhang wrote:
>> -static inline void count_swpout_vm_event(struct page *page)
>> +static inline void count_swpout_vm_event(struct folio *folio)
>> {
>> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> - if (unlikely(PageTransHuge(page)))
>> + if (unlikely(folio_test_large(folio)))
>> count_vm_event(THP_SWPOUT);
>> #endif
> Since this is a THP_SWPOUT event, we should do this as:
>
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> - if (unlikely(PageTransHuge(page)))
> + if (folio_test_pmd_mappable(folio))
> count_vm_event(THP_SWPOUT);
> -#endif
Agreed. I'll convert PageTransHuge to folio_test_pmd_mappable.
--
Best Regards,
Peng
next prev parent reply other threads:[~2023-07-18 12:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 13:25 [PATCH 0/6] Convert several functions in page_io.c to use " Peng Zhang
2023-07-17 13:25 ` [PATCH 1/6] mm/page_io: use a folio in __end_swap_bio_read() Peng Zhang
2023-07-17 13:34 ` Matthew Wilcox
2023-07-18 12:56 ` zhangpeng (AS)
2023-07-18 16:16 ` Matthew Wilcox
2023-07-19 7:46 ` zhangpeng (AS)
2023-07-20 5:21 ` Christoph Hellwig
2023-07-17 13:25 ` [PATCH 2/6] mm/page_io: use a folio in sio_read_complete() Peng Zhang
2023-07-17 13:40 ` Matthew Wilcox
2023-07-18 12:58 ` zhangpeng (AS)
2023-07-18 16:21 ` Matthew Wilcox
2023-07-19 7:47 ` zhangpeng (AS)
2023-07-20 5:22 ` Christoph Hellwig
2023-07-17 13:25 ` [PATCH 3/6] mm/page_io: use a folio in swap_writepage_bdev_sync() Peng Zhang
2023-07-17 14:00 ` Matthew Wilcox
2023-07-17 13:26 ` [PATCH 4/6] mm/page_io: use a folio in swap_writepage_bdev_async() Peng Zhang
2023-07-17 14:01 ` Matthew Wilcox
2023-07-17 13:26 ` [PATCH 5/6] mm/page_io: convert count_swpout_vm_event() to take in a folio Peng Zhang
2023-07-17 13:48 ` Matthew Wilcox
2023-07-18 12:56 ` zhangpeng (AS) [this message]
2023-07-17 13:26 ` [PATCH 6/6] mm/page_io: convert bio_associate_blkg_from_page() " Peng Zhang
2023-07-17 13:46 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06241e10-e7f6-64c8-ef9a-1336d56b21b8@huawei.com \
--to=zhangpeng362@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sidhartha.kumar@oracle.com \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox