linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Qi Zheng <zhengqi.arch@bytedance.com>
To: david@redhat.com, hughd@google.com, willy@infradead.org,
	muchun.song@linux.dev, vbabka@kernel.org,
	akpm@linux-foundation.org, rppt@kernel.org,
	vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com,
	christophe.leroy2@cs-soprasteria.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org,
	Qi Zheng <zhengqi.arch@bytedance.com>
Subject: [PATCH v2 13/14] mm: pgtable: remove pte_offset_map_nolock()
Date: Thu, 22 Aug 2024 15:13:28 +0800	[thread overview]
Message-ID: <061a61c5871948680488ad02fd1e03547948a500.1724310149.git.zhengqi.arch@bytedance.com> (raw)
In-Reply-To: <cover.1724310149.git.zhengqi.arch@bytedance.com>

Now no users are using the pte_offset_map_nolock(), remove it.

Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
---
 Documentation/mm/split_page_table_lock.rst |  3 ---
 include/linux/mm.h                         |  2 --
 mm/pgtable-generic.c                       | 21 ---------------------
 3 files changed, 26 deletions(-)

diff --git a/Documentation/mm/split_page_table_lock.rst b/Documentation/mm/split_page_table_lock.rst
index 08d0e706a32db..581446d4a4eba 100644
--- a/Documentation/mm/split_page_table_lock.rst
+++ b/Documentation/mm/split_page_table_lock.rst
@@ -16,9 +16,6 @@ There are helpers to lock/unlock a table and other accessor functions:
  - pte_offset_map_lock()
 	maps PTE and takes PTE table lock, returns pointer to PTE with
 	pointer to its PTE table lock, or returns NULL if no PTE table;
- - pte_offset_map_nolock()
-	maps PTE, returns pointer to PTE with pointer to its PTE table
-	lock (not taken), or returns NULL if no PTE table;
  - pte_offset_map_ro_nolock()
 	maps PTE, returns pointer to PTE with pointer to its PTE table
 	lock (not taken), or returns NULL if no PTE table;
diff --git a/include/linux/mm.h b/include/linux/mm.h
index a00cb35ce065f..1d3e8882f6ba1 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2952,8 +2952,6 @@ static inline pte_t *pte_offset_map_lock(struct mm_struct *mm, pmd_t *pmd,
 	return pte;
 }
 
-pte_t *pte_offset_map_nolock(struct mm_struct *mm, pmd_t *pmd,
-			unsigned long addr, spinlock_t **ptlp);
 pte_t *pte_offset_map_ro_nolock(struct mm_struct *mm, pmd_t *pmd,
 				unsigned long addr, spinlock_t **ptlp);
 pte_t *pte_offset_map_rw_nolock(struct mm_struct *mm, pmd_t *pmd,
diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c
index 9a1666574c959..3b6dd8bb5b134 100644
--- a/mm/pgtable-generic.c
+++ b/mm/pgtable-generic.c
@@ -305,18 +305,6 @@ pte_t *__pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp)
 	return NULL;
 }
 
-pte_t *pte_offset_map_nolock(struct mm_struct *mm, pmd_t *pmd,
-			     unsigned long addr, spinlock_t **ptlp)
-{
-	pmd_t pmdval;
-	pte_t *pte;
-
-	pte = __pte_offset_map(pmd, addr, &pmdval);
-	if (likely(pte))
-		*ptlp = pte_lockptr(mm, &pmdval);
-	return pte;
-}
-
 pte_t *pte_offset_map_ro_nolock(struct mm_struct *mm, pmd_t *pmd,
 				unsigned long addr, spinlock_t **ptlp)
 {
@@ -374,15 +362,6 @@ pte_t *pte_offset_map_rw_nolock(struct mm_struct *mm, pmd_t *pmd,
  * and disconnected table.  Until pte_unmap(pte) unmaps and rcu_read_unlock()s
  * afterwards.
  *
- * pte_offset_map_nolock(mm, pmd, addr, ptlp), above, is like pte_offset_map();
- * but when successful, it also outputs a pointer to the spinlock in ptlp - as
- * pte_offset_map_lock() does, but in this case without locking it.  This helps
- * the caller to avoid a later pte_lockptr(mm, *pmd), which might by that time
- * act on a changed *pmd: pte_offset_map_nolock() provides the correct spinlock
- * pointer for the page table that it returns.  In principle, the caller should
- * recheck *pmd once the lock is taken; in practice, no callsite needs that -
- * either the mmap_lock for write, or pte_same() check on contents, is enough.
- *
  * pte_offset_map_ro_nolock(mm, pmd, addr, ptlp), above, is like
  * pte_offset_map(); but when successful, it also outputs a pointer to the
  * spinlock in ptlp - as pte_offset_map_lock() does, but in this case without
-- 
2.20.1



  parent reply	other threads:[~2024-08-22  7:15 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22  7:13 [PATCH v2 00/14] introduce pte_offset_map_{ro|rw}_nolock() Qi Zheng
2024-08-22  7:13 ` [PATCH v2 01/14] mm: pgtable: " Qi Zheng
2024-08-26  3:45   ` [PATCH v2 01/14 update] " Qi Zheng
2024-08-26 15:21   ` [PATCH v2 01/14] " David Hildenbrand
2024-08-27  4:33     ` Qi Zheng
2024-08-28 10:48       ` David Hildenbrand
2024-08-29  3:27         ` Qi Zheng
2024-08-29 10:59         ` Qi Zheng
2024-08-29 15:31           ` David Hildenbrand
2024-08-30  6:37             ` Qi Zheng
2024-08-28  9:48   ` Muchun Song
2024-08-22  7:13 ` [PATCH v2 02/14] arm: adjust_pte() use pte_offset_map_rw_nolock() Qi Zheng
2024-08-26 15:26   ` David Hildenbrand
2024-08-29  3:39     ` Muchun Song
2024-08-22  7:13 ` [PATCH v2 03/14] powerpc: assert_pte_locked() use pte_offset_map_ro_nolock() Qi Zheng
2024-08-26 15:28   ` David Hildenbrand
2024-08-29  7:21   ` Muchun Song
2024-08-22  7:13 ` [PATCH v2 04/14] mm: filemap: filemap_fault_recheck_pte_none() " Qi Zheng
2024-08-26 15:29   ` David Hildenbrand
2024-08-29  7:23   ` Muchun Song
2024-08-22  7:13 ` [PATCH v2 05/14] mm: khugepaged: __collapse_huge_page_swapin() " Qi Zheng
2024-08-26 15:33   ` David Hildenbrand
2024-08-29  7:25   ` Muchun Song
2024-08-22  7:13 ` [PATCH v2 06/14] mm: handle_pte_fault() use pte_offset_map_rw_nolock() Qi Zheng
2024-08-26 15:36   ` David Hildenbrand
2024-08-27  4:53     ` Qi Zheng
2024-08-29  7:30   ` Muchun Song
2024-08-22  7:13 ` [PATCH v2 07/14] mm: khugepaged: collapse_pte_mapped_thp() " Qi Zheng
2024-08-29  8:10   ` Muchun Song
2024-08-30  6:54     ` Qi Zheng
2024-09-05  6:32       ` Muchun Song
2024-09-05  6:41         ` Qi Zheng
2024-09-05  7:18           ` Muchun Song
2024-08-22  7:13 ` [PATCH v2 08/14] mm: copy_pte_range() " Qi Zheng
2024-08-29  8:13   ` Muchun Song
2024-08-29 15:36   ` David Hildenbrand
2024-08-30  6:42     ` Qi Zheng
2024-08-22  7:13 ` [PATCH v2 09/14] mm: mremap: move_ptes() " Qi Zheng
2024-08-22  7:13 ` [PATCH v2 10/14] mm: page_vma_mapped_walk: map_pte() " Qi Zheng
2024-08-22  7:13 ` [PATCH v2 11/14] mm: userfaultfd: move_pages_pte() " Qi Zheng
2024-08-22  7:13 ` [PATCH v2 12/14] mm: multi-gen LRU: walk_pte_range() " Qi Zheng
2024-08-22  7:13 ` Qi Zheng [this message]
2024-08-22  7:13 ` [PATCH v2 14/14] mm: khugepaged: retract_page_tables() " Qi Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=061a61c5871948680488ad02fd1e03547948a500.1724310149.git.zhengqi.arch@bytedance.com \
    --to=zhengqi.arch@bytedance.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy2@cs-soprasteria.com \
    --cc=david@redhat.com \
    --cc=hughd@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=muchun.song@linux.dev \
    --cc=peterx@redhat.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=vbabka@kernel.org \
    --cc=vishal.moola@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox