From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF2E6D5B154 for ; Mon, 28 Oct 2024 20:51:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77A256B00A7; Mon, 28 Oct 2024 16:51:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7276D6B00A8; Mon, 28 Oct 2024 16:51:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CB4D6B00A9; Mon, 28 Oct 2024 16:51:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3D6626B00A7 for ; Mon, 28 Oct 2024 16:51:28 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EACCE1A01E5 for ; Mon, 28 Oct 2024 20:51:27 +0000 (UTC) X-FDA: 82724206152.16.9494C58 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 5523910000D for ; Mon, 28 Oct 2024 20:50:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="AzBf1/SJ"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730148632; a=rsa-sha256; cv=none; b=yItxBdIcwSBDdy447OIRx6RVsyIT0LBUAxp4pRCqtqq0K8T0ShWQdfxAqh/l0+Pu0K1DIN ZfxHJQYnKxKSJUdkJ0NWMAwIJtFp0Qy/g28CRAzUnwskrWLgwa3hYXfp9MBuMOEEs1CQyt GoExW02dE7ybk6k8yDOTTHvPcTlRVM0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="AzBf1/SJ"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730148632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jglMBUH0rqWlBMLOhgpBoBeEyEUwnWucC7PIWz9hsqQ=; b=Lq7sNm3zA/87BIOWDVQ3VEdv+YSuUZ1CAl1STZDtgG2IqpKxWIn0iKyJOShHOwlu8c+hbO ZKNUBOYoBFjgHlfMqON25VZElZoBYFN3Nzyh7zTJ4auRUv8sm56D7QwxuT5Iz4Fm1hEp+3 mx1q3OzU3cENqs1o+ZSN7D5iQb6cawM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 66A3E5C5B1D; Mon, 28 Oct 2024 20:50:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70BFBC4CEE7; Mon, 28 Oct 2024 20:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730148685; bh=YVImwvRfK5SkCR0Ri+wW4EXpx6zRqJl2vuY6cmlakVY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AzBf1/SJXyeqwRAdwQRA5eLFwrmd+2xOAyN2y+115dwiC7KaEjKok+w6qdFBnnJ9e wEPiii/iF6oS9zRIymChTAi0YQ6owStm5c4K35txnWSoZpBht8uty2CnLxWUlUTmpK wFDDqKDnwzPy7aPCkhYw1Q2ijJQ/UoPJg9BzTAZUAnvf+NOnyNrTPgW3j2VjdjYTg8 0J0XBvD5qXF96x7F5u6G+YxotYCj2NGtaNliZnIdAdYyd2+ZEeWYQ0fV9lzR2nYsMZ tZzGxZwFgtcdFoh38kLOrOTqEuSZckUL3Qm5aKc6+CtIXmCrolMHSQwu+6DYRSY/TQ iORK8RDRSd8SA== Date: Mon, 28 Oct 2024 20:51:19 +0000 From: Mark Brown To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Aishwarya TCV Subject: Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour Message-ID: <0618af23-dca7-40b9-a083-47de9fcd7e50@sirena.org.uk> References: <6e8deda970b982e1e8ffd876e3cef342c292fbb5.1729715266.git.lorenzo.stoakes@oracle.com> <61461dcc-e455-450d-9c01-5465003fc31c@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HPJWBhFva0ZUDklg" Content-Disposition: inline In-Reply-To: X-Cookie: Remember the... the... uhh..... X-Rspam-User: X-Rspamd-Queue-Id: 5523910000D X-Rspamd-Server: rspam01 X-Stat-Signature: ki4px91mskugczi74t1zk8y5tkp1rig7 X-HE-Tag: 1730148641-237687 X-HE-Meta: U2FsdGVkX18WYpi6qjQA2PrK7zVsDyfCDU5vqDXO2xl/0VQAo8PWR5XQVo2FiUFx4QNN3aROQ+ED5c1eT20ejQYKy+6KT23U4I0Po/GyvNSfwHKd2vzQp+/7cPO75XV5I3cF2NVPktRtMc4iYuvY+8neNWEs+ZGh8ByoJWwECe4NAtYQDKaURxvkQMB+s44bTSymBWwbh9gh/++jQVam1No/ZxbMLzrmoZpxBwdR09XQTpGPNucMwjQGaS9mmOw4EJJ1D4YVHkl/1faFq9P2zZ65guapjrMpJfPyivz+kT9NJWQC3oetImE8mmnlVcSJLPsJUkBRvVjeSGrAt7Xi4H6/IIOaE3X4kNsoG0HqP7PwlA0x62p2IAACWtz4FG1o/MV+99UVdAVFhfNW/c+53Sapv5MqdmadU25HvY2FHCWo7Zdq6BGKy7/FsnDX5O/djWywqiJVimcLHgWl4qNbRt6gwXT+eR7tdsxFkBaWVc69TWZPU1Kb+H5+m1ns6zK+QqyqNdOYaU0oa0UAHhcbH9IrO7lF8eJoufVOTO6dEf1DO8LLEv5oRzrPUCjR9Ou7USWWia7vm1If5yvHhTvITOfIp04HKDoWgl95A7QLhzrN5yEcYXggRQku/vwPmszfR4lT+yF9izRXVwy/gkKR6bWL+5pr9N0yJN/PpY8gYpPYbFtTBERnz3HO5fXyxaOxZI4nPg8KWrL/3aaL3LEQ2tisn7HPCgtysUQnTOgxqCHGZR0sEMQedS37h66AOwO2krCfWyBDBKKVuzjtAHzdd+eGVXEmCAG1chWt9CQCDg7LJjMpfwHFA7oZUG0OWNdEw+T6ItSAfmfTTcWC1rNZhyrBuM10YZm/XI8ISebmnqK3fIMVemctUVn4eOYfjkv2sAVZ9LCyLCNx4fTo2NbG03xKnJLjzBtPkna3Zhlvjl7byvPRJYqWQDiZNpXhOvcuariPtYvKzZZQd0U61UF hs9+XhiC kC5dZ4mhHyojsQIZjTk/0M4nuGdl36CSJdY+nIKgFT0bfLsG5JysyOPbqUz0MiNztjGKUCtBs/PblmN/MuegMlSYNOxUO/0/u72Tq9Tz82dUHOdFZHS+ZTNTUtuLG0AtS1ZdTg3VMT0nwgLJwBv5kfLA3//ihhxrz+xqiV37L7AekonjXiYPWWF9MPlyNjUpYjnv1n602nz7BLNRU+ULxK1Noj72lXOFbJ++68FPCDT8WkB43HIQx8CeLiIl8jAk+W8WdTyiHdNW4xymrKbBYJBqHxlTZ9lgkn0WsZlJWKPK1olPvkERoRkP3pCd6lfYk/lF4AM9kVCt9DGjPW1lzAoDMD4Z+w73L7/3paqwMPO5nOsw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --HPJWBhFva0ZUDklg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 28, 2024 at 06:57:25PM +0000, Lorenzo Stoakes wrote: > On Mon, Oct 28, 2024 at 06:29:36PM +0000, Mark Brown wrote: > > any meaingful detail. There's nothing particularly instructive in the > > test logs, just plain reports that the tests failed: > On these memory allocation failures, could you tell me what errno is? Could you > check dmesg for anything strange? Looks like this is mostly figured out already but JFTR: As I said in the report there's nothing in the logs that I noticed, anything there is that I've missed should be in the linked logs. The errnos I'm seeing are all: # mmap(): Invalid argument (22) > > # # FAIL: mmap allocation > Interesting that it MAP_FAIL's though. This could be arch_validate_flags() being > moved around. > Could you do me a further favour then and try a kernel at this commit with: > /* Allow architectures to sanity-check the vm_flags. */ > if (!arch_validate_flags(vm_flags)) > return -EINVAL; > In mmap_region() commented out? Unsurprisingly given the above and the rest of the thread commenting out that check causes the affected tests to pass, I didn't check for any additional impacts. --HPJWBhFva0ZUDklg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmcf+UYACgkQJNaLcl1U h9CZHQf9FUhFRBSQGkNvWmC10WNDKbe/eWlGst9t5uiegBC++Eao7ztSSeFz/jHE FkqU4UEL8vgXe3qXhgI9JJD1YqU6g3lWuQPqmMR6g7spS8HDDAvcngWQG7fkZfMj iabxxefEINHDHC0tQhqXOiPfnAdXKu+q7tCOBbLpx82hkVOybKbJI+Y0lbk+QrQZ cPXneploajNGet5UF84W8ph/zc9jbyCDAh8zrR4tsalEHhAbyKf52n7Q5GCnr5hf HSCguShWK5nzbi0Q3ejHEJe0h7G0A28EC1m8RFqGS3YN8VI+HxWOwQUuFXpdxh1H SmC+WOXm/4ZelGFwPz3DNLXqvDoJYA== =2rTT -----END PGP SIGNATURE----- --HPJWBhFva0ZUDklg--