From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 880B9C677F1 for ; Mon, 16 Jan 2023 17:10:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB16B6B0071; Mon, 16 Jan 2023 12:10:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B60F36B0072; Mon, 16 Jan 2023 12:10:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A293A6B0073; Mon, 16 Jan 2023 12:10:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 94AAB6B0071 for ; Mon, 16 Jan 2023 12:10:12 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AC7841A0904 for ; Mon, 16 Jan 2023 17:10:11 +0000 (UTC) X-FDA: 80361300222.01.524CF23 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id A2F0E100017 for ; Mon, 16 Jan 2023 17:10:08 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Zid/6ohe"; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673889008; a=rsa-sha256; cv=none; b=NTHYmAqsc+aXOKHG5mtVOLxg7bVL+nXkHVhBB9FIxIrbO6z6lOFd/lh1Cu/fmimm1RyyBU XegtO8qIojKCc9IcndmAAgs8D5YJ5cw0ozdQRlizEKd5gZrks3DkGLRoLbdOmC5dcqu9hg 9FTJsZeS57+2wmZNA6Cya9D8N649b9M= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Zid/6ohe"; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673889008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i8TyWaBK0rrh9nu6bilmDzmOvJpbEYXbLFcWBZyCEYc=; b=it0XngNvN/W+iIZHMG0HM698eTIbwZlTqP3JmyUQ6I8KeQQxjQEO+fY1KaR56uwsig/q8c SRv0LiwyuMON004Ziy7fOXD3I/1c7Raam3NKCZURW0nS5hJ0JPKK7ne3ccvGbty9WRCUkI Tc5pfBCQBmSnTpdxOOaXlNBHID12u18= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673889008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i8TyWaBK0rrh9nu6bilmDzmOvJpbEYXbLFcWBZyCEYc=; b=Zid/6oheL89q7kXTlz6cuun4SBW61pZXnffaztFVFUVboChVKGJIiZBcJVuP9OUmNhWNOn ozRVPXCqHmIoQfEJuzhDmrmpR7/+GjFe8haWbX2Gti6GEbMDcYbzoRfn77tY8LU1i4hax9 sCGOwSuDPLQu7Dd1EvkJfs5MRQYtsts= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-197-w7QJK-2RPViGTCq-cTDUhA-1; Mon, 16 Jan 2023 12:09:55 -0500 X-MC-Unique: w7QJK-2RPViGTCq-cTDUhA-1 Received: by mail-wm1-f69.google.com with SMTP id 9-20020a05600c228900b003daf72fc827so2382573wmf.9 for ; Mon, 16 Jan 2023 09:09:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i8TyWaBK0rrh9nu6bilmDzmOvJpbEYXbLFcWBZyCEYc=; b=mhHnyuR2nqaURswlPfs+fZPWqEqkqVLIzhGTyxep8Or2jRuQh22LOhJ//DIp0oMDM/ jBC6GwNN376N/w7B2/2LQFwSkwtneJQv3OwdCoZSeAUesHEoSiGNulIn7XzvEMeuhAv0 Ycxlc6kXbPvP4F6j8Pj3CX7DUiXSXRY5cedU61OA0stVdwHkg/GVUAJYnVWxK/neBBNh o+nktzIynJRRuwmTgOhjGKGFb8Ue6pD+WsKKcfPlvFUiZToBbHumOdhwN2uy0+vMJKfr FZOl6jXDkdD4U/x9w5yyBGODMD25I9ufZFXpDrJP5qTXhmo9MulW3VQBINAqhBeVv3mw TsbA== X-Gm-Message-State: AFqh2kqJ8uee5ZSP0CY7Xc6uzOdEc5T5+mU2ouYR72kSv0EgT8I6Sn3r NC8ca8MG7S53TVp9pwT3GvM0NvotVT3dDMqg1xhwEnvZPYQd2DUkCeTtx4OU3fB8HagEd6oHlDx 4J59cvqyEtZg= X-Received: by 2002:adf:e991:0:b0:2b9:1a52:4f50 with SMTP id h17-20020adfe991000000b002b91a524f50mr8239437wrm.6.1673888994007; Mon, 16 Jan 2023 09:09:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXs7mvXxw8Q84+NmHtR/OTm4Mty+RhE+3nJjPMyUyIkH9Wox+5ZFG6IWOaX4Wg2wSZtWBXwm/w== X-Received: by 2002:adf:e991:0:b0:2b9:1a52:4f50 with SMTP id h17-20020adfe991000000b002b91a524f50mr8239421wrm.6.1673888993725; Mon, 16 Jan 2023 09:09:53 -0800 (PST) Received: from ?IPV6:2003:cb:c704:1000:21d5:831d:e107:fbd6? (p200300cbc704100021d5831de107fbd6.dip0.t-ipconnect.de. [2003:cb:c704:1000:21d5:831d:e107:fbd6]) by smtp.gmail.com with ESMTPSA id t13-20020adfe10d000000b002b6bcc0b64dsm14372975wrz.4.2023.01.16.09.09.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 09:09:53 -0800 (PST) Message-ID: <06185b08-8440-8922-c0aa-f6fb91aa54e0@redhat.com> Date: Mon, 16 Jan 2023 18:09:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2] mm: do not try to migrate lru_gen if it's not associated with a memcg To: Yu Zhao , msizanoen1 Cc: Andrew Morton , stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230115133330.28420-1-msizanoen@qtmlabs.xyz> <20230115134651.30028-1-msizanoen@qtmlabs.xyz> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: A2F0E100017 X-Rspamd-Server: rspam01 X-Stat-Signature: mbmurzeyc4pxkgeuykwgttqh55cqbe66 X-HE-Tag: 1673889008-620788 X-HE-Meta: U2FsdGVkX19tbj7b02VHHT0O4A5qGdbOX5zUm71dZ4db7TnqoBVhshICNgdmKFQDEj2dkBvVZwkdUJgmGxzzzWZI7eW8h7ebfDo7Tv2ObsNTuTULXykAZZxN0rxDTVAJOPXQCPi7EE4Ma7fpz7yzbST/WWY4BBGRkeiApUjoN5al3w00J5XoQHskCU4y5yUAz+6Bt+kEVRiX9TyCyCS+XxO3EtDHXSQhbHexkr9mTQl/w4jrK8ZtbuV/VuM+vn0AgPp+nbBhZfb0rrC3uk4eAjCEimKiY5SUA2GPjeH7WAsyv8vE+4/6MavheHEePmb+pwam3QbPuueXd4CPZdNbqbrQobq6wjv/TX6XeeJ2pIKLzOfbvFs8gO8pQD+o/sPbjvNOo6gdiX/gZqW0TfyHaqX9cP45HtyUtpgi2HDSodzaqlko8LD99VswCt94yeyMBWVcacID1PE6NHwJT1TilMBsz7e0arxNQvanTTe8fGtvWiIdYvbCcIAYvh/NOSAIrZaseK3P92Gbqw84Mur3q5cl5b1du5qCxpXwInybMYVJd4jI0qLbeBfoXSNYCsGTsItrNspq30/hZ0q6q/1ltzzEI+E9VaiO3LtRdc8Fc4lf9/76NEj8+PJkK5y23piu4HsKloL6RwkSGUQk+ctgKx8+keC80KxlVg9Mm0vy+KVWFSk+cqnqwRBYpLWYW/HZ5dWc5wexayALfEyPy29Im8XeJSk1afNNwyqvpHfaFPZSK8utihVGqXu2OS/uaO6L0Ys1Ax2+d8QJpcZ+gomksZj4d6+Vw7xD/v7md2oAahzUwr7TTj1FN8QegRnkUjpyZS1PgWeOKBnUFghJ2oFQK8cvdEYEl/zlr775BjInYJzoOdYH5hlgFSNBCBr/naa3RyEpbgACMVJCuxF6Mr5iM3Ui4RYuXEoDtQe4l3Qq0tanjutvuI3npjGMpg9pAhyuTF6bFB/+/QNywKX2zAQ 13fzj1Aw /8A2+muvpGeaVibEAGjjiupW162/+n1yvkNcg8IDVf1EpvyGMke6AwuMtH/mQWngvnpxl3F8YqtQ1oqPbBgy2nYG3/5vONrpShPiT3bdjgfW6lzd4osotjcVIkLI5bICcS/JnOqm8aKQZmS3ct9ijgHEFok/drQAveye0wDXcpiAwwtASFK56+sgjjfApXo07VdCNfDCPlAUDWaCLd4LriPK3OSo9gi9MtjkgCuKCqSQYwcwhVhYU1i6nDuJVmAoQ2EwFXjdnjNNuvXiSTJdqv7zzQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.01.23 00:13, Yu Zhao wrote: > On Sun, Jan 15, 2023 at 6:47 AM msizanoen1 wrote: >> >> In some cases, memory cgroup migration can be initiated by userspace >> right after a process was created and right before `lru_gen_add_mm()` is >> called (e.g. by some program watching a cgroup and moving away any >> processes it detects[1]), which results in the following sequence of >> WARNs followed by an Oops as the kernel attempts to perform a >> `lru_gen_add_mm()` twice on the same `mm`: > > ... > >> Fix this by simply leaving the lru_gen alone if it has not been >> associated with a memcg yet, as it should eventually be assigned to the >> right cgroup anyway. >> >> [1]: https://gitlab.freedesktop.org/benzea/uresourced/-/blob/master/cgroupify/cgroupify.c >> >> v2: >> Added stable cc tags >> >> Signed-off-by: N/A (patch should not be copyrightable) >> Cc: stable@vger.kernel.org > > Thanks for the fix. Cc'ing stable is the right thing to do. The > commit message and the comment styles could be easily adjusted to > align with the guidelines. > > I don't think the N/A is acceptible though. I fully respect it if you > wish to remain anonymous -- I can send a similar fix crediting you > as the "anonymous user " who reported this bug. Not acceptable: Documentation/process/submitting-patches.rs "using your real name (sorry, no pseudonyms or anonymous contributions.)" -- Thanks, David / dhildenb