From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9432C4332F for ; Fri, 16 Dec 2022 16:12:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04A038E0003; Fri, 16 Dec 2022 11:12:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3CB88E0002; Fri, 16 Dec 2022 11:12:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E04E38E0003; Fri, 16 Dec 2022 11:12:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D17C78E0002 for ; Fri, 16 Dec 2022 11:12:19 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8850DA010A for ; Fri, 16 Dec 2022 16:12:19 +0000 (UTC) X-FDA: 80248661598.28.62CE648 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 40D64C0013 for ; Fri, 16 Dec 2022 16:12:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MrxGFLMY; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671207137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PXgTNglDwNw3QzRYt0nVKdXtcIWSnTSnLY/hNQFklA8=; b=lLD5YfEr0GVA5ujL+t0HRmlkVDqFGj6UX6rDEmGC3fc40u5jnyjZvR1sRpkiKyG1DYTrSE 0uayGciDYdqULtaOZ3DkaiLvC5/H0tRBh0FO8Lu3LC61TTQIkmJepWWvV3H3eG5866ugJI 9Pd48YomSI01Cyhuoq9UTUflJwmnNxU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MrxGFLMY; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671207137; a=rsa-sha256; cv=none; b=1pB0sN2lvOxrVHI29PStSzerj57PkARa6f/MdIDFrBaMNqWfpakeN6gAOZaZTJS27PQlYA CQ73V85hW3xVYwUpSbP0kkPHOXmWbxPNK8WqSApi4hRtvBlnblEipEQSp1SLds2oWFGSuf 5P3PNODEyCQtcfq6l8M867kFwo7OeLA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671207136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXgTNglDwNw3QzRYt0nVKdXtcIWSnTSnLY/hNQFklA8=; b=MrxGFLMYtuEVKakJuqMJx5SHtdXoMj0Tby2uWi0GFVpheMZXmiDVLCMJPU7/RseIpo1/HH nwuZ47QAUvFjeszTR45lFqulbkerDgb844kCi82nzpFedocVTj3cWw8qQDeC+egrNzxnZR lXyfUTG2RYDvJwItvpx2bJRoEXXqQf4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-562-vnvJ815JNt6uYWTPGF3IEQ-1; Fri, 16 Dec 2022 11:12:15 -0500 X-MC-Unique: vnvJ815JNt6uYWTPGF3IEQ-1 Received: by mail-wm1-f69.google.com with SMTP id o5-20020a05600c510500b003cfca1a327fso1383479wms.8 for ; Fri, 16 Dec 2022 08:12:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PXgTNglDwNw3QzRYt0nVKdXtcIWSnTSnLY/hNQFklA8=; b=1Ofxl6hX400Jtk81UXDbgDYYLReK1OJZHFst1mOXLnukNh2g0lcp0YnqxfPD1lL8Jh rJXvH6M53LSogBoYIC97lxx8p8INb2hZ/n/cJrlueE+UBQ9vFrB+7KtWz+hrOtrWtX63 sbJO2rRDRvmbdxTRDeXRtqvjXg+WAZN8jscqpPcpppOkNI+xz4a2lY4YU/DYiXOy1VFc 2N9VZBj5yKoFvOFkZCtH1BrQhsitchyP9/RVVy479X8TQnGLpl3p4EbkgFD4oAaDeFWe 7Af3rUsy5vvUvpWMlVP58PTfOXHvWRFdEvhJnYQ+U3v+rMvCpczBMAfjDoRZrw8kmpoi kLPQ== X-Gm-Message-State: ANoB5plOwpU2wiWnZmXReVpE5xG8ClrCpDa8n5b/VTcnM57JP01PpKAB fSukHK5HpdLb8JeNPksiYhkHZOLtZAWZxnnrDGtLPvxGX8iKu3WbWS3U96CY/hbAzHYMYGWbr/9 w7grsdXJdnqI= X-Received: by 2002:a05:600c:3d12:b0:3cf:7903:5646 with SMTP id bh18-20020a05600c3d1200b003cf79035646mr26187485wmb.24.1671207134415; Fri, 16 Dec 2022 08:12:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf6BgraJ7ZC9QDnyV4jiSVGe5oF3oq7KBvgD7xPmW94b3HB58zDKJ25FA8Jg3t/JBZCZA8FMbA== X-Received: by 2002:a05:600c:3d12:b0:3cf:7903:5646 with SMTP id bh18-20020a05600c3d1200b003cf79035646mr26187462wmb.24.1671207134189; Fri, 16 Dec 2022 08:12:14 -0800 (PST) Received: from ?IPV6:2003:cb:c71c:3900:7211:d436:8d8b:531c? (p200300cbc71c39007211d4368d8b531c.dip0.t-ipconnect.de. [2003:cb:c71c:3900:7211:d436:8d8b:531c]) by smtp.gmail.com with ESMTPSA id m22-20020a05600c3b1600b003cfd4cf0761sm11944714wms.1.2022.12.16.08.12.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 08:12:13 -0800 (PST) Message-ID: <0616b909-b851-0f00-2bd9-f86562af6342@redhat.com> Date: Fri, 16 Dec 2022 17:12:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v4 9/9] mm/hugetlb: Introduce hugetlb_walk() To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: John Hubbard , Muchun Song , Mike Kravetz , Nadav Amit , Andrea Arcangeli , Rik van Riel , Miaohe Lin , Jann Horn , James Houghton , Andrew Morton References: <20221216155100.2043537-1-peterx@redhat.com> <20221216155229.2043750-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221216155229.2043750-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 40D64C0013 X-Rspam-User: X-Stat-Signature: oftsz78un94jufqszpbb49ckxi3d85ds X-HE-Tag: 1671207137-526008 X-HE-Meta: U2FsdGVkX19f6q+43GMCb92GJBZF+ukJy0t/5jiXjztC0gVVUAOi+A+ezzHhs0I9HRvDVRnGgX3OOkVEuO0DnY5t8I7uziehCa0Fdt3RjMACvEsyIzdu9aIkGnkJVS3B8stYRed0CDpSWNWuxFdFans2q9aidSVaROGFfu/SdxZCb9r695QjlyL4vtRjkmGRm4hVKcMMn0ODeQ9u73IxOQldr1jsQl21ZS2uSBVkR9TTlXJrs8Vb6/zX4dMgl+w1wIDHDi1WOrIY6nsskOavZC4YjOxOsiLGSkiAN15C+lFsWhDb0mkEPVkpgdUyYiAmNzTI9j1sZAB5wQBBG3dYckfxle6ZI9hUr4onGOPzBdVNqKoFfAP+G1qtPAjKmefNfDQDoOphB9j3TJGgZiE/m5puPeyCsB8YrPDN5sJJVnfcfpz4JVgvSKzmCyB9cY5Hkn/OwyUUbDqIYrLGkzLwV71euvgIaLHlLW/ke7gSJrpcQCnyUca4zpY5hp/pvtsmEVONaF+qvhGDPpWbQtnT9Wx3QzASXqAdxcWogq1C1xw0PMjgSfndOslFVlyF5HbZsJGf8Gj0nQpigDScM2gIoxZmGk/w/qpYUEOSOJW8i7iqpJq6Mq8Krd1YKCO0Ups0qVr5fRvMk92SMV8DZOu7obv+V9SFn1D1+eNnYVHpBYNeHp7CBsKi4Eudu/CV6lGesdFtR6O4IK60wD4zcb/CotMtG5ZEMTu8w8kgpfU46UrOMUh1EFYrjGRBJEnAPJTWMGZCqCxXgc2x4Kpl/4GB6n4L+gn5CnEli8w80AN2VowvInDcl6f7uzELIuV0UFiE1BipCb3mNwh4Q3MurFiVQdAT0mgZNFCplDLMJfgDspO+4/gCvbyrDhGS/GePvnneUVFN/S4y1dydIg7mOlaP3Gc78tPsGIDF5GabO2pB6x08gF2WoQFsyeIwdZEl+Bg3lL7r00buncaroA/fH/i FlkCSdIS ZPB2Fe8TDXQUMM1v7v4Q8IJFpYSSCvnIUHUHEXUirHVwbLjrrK0k4SUzK7mgu4KNa6VSaZzw2o8kqfGPTSboPFcXEe/CTu+r2U3lHckcQGCfDlvOdl9vbNEO/1v2NJgUqHhByLoAnG/swA/PEi1eKipPPvT/un0Y2jyxge9JU0kU788NInD6PW7W3cf/lxIo5PVy+15zMKoefPvnORLLDACLU59QPC1N8ntIDJ3AmCa4jgQ3eOBbtWBM66VhHDimkWn4T+WY9DOGuglk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.12.22 16:52, Peter Xu wrote: > huge_pte_offset() is the main walker function for hugetlb pgtables. The > name is not really representing what it does, though. > > Instead of renaming it, introduce a wrapper function called hugetlb_walk() > which will use huge_pte_offset() inside. Assert on the locks when walking > the pgtable. > > Note, the vma lock assertion will be a no-op for private mappings. > > Document the last special case in the page_vma_mapped_walk() path where we > don't need any more lock to call hugetlb_walk(). That looks cleaner and the lock assertions are IMHO a very good idea. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb