From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: John Hubbard <jhubbard@nvidia.com>,
Muchun Song <songmuchun@bytedance.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Nadav Amit <nadav.amit@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@surriel.com>,
Miaohe Lin <linmiaohe@huawei.com>, Jann Horn <jannh@google.com>,
James Houghton <jthoughton@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4 9/9] mm/hugetlb: Introduce hugetlb_walk()
Date: Fri, 16 Dec 2022 17:12:12 +0100 [thread overview]
Message-ID: <0616b909-b851-0f00-2bd9-f86562af6342@redhat.com> (raw)
In-Reply-To: <20221216155229.2043750-1-peterx@redhat.com>
On 16.12.22 16:52, Peter Xu wrote:
> huge_pte_offset() is the main walker function for hugetlb pgtables. The
> name is not really representing what it does, though.
>
> Instead of renaming it, introduce a wrapper function called hugetlb_walk()
> which will use huge_pte_offset() inside. Assert on the locks when walking
> the pgtable.
>
> Note, the vma lock assertion will be a no-op for private mappings.
>
> Document the last special case in the page_vma_mapped_walk() path where we
> don't need any more lock to call hugetlb_walk().
That looks cleaner and the lock assertions are IMHO a very good idea.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2022-12-16 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 15:50 [PATCH v4 0/9] mm/hugetlb: Make huge_pte_offset() thread-safe for pmd unshare Peter Xu
2022-12-16 15:50 ` [PATCH v4 1/9] mm/hugetlb: Let vma_offset_start() to return start Peter Xu
2022-12-16 15:50 ` [PATCH v4 2/9] mm/hugetlb: Don't wait for migration entry during follow page Peter Xu
2022-12-16 15:50 ` [PATCH v4 3/9] mm/hugetlb: Document huge_pte_offset usage Peter Xu
2022-12-16 15:50 ` [PATCH v4 4/9] mm/hugetlb: Move swap entry handling into vma lock when faulted Peter Xu
2022-12-16 15:52 ` [PATCH v4 5/9] mm/hugetlb: Make userfaultfd_huge_must_wait() safe to pmd unshare Peter Xu
2022-12-16 15:52 ` [PATCH v4 6/9] mm/hugetlb: Make hugetlb_follow_page_mask() " Peter Xu
2022-12-16 15:52 ` [PATCH v4 7/9] mm/hugetlb: Make follow_hugetlb_page() " Peter Xu
2022-12-16 15:52 ` [PATCH v4 8/9] mm/hugetlb: Make walk_hugetlb_range() " Peter Xu
2022-12-16 15:52 ` [PATCH v4 9/9] mm/hugetlb: Introduce hugetlb_walk() Peter Xu
2022-12-16 16:12 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0616b909-b851-0f00-2bd9-f86562af6342@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=jhubbard@nvidia.com \
--cc=jthoughton@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=nadav.amit@gmail.com \
--cc=peterx@redhat.com \
--cc=riel@surriel.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox