From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D4E1C433EF for ; Wed, 13 Oct 2021 11:03:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 009B960F23 for ; Wed, 13 Oct 2021 11:03:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 009B960F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8B8D86B006C; Wed, 13 Oct 2021 07:03:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 869566B0071; Wed, 13 Oct 2021 07:03:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 730BB6B0072; Wed, 13 Oct 2021 07:03:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 61B126B006C for ; Wed, 13 Oct 2021 07:03:49 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 25DD78249980 for ; Wed, 13 Oct 2021 11:03:49 +0000 (UTC) X-FDA: 78691128978.08.157A985 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 8F628103E641 for ; Wed, 13 Oct 2021 11:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634123028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y/2FvTkrvRaZFDD/R5GB2f6SojbGXUxQ9SlEpW8CqjQ=; b=hhKeKDbIKJW4/DYQJOm1ZkVFvSitsM6+5ZyVyg55L7Zzh2IItgFLlie11csMegxGqajzxI ZCk1WGl/OP/nm2peAHrtT+gN6RQvNiJnMb4zSuu6dymLp0MhyZK46v80a7MiSyilQEkkh+ WrguTOuhptsyNasAF6AQIh5awiU9t6g= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-520-y9cMqw_IMOSqc-t7emhnjA-1; Wed, 13 Oct 2021 07:03:46 -0400 X-MC-Unique: y9cMqw_IMOSqc-t7emhnjA-1 Received: by mail-ed1-f70.google.com with SMTP id v9-20020a50d849000000b003db459aa3f5so1860214edj.15 for ; Wed, 13 Oct 2021 04:03:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Y/2FvTkrvRaZFDD/R5GB2f6SojbGXUxQ9SlEpW8CqjQ=; b=RSge45L6A+pr8lLPXOMov3sIHosVsbRFN5FPuGoGh2pL677d4a+1H+rgoeh41X01uR IqkxkvZoI9TeGfJEVjGcSvAJS7viyAueZbdIgn03nrSqGdyZoZtvnejwwsQHN6w1PFo0 GCb0Nkd/heicRlxBoZbVBvHUpYMKpaChMbslAd+YXa1L5SHyjlvyjLSvFYQecyg+Wbft x8i9Y7zc/DKQKEacfJm6N5FvP5v1pQWtspfbfvFNDguASGtRemH0yPnUiAk6omn0IjHG swN/Qw5FVhRLqk/o5TRvyxkYTDvT7/JY/93s58/u751yN89tnUua35w2AfYhFU3eF/84 0Pdg== X-Gm-Message-State: AOAM530LxeDSAuRl6Xs7fgHxvxVZLYV2+6+OTCSdGE/jCzjjetcadX2+ GNA9JjHfFf86Uy8L17TLawJb3arWz51RhFdwUxJOfhFMMxwW+uTwp/yA8rzh44Kzh5uvFAZKEWM EQN5uVdEYLaY= X-Received: by 2002:a17:906:7854:: with SMTP id p20mr17658253ejm.19.1634123024559; Wed, 13 Oct 2021 04:03:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxb0/VI3uI5VDpiK/LgFzU/OD5mBR8hGNWRbUCXs0dRKTlIMkmREQ2cbUALKxYRPD1ToqMg9g== X-Received: by 2002:a17:906:7854:: with SMTP id p20mr17658212ejm.19.1634123024250; Wed, 13 Oct 2021 04:03:44 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x11sm7758297edj.62.2021.10.13.04.03.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Oct 2021 04:03:43 -0700 (PDT) Message-ID: <06148349-fcaf-0884-c33b-9075386b45a1@redhat.com> Date: Wed, 13 Oct 2021 13:03:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] KVM: x86: fix noderef.cocci warnings To: kernel test robot , David Stevens Cc: kbuild-all@lists.01.org, Linux Memory Management List , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov References: <202110131712.NcsZ1doh-lkp@intel.com> <20211013090840.GA18593@c02aa4e9d65a> From: Paolo Bonzini In-Reply-To: <20211013090840.GA18593@c02aa4e9d65a> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8F628103E641 X-Stat-Signature: 8nzm8dxdwygm8eu6ejqqh36umuz1ydxc Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hhKeKDbI; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf13.hostedemail.com: domain of pbonzini@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=pbonzini@redhat.com X-HE-Tag: 1634123028-995738 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13/10/21 11:08, kernel test robot wrote: > From: kernel test robot > > arch/x86/kvm/mmu/page_track.c:95:39-45: ERROR: application of sizeof to pointer > > sizeof when applied to a pointer typed expression gives the size of > the pointer > > Generated by: scripts/coccinelle/misc/noderef.cocci > > Fixes: deae4a10f166 ("KVM: x86: only allocate gfn_track when necessary") > CC: David Stevens > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 8006b911c90a4ec09958447d24c8a4c3538f5723 > commit: deae4a10f16649d9c8bfb89f38b61930fb938284 [4556/7806] KVM: x86: only allocate gfn_track when necessary > :::::: branch date: 3 hours ago > :::::: commit date: 12 days ago > > page_track.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- a/arch/x86/kvm/mmu/page_track.c > +++ b/arch/x86/kvm/mmu/page_track.c > @@ -92,7 +92,8 @@ int kvm_page_track_enable_mmu_write_trac > slots = __kvm_memslots(kvm, i); > kvm_for_each_memslot(slot, slots) { > gfn_track = slot->arch.gfn_track + KVM_PAGE_TRACK_WRITE; > - *gfn_track = kvcalloc(slot->npages, sizeof(*gfn_track), > + *gfn_track = kvcalloc(slot->npages, > + sizeof(**gfn_track), > GFP_KERNEL_ACCOUNT); > if (*gfn_track == NULL) { > mutex_unlock(&kvm->slots_arch_lock); > There's already a patch on list here, I should apply it soon. Paolo