From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F149EC369B2 for ; Thu, 17 Apr 2025 05:14:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28462280118; Thu, 17 Apr 2025 01:14:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22FE2280108; Thu, 17 Apr 2025 01:14:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D15F280118; Thu, 17 Apr 2025 01:14:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E48A8280108 for ; Thu, 17 Apr 2025 01:14:33 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6B817BA7AE for ; Thu, 17 Apr 2025 05:14:34 +0000 (UTC) X-FDA: 83342370468.01.BFD7870 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf11.hostedemail.com (Postfix) with ESMTP id 493EE40002 for ; Thu, 17 Apr 2025 05:14:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LndnrNTi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of gmazyland@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=gmazyland@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744866872; a=rsa-sha256; cv=none; b=ENMlglXVsf8y++Ygb26w6HvCp/d5s7nJJsnPkO+FGUOMyJ4RS3EQF4rmDgg675lIf6xrH7 YNVyfH0/egtyIiAqUTdztJoQTzPb6yquRVXhDOwQnlpyZf2lJqCh2euEr3dWLWMs2Lc47y cMLvy7lAZOTRCXfkU77aP6obUZAUa/M= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LndnrNTi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of gmazyland@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=gmazyland@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744866872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/6VVGbk7/10nDXV6MbjXzf9QqxxSVAmsbxmL+ya7Ong=; b=KEMKxuCJPjWTNaC2GvgEK7k9hsrgNit/E4BIwWnjE40f8U4D7Qx2PF4UZkuOAZTx1WbwgL maUR8RUQ+7L2gTBXGplQZ2ykNH3oemvyR6+lp0BeaqJCGr49mAxPdteiATA0poWUbxmQ4a qeuN7H98uwsZBKbGxn9nMctjTEbZ1vw= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-acb2faa9f55so43078066b.3 for ; Wed, 16 Apr 2025 22:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744866871; x=1745471671; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=/6VVGbk7/10nDXV6MbjXzf9QqxxSVAmsbxmL+ya7Ong=; b=LndnrNTiogRAQGoyrOO6uw7F6BrtXzNN9KPvKWQxWVwtLFrAzOh7xI5umoFEi1oswu tfSLOrBNhc/LsG0O52Mutvgt9EDDoI8okAmTcJ5xBU0PwaeGm7W5zdqik03jbaBb8avl hLA/KFgBjC4lNfzR4epk+3241cHjPW5OHSdDJCEP3kQbLa2L0xVJf4p8Ir8EU2O1IQkG UX+6l+AqHW79QwQSPmFair2mBhnnhYajWARcOUQC5rhRaH6INSY3MCSuvvZBk+OVw1nW CF3wZXOE9wZJd0hhwoghP31Ou5lxRrgNP6buN0KtdoY+z+lrRM8Nf6Iqf/CNJEN4to7n VR/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744866871; x=1745471671; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/6VVGbk7/10nDXV6MbjXzf9QqxxSVAmsbxmL+ya7Ong=; b=jJcQO5t//hzwSCwNFhtFeY6gR9bv5N8K7hE9s3tKV4eZdhQ+wwoilVUBY4cQlFsM5+ xdZiMVXtLovu6QvFgnK+MeyPeJ/GLnes4JwOJraazZiAD/3F5XVKgVPcV1VCJb2z6s4h ClNQ6St/53owqHtPRCITk73h7d8xG8N0sAop30O+4StnT7r21FagGR1ZobBOnvTRL0sC XWjmG0MYgkhnIGo9THV5ShaV8AYv7Z6eDMMPC1pCtgGumaMeeOHrYX9R8NQKeF8VrFzW 4cT8fQDtk9Cj2RZSKN8Fnpy/UWQoTbeOv/2FBAAcL9O2+gMeIBb6M2jiKfFhRIY1F5M7 eBDg== X-Forwarded-Encrypted: i=1; AJvYcCUiGEJxRzL4Le0yc2mHFTOG69aSXRkPoMA5/xjgcncCUpk2FPn9GXn8AdEPnTN8ivXqFqYbHJZ+vQ==@kvack.org X-Gm-Message-State: AOJu0Yx8Kczh7+ffiCHIzeIjy+H63kaz3GwP3op2UlarmkjkBOH+Mts3 8bpogqTDK/i8+Hx3JOgYAEtcQsmvC3QDlnQnxtNAv4+sGNYxbL5V X-Gm-Gg: ASbGnct0bDQOy3y1dbpVzSUZ1wLz3KouR3M3IsWURXL7XKgISUh3IvhH5yAzoAw0KH6 QZKPRKyuClqqpk2HKwlFKv3hYckFkL6OmQ9UqQkvNORpFpJaU4/3TUbRbj5a04g2NV9o1apNtl9 rCP7rBaEasSs7pXDMPsRnAN1PbaqNG81aZrkkGqfieVIZr9lgylZPTCy1GO6yYCGowczAsXn3m4 Fti32/imNzv56gfIOQmvK4ATLpix/bc3k7TtUX8Bz4IBTgWlmqSLz6nZnLHW4mEa08hY2Li8g4T q1zC+4q/Ss07cdLwcoUnht0KeyanJ9QdfLJagVnCSClwdpFYdJaPjT/qu9LzsEyaZg== X-Google-Smtp-Source: AGHT+IGjoVZT2KhQx6/gxqpaGVfcjmGD3TxtHf+gaeBWoPU0zgqTPKr4b5wv8b2GZJFvcegcgg5rMQ== X-Received: by 2002:a17:906:7311:b0:ac2:9841:3085 with SMTP id a640c23a62f3a-acb429e40b9mr331666266b.30.1744866870346; Wed, 16 Apr 2025 22:14:30 -0700 (PDT) Received: from [192.168.2.22] (85-70-151-113.rcd.o2.cz. [85.70.151.113]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb3d32ec83sm228122766b.162.2025.04.16.22.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Apr 2025 22:14:29 -0700 (PDT) Message-ID: <060f3d14-e669-4485-98d1-fb89f8cef79b@gmail.com> Date: Thu, 17 Apr 2025 07:14:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [regression 6.1.y] Regression from 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") with pci-passthrough for both KVM VMs and booting in xen DomU To: Salvatore Bonaccorso , Alex Williamson Cc: David Howells , Christoph Hellwig , David Hildenbrand , Lorenzo Stoakes , Andrew Morton , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , Sasha Levin , Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@lists.linux.dev, "stable@vger.kernel.org Bernd Rinn" , =?UTF-8?B?S2FycmkgSMOkbcOkbMOkaW5lbg==?= , Cameron Davidson , Markus References: <20250416142645.4392a644.alex.williamson@redhat.com> Content-Language: en-US From: Milan Broz Autocrypt: addr=gmazyland@gmail.com; keydata= xsFNBE94p38BEADZRET8y1gVxlfDk44/XwBbFjC7eM6EanyCuivUPMmPwYDo9qRey0JdOGhW hAZeutGGxsKliozmeTL25Z6wWICu2oeY+ZfbgJQYHFeQ01NVwoYy57hhytZw/6IMLFRcIaWS Hd7oNdneQg6mVJcGdA/BOX68uo3RKSHj6Q8GoQ54F/NpCotzVcP1ORpVJ5ptyG0x6OZm5Esn 61pKE979wcHsz7EzcDYl+3MS63gZm+O3D1u80bUMmBUlxyEiC5jo5ksTFheA8m/5CAPQtxzY vgezYlLLS3nkxaq2ERK5DhvMv0NktXSutfWQsOI5WLjG7UWStwAnO2W+CVZLcnZV0K6OKDaF bCj4ovg5HV0FyQZknN2O5QbxesNlNWkMOJAnnX6c/zowO7jq8GCpa3oJl3xxmwFbCZtH4z3f EVw0wAFc2JlnufR4dhaax9fhNoUJ4OSVTi9zqstxhEyywkazakEvAYwOlC5+1FKoc9UIvApA GvgcTJGTOp7MuHptHGwWvGZEaJqcsqoy7rsYPxtDQ7bJuJJblzGIUxWAl8qsUsF8M4ISxBkf fcUYiR0wh1luUhXFo2rRTKT+Ic/nJDE66Ee4Ecn9+BPlNODhlEG1vk62rhiYSnyzy5MAUhUl stDxuEjYK+NGd2aYH0VANZalqlUZFTEdOdA6NYROxkYZVsVtXQARAQABzSBNaWxhbiBCcm96 IDxnbWF6eWxhbmRAZ21haWwuY29tPsLBlQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AWIQQqKRgkP95GZI0GhvnZsFd72T6Y/AUCYaUUZgUJJPhv5wAKCRDZsFd72T6Y/D5N D/438pkYd5NyycQ2Gu8YAjF57Od2GfeiftCDBOMXzh1XxIx7gLosLHvzCZ0SaRYPVF/Nr/X9 sreJVrMkwd1ILNdCQB1rLBhhKzwYFztmOYvdCG9LRrBVJPgtaYqO/0493CzXwQ7FfkEc4OVB uhBs4YwFu+kmhh0NngcP4jaaaIziHw/rQ9vLiAi28p1WeVTzOjtBt8QisTidS2VkZ+/iAgqB 9zz2UPkE1UXBAPU4iEsGCVXGWRz99IULsTNjP4K3p8ZpdZ6ovy7X6EN3lYhbpmXYLzZ3RXst PEojSvqpkSQsjUksR5VBE0GnaY4B8ZlM3Ng2o7vcxbToQOsOkbVGn+59rpBKgiRadRFuT+2D x80VrwWBccaph+VOfll9/4FVv+SBQ1wSPOUHl11TWVpdMFKtQgA5/HHldVqrcEssWJb9/tew 9pqxTDn6RHV/pfzKCspiiLVkI66BF802cpyboLBBSvcDuLHbOBHrpC+IXCZ7mgkCrgMlZMql wFWBjAu8Zlc5tQJPgE9eeQAQrfZRcLgux88PtxhVihA1OsMNoqYapgMzMTubLUMYCCsjrHZe nzw5uTcjig0RHz9ilMJlvVbhwVVLmmmf4p/R37QYaqm1RycLpvkUZUzSz2NCyTcZp9nM6ooR GhpDQWmUdH1Jz9T6E9//KIhI6xt4//P15ZfiIs7BTQRPeKd/ARAA3oR1fJ/D3GvnoInVqydD U9LGnMQaVSwQe+fjBy5/ILwo3pUZSVHdaKeVoa84gLO9g6JLToTo+ooMSBtsCkGHb//oiGTU 7KdLTLiFh6kmL6my11eiK53o1BI1CVwWMJ8jxbMBPet6exUubBzceBFbmqq3lVz4RZ2D1zKV njxB0/KjdbI53anIv7Ko1k+MwaKMTzO/O6vBmI71oGQkKO6WpcyzVjLIip9PEpDUYJRCrhKg hBeMPwe+AntP9Om4N/3AWF6icarGImnFvTYswR2Q+C6AoiAbqI4WmXOuzJLKiImwZrSYnSfQ 7qtdDGXWYr/N1+C+bgI8O6NuAg2cjFHE96xwJVhyaMzyROUZgm4qngaBvBvCQIhKzit61oBe I/drZ/d5JolzlKdZZrcmofmiCQRa+57OM3Fbl8ykFazN1ASyCex2UrftX5oHmhaeeRlGVaTV iEbAvU4PP4RnNKwaWQivsFhqQrfFFhvFV9CRSvsR6qu5eiFI6c8CjB49gBcKKAJ9a8gkyWs8 sg4PYY7L15XdRn8kOf/tg98UCM1vSBV2moEJA0f98/Z48LQXNb7dgvVRtH6owARspsV6nJyD vktsLTyMW5BW9q4NC1rgQC8GQXjrQ+iyQLNwy5ESe2MzGKkHogxKg4Pvi1wZh9Snr+RyB0Rq rIrzbXhyi47+7wcAEQEAAcLBfAQYAQgAJgIbDBYhBCopGCQ/3kZkjQaG+dmwV3vZPpj8BQJh pRSXBQkk+HAYAAoJENmwV3vZPpj8BPMP/iZV+XROOhs/MsKd7ngQeFgETkmt8YVhb2Rg3Vgp AQe9cn6aw9jk3CnB0ecNBdoyyt33t3vGNau6iCwlRfaTdXg9qtIyctuCQSewY2YMk5AS8Mmb XoGvjH1Z/irrVsoSz+N7HFPKIlAy8D/aRwS1CHm9saPQiGoeR/zThciVYncRG/U9J6sV8XH9 OEPnQQR4w/V1bYI9Sk+suGcSFN7pMRMsSslOma429A3bEbZ7Ikt9WTJnUY9XfL5ZqQnjLeRl 8243OTfuHSth26upjZIQ2esccZMYpQg0/MOlHvuFuFu6MFL/gZDNzH8jAcBrNd/6ABKsecYT nBInKH2TONc0kC65oAhrSSBNLudTuPHce/YBCsUCAEMwgJTybdpMQh9NkS68WxQtXxU6neoQ U7kEJGGFsc7/yXiQXuVvJUkK/Xs04X6j0l1f/6KLoNQ9ep/2In596B0BcvvaKv7gdDt1Trgg vlB+GpT+iFRLvhCBe5kAERREfRfmWJq1bHod/ulrp/VLGAaZlOBTgsCzufWF5SOLbZkmV2b5 xy2F/AU3oQUZncCvFMTWpBC+gO/o3kZCyyGCaQdQe4jS/FUJqR1suVwNMzcOJOP/LMQwujE/ Ch7XLM35VICo9qqhih4OvLHUAWzC5dNSipL+rSGHvWBdfXDhbezJIl6sp7/1rJfS8qPs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 493EE40002 X-Stat-Signature: pzwd79qyotceg7ia1nujmjftiwyuiiy6 X-Rspam-User: X-HE-Tag: 1744866872-4665 X-HE-Meta: U2FsdGVkX1+7tDp7FrHrA+ria1DE5IZyTHAgFK0LQNbit9fTJ+vcOF24dB+qgYTn5FK0EYLSjbpkY5D0PNDSRH4KHM1eUlAu437eqqszDGARIwUDSwX4MX3kaSLOlDWpZiq6QwIaSU3ykTScb4zbOtBevsDg9fpTyHsOZ45UnVCz1PQVkzUEMnq1buAMt0Sx1ozNS/j3cWgy60goVISgX4INT5VUvL9Rf9R45cnVa2LfF1GK0lyu4WV8qgvHKHo3ggWwDys5CTWD2ro9CWWiShKjuheRtqR1JHo6ciXup83/BptDc5o5XoHSrZcZSH8G+lZ6H9Un+Yaxl8o69mM1ERiTb+zndOZJVLnjZTBj64c4Wg1riN3hdvxho4wAe/v6lEuZ+AtiXF5RxdAL1l37YBd9L+2xAPP8GbPygy4LiH/ZqcEYTdF+M/lceOwUWCJlsFNYwhLvTtQ4o3rmVQJdOYo+5Nk8nNuS5+CqgTPMNDuLOz2Eq06XUxwKmnX10AUoSI8CPryF2uqFY7rKiYvcbhq/u7eQ21Ze1oRWJt3em69VUamXK2sODxue+ykCOFEp1vs1NXFb2RrO39UFHKaEhocAgbdQkBw6tnhl5VmIDHnp48tGz/ZhDsrP040/IT6uX4l//I8oTeyQXaqAIfr/+Vz6Z3EVK7j9uCkd4pd6XelvGwfwnhuRpQXyDWclZc+MTU/tPtrePImHQahXivpwhi57lIneJsL2PruljX1lHuYVuMd5J8Zhcj3G0wKc/fOsOLUIxgbQplierz2y99iEdqffOT70McGCpQ2VG6ss2WO3NpoPUXpMcp3iVpJMdOG6eJyRJGSPQuVFpv4mTUsD2LpbtflW1KC+v7a/r7jz7E7mjqQIVVPLjBfQi9MUDj6RazpPHJs1M/lVC9eiELH8BrhljmTB2N4Kz4GzzU+vrS3UvhHMh9QFQkFowCktw2dk0Ps8X+NIEq0ohkFB+5D G29seAP4 fO2WPVb5fG5nhJxqcs091N2RIzcZmBKb4AFjr5l1aUrc74/oVneHchLpcrDtON1/YuamRlxQlYwZ4JUzB7hnRKDCZSQkB4gGnY9xlaiIRloWryE5C4ejQmPkThiioxZI8xeepm4kxa17uHrm9jCfwBDR2c0t/2zGqQQ1xHEsBtnkksbB1ZSN+bQi5i6xSB3Bz2bkXMyZ3xBXdnFlcP643VcDnG5WsjwAvy8OtrIwMJ4mEM21SQjhxrK1XSfEmMmCqGPn4p3EEy/SNM3r/Rnh3nURxxKrvWy3BbB0a29gBrKRaE5Go5WSu2W3hKFev8qx3A5avr9mGxpmEJmE/xjyiXVcgrhNVUqvzdu2FNzpObNAA5fY6a+k+0W78+pOC2l7piwaXHWiSUwFpPOtAgv7yYH51/HDJyQX+ih9o1oXiS/kxBecGGVhLnLHXjt3bU60OegHxdLtImgVNUH1OKPTo8QNCWEZmQmI9ia+jOO1c4KsB++EaGcOGWRWN6Q279Yovi/VoFlPQwIvY4ApqSjxi2kVvWxtcfC05IUOVtyE4EiZ8rQXczovgwS8TXur+fGXa7HL+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000050, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/16/25 11:50 PM, Salvatore Bonaccorso wrote: > Hi Alex, > > On Wed, Apr 16, 2025 at 02:26:45PM -0600, Alex Williamson wrote: >> On Tue, 15 Apr 2025 20:59:19 +0200 >> Salvatore Bonaccorso wrote: >> >>> Hi >>> >>> [Apologies if this has been reported already but I have not found an >>> already filled corresponding report] >>> >>> After updating from the 6.1.129 based version to 6.1.133, various >>> users have reported that their VMs do not boot anymore up (both KVM >>> and under Xen) if pci-passthrough is involved. The reports are at: >>> >>> https://bugs.debian.org/1102889 >>> https://bugs.debian.org/1102914 >>> https://bugs.debian.org/1103153 >>> >>> Milan Broz bisected the issues and found that the commit introducing >>> the problems can be tracked down to backport of c8070b787519 ("mm: >>> Don't pin ZERO_PAGE in pin_user_pages()") from 6.5-rc1 which got >>> backported as 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in >>> pin_user_pages()") in 6.1.130. See https://bugs.debian.org/1102914#60 >>> >>> #regzbot introduced: 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 >>> >>> 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 is the first bad commit >>> commit 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 >>> Author: David Howells >>> Date: Fri May 26 22:41:40 2023 +0100 >>> >>> mm: Don't pin ZERO_PAGE in pin_user_pages() >>> >>> [ Upstream commit c8070b78751955e59b42457b974bea4a4fe00187 ] >> >> It's a bad backport, I've debugged and posted the fix for stable here: >> >> https://lore.kernel.org/all/20250416202441.3911142-1-alex.williamson@redhat.com/ > > Thank you, that worked (replying here as well mainly to fix my mistake > in the CC to stable@vger.kernel.org, which got truncated to > table@vger.kernel.org in my initial submission). I can also confirm the fix works, thanks for the quick response! Tested-by: Milan Broz Milan