From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E862AC3600B for ; Tue, 25 Mar 2025 17:19:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58302280007; Tue, 25 Mar 2025 13:19:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53320280005; Tue, 25 Mar 2025 13:19:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36256280007; Tue, 25 Mar 2025 13:19:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 14B1E280005 for ; Tue, 25 Mar 2025 13:19:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A391B1C7CF2 for ; Tue, 25 Mar 2025 17:19:55 +0000 (UTC) X-FDA: 83260735950.08.B0B0B7E Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by imf17.hostedemail.com (Postfix) with ESMTP id 8107640012 for ; Tue, 25 Mar 2025 17:19:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of s.shtylyov@omp.ru designates 90.154.21.10 as permitted sender) smtp.mailfrom=s.shtylyov@omp.ru; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742923192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9YnM88mZ2JIF8yXM71/ypYjpLIULiludgQWXoENexkY=; b=vkZyVXgRZI11tltQqck1kqZtHf+YXSh20rW7Ia4y5SVM/UzwkB6InlKBDCacmykVi1wd8Q Vyyky0ErSZ0j6olhY5Fd8d0jE7s50xWrfiv7wN3YxQv6e8p0d/VO/W2bt+buWkmg+um0vK WmX7/TJhZ5u5x7faMKNJnMmMdxzKEME= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of s.shtylyov@omp.ru designates 90.154.21.10 as permitted sender) smtp.mailfrom=s.shtylyov@omp.ru; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742923192; a=rsa-sha256; cv=none; b=ILs4cPJ3LKEn969Eq0+IUfifEAy0zkYQO1F2rF9irATCnC4hBUhCxd9j8G+qrc2IqqvuTN XWEq9JnkYuGck1B9a+sGH5T7PmircxUOiSVys8A/LTBymV7QncOWoBzWUnYeFfp7FTZ38n owxdt0MzHwFx6pft4HGa16r7CnkXP5Y= Received: from [192.168.2.102] (213.87.136.199) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Tue, 25 Mar 2025 20:19:41 +0300 Message-ID: <05fec753-cdaa-45a5-a029-b6435c30eb07@omp.ru> Date: Tue, 25 Mar 2025 20:19:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH V3 25/43] rv64ilp32_abi: exec: Adapt 64lp64 env and argv To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , References: <20250325121624.523258-1-guoren@kernel.org> <20250325121624.523258-26-guoren@kernel.org> Content-Language: en-US From: Sergey Shtylyov Organization: Open Mobile Platform In-Reply-To: <20250325121624.523258-26-guoren@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [213.87.136.199] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.1, Database issued on: 03/25/2025 16:50:54 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 192097 [Mar 25 2025] X-KSE-AntiSpam-Info: Version: 6.1.1.11 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 51 0.3.51 68896fb0083a027476849bf400a331a2d5d94398 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: omp.ru:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: {Tracking_ip_hunter} X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: ApMailHostAddress: 213.87.136.199 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 03/25/2025 16:52:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 3/25/2025 3:18:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-Rspamd-Queue-Id: 8107640012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 39gokx76da469yr16oj6xkcc5ie36yok X-HE-Tag: 1742923190-229747 X-HE-Meta: U2FsdGVkX19QTH9Rw0o6JmQCWjmp9BpjUsfUq7g6/ZSML75gjp/Ei/aPRJplO3FP6Wg+IOY5NlTlCnflNUoj/E8fEQInW4L1j7bHQMMm4D5Qe5xaYGHogJrCgqqw7lV2y2+hK7JA3BpalzcKIM4VlYDg6QVzZzGaK6tJeMeDOr4rur1itL8CNeeA7dTCZyR2RFirLFqzEyigLZvTEUL1D2KBwQZFbj/UaRucl4n/9ehqS0Wr2zQ+RkhoG4Dn8WCzlP6mOpjjqteS47nQg4K5CKR/hmggKGVraWiP/3+X7glU9958o7l2TBohtfj7roRWIHZjHhO9yRO5yBquBT+smVbrf07oTidgehXXppjoG1G4zCbaeHznfXMv1cDWkhWt1m0QPlkhTMyXBxpIKYxALL4Q+e21M3BCX0B53X+gK3qf7M/2MOybxps63gVqSwSvBQteXFvIwGWonDR4VeTa+LK8IfXsa7o8Jxc64H0oAdQllSKfjFzuHOfjE8darJQV6LYOQmGVR3yYiSCO9dR90t5TYV6hdx0ypXUvabEMCrZ2OO1i9omYCritnalUbJffaDXCUOZj29OXEuUYz8euEZGXfjOHxRvhIoR27wZbMsOrOzDKbAtRKPXP73Us7xa2MEON/ZZSbgKzOVoql3nJUiiKGPnGUDjHE5TbSpGUHl18nl3zEQ9cCJzMZL8gA4RHdbw5kzo9k3pJYkczS18qS3i5SHJGwSi4IndStE/3As05GvyqKstDtRmKLPwaFxMWf4UHpOasoD4LqT/kgW6lYiYp2soMnKpmOM9oHarBF9u5LOr3l4UsWqXPiA8qoXnY2/pltT9NWUuxaSJrgKrRXKt0kQ/FR3GptHgGTOqN0JOqKt63nv5F07I9itsk/CR/pZhqLARZ79Sk6xsmeTFmtKbneRHkYOPLidtylcCpFvDptR92DdrorHN3hu9Z2D+9IqwI2qveqlh+xA3QwT7 5Gcy9Dzm 1eS7uvpuWTz00bu6C0Vx8Uj6WeZM3vPjyOz0phUgNEiEMj2u0NEvhLwddQ6KDybzzlxa166cf/wTY257NBMb0TAWR8lVkfXYt/xVygh27EntAc6u+VmxpkbQbtNjs6RiP9803aGAcHM/Bo1qNiTSV/ElOwiNOq3ugjDcdiLK0ghAeAVOia+U9U35s/QaH+H7APNBEe/j0cmNAI282mw2xA1bZIHJk6kU7fKUzycR65ztB/ahvE5dis+5KHqsWQvoToutLkrNOXbmOf/FI8ghMuX27Kdu+pWe0ZjAK6MEK1Ur1eKPTeC99vjHEzh+CxvFVe2HiMbuvc3L2N24nf6g24DbFyjn9Cimt4TmjAoqatydyCqSVOeRwt+mHbv4zFD8xpHUZ1Cvf6nx+61nTsUXl6nOBkT+dktzprR25x/t6Yz3iW6BK6OuMk+bg5ZbzpGs4mDPqGkjMqqAElsYZ6LAQGqAxkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/25/25 3:16 PM, guoren@kernel.org wrote: > From: "Guo Ren (Alibaba DAMO Academy)" > > The rv64ilp32 abi reuses the env and argv memory layout of the > lp64 abi, so leave the space to fit the lp64 struct layout. > > Signed-off-by: Guo Ren (Alibaba DAMO Academy) > --- > fs/exec.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/exec.c b/fs/exec.c > index 506cd411f4ac..548d18b7ae92 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -424,6 +424,10 @@ static const char __user *get_user_arg_ptr(struct user_arg_ptr argv, int nr) > } > #endif > > +#if defined(CONFIG_64BIT) && (BITS_PER_LONG == 32) Parens don't seem necessary... > + nr = nr * 2; Why not nr *= 2? [...] MBR, Sergey