From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA1EC47258 for ; Tue, 23 Jan 2024 08:45:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85B388D0009; Tue, 23 Jan 2024 03:45:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E47C8D0007; Tue, 23 Jan 2024 03:45:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65D7C8D0009; Tue, 23 Jan 2024 03:45:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4EF8F8D0007 for ; Tue, 23 Jan 2024 03:45:21 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E78BE80185 for ; Tue, 23 Jan 2024 08:45:20 +0000 (UTC) X-FDA: 81709941600.17.354C452 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id 5B390140004 for ; Tue, 23 Jan 2024 08:45:18 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MVzD4C0V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HcTryCcg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MVzD4C0V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HcTryCcg; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705999518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZHBcb6f4SclqAqxvFO8Za6hGfvKmv8CRvtm5QGIZCC4=; b=NJGhu7Q/gFw7mggdymRa40yzyfmVwdycjqKMi7J07PX/J7bjjsxY0WEKW6Nm9nIDRrnSg0 CbqU08x/TBPtVjtiHzZ7m7jZYso74JquBRk5TRvNX8Uk+w9NRypIh26RBkKzKsfPvX2abd /BSAZaQTrmrgLhzgYNx2KmhIf6nrtJw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MVzD4C0V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HcTryCcg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MVzD4C0V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HcTryCcg; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705999518; a=rsa-sha256; cv=none; b=jOu7Ee2ZIyKYz1xPeIacLflaZ0UWgrrbkLQIpz2qABhS7ce92t4d/PCmk0jO+ljOx52qn/ 4qx9fhFaYtWP9axWgU945+y3lgI7/f//2PYFlX0VEp3Rm4kIPgs2UCOl70lbRj5wHV9py7 3WwTJVVu1sWusR77z+PtGQC9FU8Bn3c= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3C3CB1FD41; Tue, 23 Jan 2024 08:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1705999516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZHBcb6f4SclqAqxvFO8Za6hGfvKmv8CRvtm5QGIZCC4=; b=MVzD4C0VOQV5Y2z3YlnI6s6F0+kWQMoAnwiyh+OH2iZupQB849KPMoRD+OtLaYeZPkmvZZ jzVqHmgYAI/OGuWYojDOCmSqu5gnqDOEFSpMDer95u7KPn0gHIFtzqVBCqhOm+vdAT52t1 3xCmyPcBXCXV9lzXBkdP7nK/jWwSrA0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1705999516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZHBcb6f4SclqAqxvFO8Za6hGfvKmv8CRvtm5QGIZCC4=; b=HcTryCcgA69cC1p6bigLmEvjz9bnmEW0gnHte1rHh6jVC7d4RglyRrQBSTtjdvXiVY2Frm 6U3WNp16ua03HaBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1705999516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZHBcb6f4SclqAqxvFO8Za6hGfvKmv8CRvtm5QGIZCC4=; b=MVzD4C0VOQV5Y2z3YlnI6s6F0+kWQMoAnwiyh+OH2iZupQB849KPMoRD+OtLaYeZPkmvZZ jzVqHmgYAI/OGuWYojDOCmSqu5gnqDOEFSpMDer95u7KPn0gHIFtzqVBCqhOm+vdAT52t1 3xCmyPcBXCXV9lzXBkdP7nK/jWwSrA0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1705999516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZHBcb6f4SclqAqxvFO8Za6hGfvKmv8CRvtm5QGIZCC4=; b=HcTryCcgA69cC1p6bigLmEvjz9bnmEW0gnHte1rHh6jVC7d4RglyRrQBSTtjdvXiVY2Frm 6U3WNp16ua03HaBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2481913786; Tue, 23 Jan 2024 08:45:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ewSBCJx8r2WcdgAAD6G6ig (envelope-from ); Tue, 23 Jan 2024 08:45:16 +0000 Message-ID: <05e23c85-1bae-48a5-b1d1-cb61e0b1efdf@suse.cz> Date: Tue, 23 Jan 2024 09:45:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm/slub: remove full list manipulation for non-debug slab Content-Language: en-US To: Chengming Zhou , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joonsoo Kim , Christoph Lameter , Pekka Enberg , Andrew Morton , Roman Gushchin , David Rientjes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240117-slab-misc-v1-0-fd1c49ccbe70@bytedance.com> <20240117-slab-misc-v1-2-fd1c49ccbe70@bytedance.com> From: Vlastimil Babka In-Reply-To: <20240117-slab-misc-v1-2-fd1c49ccbe70@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5B390140004 X-Stat-Signature: c7hrihjge686qmsysqhhj67pkch5smma X-Rspam-User: X-HE-Tag: 1705999518-488065 X-HE-Meta: U2FsdGVkX1+vBF11hVRHSY+H/xzESv96r6QnqnAZjNnW3jFRIKvbyQvKwEIy1HkHX3CefmxsSZrAr3ezIn1AiPjxJ6gstirY0gRUHZOtvmVj+Tl+Ns4vjDjD2UIu8npPInEPYkNgQenv02dti+yxfXOnie7luYmOMJPjNjO+szHvA4M/ynHJI9Hy5ft/82Gej1J629Np8QtFW+Z3RXHGoVnpIaobS8SdVJ+B5NN3N5aV9taHRQpqR+fTozR9W0GrYhApb2MlsxCFcoNU2HbI+CChXAtcvS2uJx6/cnaVUsuYdVrC/qF/uCs1lrTKKC8qXVsEJBMD9Eatp9G/gROxvT6t4mYIZ6A3sQDXOx66pk34O9+Y5LCvfK9N/8e6MzX8ave/1pX8Ivp3uoBW5UDwIKl9AGKsmRSVSwIR25ZHF2dT0FXr8WJ0FHrQtnlkAhZ63Wg4oF5Q7d/chMKoJDFBFjsjmprsAq/MzU18Q+xjeOUQS6rLOlQRTHxijLI8e5Qsuc4IruElhE7IsNXV34Z7iDwmQLG2Zlxu5BBJK/NyM4W1RSQNljKlsu3GUZClhmoRFPZACYMYdPil6KexdbH+qVtZm50492idadTZcUToGxz8v/0xVOp/pCrC2Q/BybAFD0J88onzTLjnyJKL6SS8wVbEO3zzBlbd5WWSyeH95qd6bVb49FDIb4pyXir4RMcxkBMIawJMMfZ5I+EKcYgKUxyCc5ueZZ4lrElw19K/MRRjBHuNweBFGVblTEtd135hP4mOrPJ4+cqw8vjeXjJIW11qtBjasm95PHNomQ8R5oYiK7FTKzvgE49K54bysQSJIvlMAh4ibxcJs5tllcMupDeMWM1tDAFWfd/Aypmz5hTRxd1FP7X+zW++Pz8hIhrNuJZmUxtFwNVJx2npj7COKhDt7Rn7PXee9WazGlLXB+ILCKfieBlylN5DtgjyFu5cycyRWKd58ymk5PJ2FH5 4eaIgdHp AwchpAkBDmfEKR6A0sJikKVPhB3XMzoHV0lFDXl8c27vKMndR+jJoDZMPlS/I3D9q80+gsdC97fCJYalgI0hbv5TNTDYVKEQMA1svyFYUxFlCJ56ACMBaYic2ARYM1f1GQP5Lv862M+EvD3eZrw4yrXiQP8qxuoaxzHlLbm8bA9FzIxPcYW9XwKZ9ljIhFFMG/eWLudXCO6ZGfWmmM9GVmtbt7QZEA2VBJYanoQQ6HL4cDvkM7PFX93GxzMlIJI9BkSPvSjcXm0o7w5PAYPiEDbPFCTSdM0PkMPcvdnf9e6i7ZsSVM6qH8rmCufZjECSc21fKV8rgkZyyr2iRQTf/WgWGa7lHlLqNVnJ2aUKoNT1HUe+BSw7Ism/1++QSWcOqzESdI394yIoTzCA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/17/24 12:45, Chengming Zhou wrote: > Since debug slab is processed by free_to_partial_list(), and only debug > slab which has SLAB_STORE_USER flag would care about the full list, we > can remove these unrelated full list manipulations from __slab_free(). Well spotted. > Signed-off-by: Chengming Zhou Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 20c03555c97b..f0307e8b4cd2 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4187,7 +4187,6 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, > * then add it. > */ > if (!kmem_cache_has_cpu_partial(s) && unlikely(!prior)) { > - remove_full(s, n, slab); > add_partial(n, slab, DEACTIVATE_TO_TAIL); > stat(s, FREE_ADD_PARTIAL); > } > @@ -4201,9 +4200,6 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, > */ > remove_partial(n, slab); > stat(s, FREE_REMOVE_PARTIAL); > - } else { > - /* Slab must be on the full list */ > - remove_full(s, n, slab); > } > > spin_unlock_irqrestore(&n->list_lock, flags); >