From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D63ECAAD2 for ; Mon, 29 Aug 2022 18:47:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB3AD940008; Mon, 29 Aug 2022 14:47:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E62BC940007; Mon, 29 Aug 2022 14:47:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D031E940008; Mon, 29 Aug 2022 14:47:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BD9D5940007 for ; Mon, 29 Aug 2022 14:47:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 921CAA0A99 for ; Mon, 29 Aug 2022 18:47:10 +0000 (UTC) X-FDA: 79853512620.01.78316A4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id AE8E71C004D for ; Mon, 29 Aug 2022 18:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661798828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3SRr/ruP6S24ttwv/V3z+xdM2OxhFCLUfvkhaDf3xjo=; b=O5iXs1ShuNaqwRtFpXf58vH4KjMTNAshq9FWDLWK4JEHpjAPc5oBw3frRu/alcGPEtPbUw kR4cmK8sCsxVpEV8I3fiKNTpbpvQpUT+VOfleMlQ2FQCQHBre8AUJrZ0Xn+yAQPCMv1xrO 1UqotGLffltu6C/zx1VW3hJ5/wU1/Ns= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-V5V5MiYtPn6SchxYTIkH3Q-1; Mon, 29 Aug 2022 14:47:05 -0400 X-MC-Unique: V5V5MiYtPn6SchxYTIkH3Q-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B7FF838005CB; Mon, 29 Aug 2022 18:47:04 +0000 (UTC) Received: from [10.18.17.215] (dhcp-17-215.bos.redhat.com [10.18.17.215]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F0F1401473; Mon, 29 Aug 2022 18:47:04 +0000 (UTC) Message-ID: <05c68678-5bb3-a7fd-863d-d3e0cf11e914@redhat.com> Date: Mon, 29 Aug 2022 14:47:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] mm/slab_common: Deleting kobject in kmem_cache_destroy() without holding slab_mutex/cpu_hotplug_lock Content-Language: en-US To: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220812183033.346425-1-longman@redhat.com> <093f6a32-40f8-78ea-0070-600cfe08a3dd@suse.cz> From: Waiman Long In-Reply-To: <093f6a32-40f8-78ea-0070-600cfe08a3dd@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O5iXs1Sh; spf=pass (imf20.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661798830; a=rsa-sha256; cv=none; b=NdHrxjDOdrK1P7p1iLLTCDQkpxwdgkSmMB8iAG9p04JAawaRlxBHbSwZ9+ypl2cVD37FQI bPnkbPlTohKU46Ho8p8dYZWMchOj/lNqQv7OqBd28/RLwQwR8ho0tsAYvEv9yUNphrUuey /9Fk180wHZgMXN0HVyfUaKO28MlK6Mw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661798830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3SRr/ruP6S24ttwv/V3z+xdM2OxhFCLUfvkhaDf3xjo=; b=nRvhcx+FLjvLfR3jyk4MfHRDT0zOqLKHqo8A+/IsPmr5FwddgK2cDDQwFWS2I75pAUeoz+ s/PWmEHKHG1/+25mExxsD+XI8vM/YsgFBDd40Pg6mfFlIAA7/ztu5+ES1AuHIgoasSu0pb YSOHBlcgU5QN+iiAge+bFmiUX+RWXew= X-Stat-Signature: hcg1kukfz1nto3ro7z5abgrj1m43hnp1 X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O5iXs1Sh; spf=pass (imf20.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AE8E71C004D X-HE-Tag: 1661798829-763233 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/23/22 07:33, Vlastimil Babka wrote: > On 8/12/22 20:30, Waiman Long wrote: >> A circular locking problem is reported by lockdep due to the following >> circular locking dependency. >> >> +--> cpu_hotplug_lock --> slab_mutex --> kn->active --+ >> | | >> +-----------------------------------------------------+ >> >> The forward cpu_hotplug_lock ==> slab_mutex ==> kn->active dependency >> happens in >> >> kmem_cache_destroy(): cpus_read_lock(); mutex_lock(&slab_mutex); >> ==> sysfs_slab_unlink() >> ==> kobject_del() >> ==> kernfs_remove() >> ==> __kernfs_remove() >> ==> kernfs_drain(): rwsem_acquire(&kn->dep_map, ...); >> >> The backward kn->active ==> cpu_hotplug_lock dependency happens in >> >> kernfs_fop_write_iter(): kernfs_get_active(); >> ==> slab_attr_store() >> ==> cpu_partial_store() >> ==> flush_all(): cpus_read_lock() >> >> One way to break this circular locking chain is to avoid holding >> cpu_hotplug_lock and slab_mutex while deleting the kobject in >> sysfs_slab_unlink() which should be equivalent to doing a write_lock >> and write_unlock pair of the kn->active virtual lock. >> >> Since the kobject structures are not protected by slab_mutex or the >> cpu_hotplug_lock, we can certainly release those locks before doing >> the delete operation. >> >> Move sysfs_slab_unlink() and sysfs_slab_release() to the newly >> created kmem_cache_release() and call it outside the slab_mutex & >> cpu_hotplug_lock critical sections. There will be a slight delay >> in the deletion of sysfs files if kmem_cache_release() is called >> indirectly from a work function. >> >> Signed-off-by: Waiman Long > Thanks, added to slab.git for-6.0/fixes Thanks for taking it. Cheers, Longman