From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EDAFECE564 for ; Tue, 10 Sep 2024 09:16:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33E798D003B; Tue, 10 Sep 2024 05:16:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C7AF8D0002; Tue, 10 Sep 2024 05:16:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 168F48D003B; Tue, 10 Sep 2024 05:16:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E5C528D0002 for ; Tue, 10 Sep 2024 05:16:01 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 674721A01FE for ; Tue, 10 Sep 2024 09:16:01 +0000 (UTC) X-FDA: 82548271722.25.21F38AE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id A3478C0002 for ; Tue, 10 Sep 2024 09:15:59 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725959623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fU/2XunVTrVC2tW1WIPr1d0WYGPH3wQHGnoAgkEoxjM=; b=F1hFBvg5PQHKMfczSxVf9XeAik6mQRYOe1mwQaj3lrAQcNqXGUzOr8LmCNCZliwAsa1OM8 /UiUbbZksYSVraWiX3EzrlMS/VFk1wfoGPi4R08ggzMgVr6lkni8uDqfE/+MVBa/KAcLgy RbnERKWTmJDewCcLmO3FPWgKO38tqg8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725959623; a=rsa-sha256; cv=none; b=3DQ/5fz7dAJwiTv/UeumQrLyeZUvv2u5R21CFcjdXAEqaO7t8+NIzl/WEEIz3oF6E1CA4q woWpjM4PL56thhJJmu4q+A1R1mhawNJCnh97a9Qky7Z8piB5+O+qfGMpwZFDupPvSzOOUl 3sbEAwKghNKkBXD4SjQ1lebAg5EjKEk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D444B113E; Tue, 10 Sep 2024 02:16:27 -0700 (PDT) Received: from [10.163.63.106] (unknown [10.163.63.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EE67D3F66E; Tue, 10 Sep 2024 02:15:56 -0700 (PDT) Message-ID: <05c53d3b-87d7-4a25-89cb-ae349c901244@arm.com> Date: Tue, 10 Sep 2024 14:45:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Drop unused set_pte_safe() To: Ryan Roberts , linux-mm@kvack.org Cc: Andrew Morton , David Hildenbrand , "Mike Rapoport (IBM)" , linux-kernel@vger.kernel.org References: <20240910090409.374424-1-anshuman.khandual@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A3478C0002 X-Stat-Signature: to4xaiyurtgrpobn6cm13j49i1h4ugso X-Rspam-User: X-HE-Tag: 1725959759-743263 X-HE-Meta: U2FsdGVkX19w5EXrknEB74PGzKGNnm5/orVWt1XLdboJk1HheYeS2O0ff0K+zt4ftbi2ixw3THw2wVnHyVZvwkDiGKQMOTbMHnXhcSSltYHrJSDAmn9dAfRNovqfU2ejANw4iK/VX8iYl66xg3Qsn8nOAo5vqCtsfKAQ6MTjNqCEjT7cXonuYGAI5EXalpBuVx/KNPm7x8poLF+CyG2XYrwUpSEsZ2E/hQMqH0duJozn2Tf1BfY+6OokYHbTNhOSu1iuVdglQeN/UajNC2HJWiodr4q6clp4taL+MEE0jbCG0vWZtJnssEx7mu8Lfd6JwLOBERR7s+2leaaObQ7aoPqmAsDthzkxBhLZFNBQjwEye2gjpziY/KTuG7fZ/BCkc2CNFOCtmRB0Mp5diWQSpXQvOVhV5IOwBS0AFlV/m+T2SPJfPv0MvQF2zrmTLWDn/IC+H8W3e+xc20bS0qMKmWzoaVxDoxDhmR3pYM1t8mopjIxCpNQw9u0QbOK3EcpLPSSZIO1Kw9Q0sP45gIoMToBluvZe48aliy0Ip5lDUNvbhyvBcGaAo8ZTZlLywOCa/EBVAGyZrvYBOEu2M7sPDQclUOqpv+avs/2dJnkdfLIwTOqcNbBMGoXRq1l4QwQc1yJIciUjSygCbPuGTL8z83uhy1Fu4GYDHs1/sHcD8fqnb42KN8El2PSuxtqhA5BjEkFV5Zq44ajHJLglvbk5580CQkMxV+KwaaFzbuW1WgW77Xy5XnWaf6hbdVoC5yP5rKS2KyoB4DW4k0zOGdLP+wNgowoFbP4A2SH4QlKWzOPcDRRihyC8Z1/CMvMln75zdHtYKm12GIkihlhOMLZ0Ye/jEm2LvQeSZJzzi6zIha8w5mNEQJ/5Iur0AN3PD7e0x4hmWws9YMDfieCULeOHY+PZlOjwqHJnhoECRDPyGrrXyccjpXxmOsfXrKQM6cSRDOYlLjDgkzI7rsLp5um 55/URitY WJxB9dE3PM6e+lYz6fAo2phgS6n/ZRo7mvYtSGfvUIF/mvFDwcif2gOZ3lNgFd+cfdKAl56DhvSKQi8cZN5ZY8oxEY35+oLv78qKlq+5m3I79OKmXJdIOYiJnxyLEfYLGj9qqn8LcsSuXL8Na2LFGpg+MH0lTNb7pEKmNlhs218STzsM5rFpCnCOtsNWiSUrhvad9rOCPJrMW4egHr6GuiB741DXSTgA0XcCNMSRq7vpUXa+A41TdJikhuRWepOrUly9ZmAK0scxshXNfWK79Z81bBFWh+6d8UylTTVrfRT91axfA7gDmIG1BLL+25Ss6PXMZYQ88f9Pj6lIGOz3ai2/KTRQW+tXoD1d8TCaZ5r9KNfHhKzqoHLxJwBVH1hG+xMut1GU5J+0yXupUXSE3wlLaSDuwsiAv6Vp8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/10/24 14:38, Ryan Roberts wrote: > On 10/09/2024 10:04, Anshuman Khandual wrote: >> All set_pte_safe() usage have been dropped after the commit eccd906484d1 >> ("x86/mm: Do not use set_{pud, pmd}_safe() when splitting a large page") >> This just drops now unused helper set_pte_safe(). > > It would be good to add some comment here to mention that the macro was buggy > due to doing direct dereferencing of the pte, and that if it were to be kept, it > should have been updated to use a single call to ptep_get(). Makes sense, will update as suggested. > > With that: > > Reviewed-by: Ryan Roberts > > Thanks, > Ryan > >> >> Cc: Andrew Morton >> Cc: David Hildenbrand >> Cc: Ryan Roberts >> Cc: "Mike Rapoport (IBM)" >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual >> --- >> include/linux/pgtable.h | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h >> index 2a6a3cccfc36..aeabbf0db7c8 100644 >> --- a/include/linux/pgtable.h >> +++ b/include/linux/pgtable.h >> @@ -1058,12 +1058,6 @@ static inline int pgd_same(pgd_t pgd_a, pgd_t pgd_b) >> * same value. Otherwise, use the typical "set" helpers and flush the >> * TLB. >> */ >> -#define set_pte_safe(ptep, pte) \ >> -({ \ >> - WARN_ON_ONCE(pte_present(*ptep) && !pte_same(*ptep, pte)); \ >> - set_pte(ptep, pte); \ >> -}) >> - >> #define set_pmd_safe(pmdp, pmd) \ >> ({ \ >> WARN_ON_ONCE(pmd_present(*pmdp) && !pmd_same(*pmdp, pmd)); \ > >