From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>
Cc: Roman Gushchin <guroan@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>, Roman Gushchin <guro@fb.com>,
Christoph Hellwig <hch@lst.de>,
Joel Fernandes <joelaf@google.com>
Subject: Re: [PATCH v4 1/2] mm: refactor __vunmap() to avoid duplicated call to find_vm_area()
Date: Thu, 18 Apr 2019 16:17:59 -0700 [thread overview]
Message-ID: <05c40b0b-3621-6c07-346b-478679949d92@gmail.com> (raw)
In-Reply-To: <20190418152431.c583ef892a8028c662db3e6a@linux-foundation.org>
On 04/18/2019 03:24 PM, Andrew Morton wrote:
> afaict, vfree() will only do a mutex_trylock() in
> try_purge_vmap_area_lazy(). So does vfree actually sleep in any
> situation? Whether or not local interrupts are enabled?
We would be in a big trouble if vfree() could potentially sleep...
Random example : __free_fdtable() called from rcu callback.
next prev parent reply other threads:[~2019-04-18 23:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 19:40 [PATCH v4 0/2] vmalloc enhancements Roman Gushchin
2019-04-17 19:40 ` [PATCH v4 1/2] mm: refactor __vunmap() to avoid duplicated call to find_vm_area() Roman Gushchin
2019-04-17 21:58 ` Andrew Morton
2019-04-17 23:02 ` Roman Gushchin
2019-04-18 11:18 ` Matthew Wilcox
2019-04-18 22:24 ` Andrew Morton
2019-04-18 23:17 ` Eric Dumazet [this message]
2019-04-19 19:08 ` Al Viro
2019-04-17 19:40 ` [PATCH v4 2/2] mm: show number of vmalloc pages in /proc/meminfo Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c40b0b-3621-6c07-346b-478679949d92@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=guroan@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=joelaf@google.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox