From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FAD3C433F5 for ; Fri, 8 Apr 2022 08:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D16F8D0002; Fri, 8 Apr 2022 04:52:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 080D46B0075; Fri, 8 Apr 2022 04:52:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8B658D0002; Fri, 8 Apr 2022 04:52:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id DB04F6B0074 for ; Fri, 8 Apr 2022 04:52:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A8D3F256E8 for ; Fri, 8 Apr 2022 08:52:48 +0000 (UTC) X-FDA: 79333096416.08.E5B2B6B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 245AB16000C for ; Fri, 8 Apr 2022 08:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649407967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xCLh2noLYHvoYJ5n2RIW5aWBr/p7U0RqG8wHzDGzBW4=; b=EdGaSpR13V/XnI3kDUVZ67+/kDVapEJmyBPHPk4Klzd0mF2MF3OMgoQJyfqc+NRyHg0MJB 7Ps3zdhhrBHr52iPLKVO3nlwnQU/UEDdfJ4tHeT5f+Gii1zjQ/K67JGQ5T5DCV0uyoYElz Ez+sJ9qe+EC+VJNzNIMPsot5KD+0390= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-Q1SW8Z_5NBa4ItHXJwxDDA-1; Fri, 08 Apr 2022 04:52:46 -0400 X-MC-Unique: Q1SW8Z_5NBa4ItHXJwxDDA-1 Received: by mail-wm1-f69.google.com with SMTP id n21-20020a05600c4f9500b0038e3b0aa367so3891387wmq.1 for ; Fri, 08 Apr 2022 01:52:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=xCLh2noLYHvoYJ5n2RIW5aWBr/p7U0RqG8wHzDGzBW4=; b=e861hQABWzQb0ISLaENyCjAi9oM68N/19S5rvIqH2M8rViG1vmrkaMTEzcPxQagbgy 16LPbgZ9yF+0mbAP7s0/FA+3bpORY/92fz06X+6f/GwvO+QFhpQ7syLm/lXY4htPWduI 4MDjQjKe0lfB6f/O0UXrNgbA9xI/LLTZgPsX9tNlZl1YmIbsiYG93IGSwVYP2zVU38Nv soYH8+c0yMbRf9K3hHBPW/g03lLyjfo0GlwyEcr6s53qBzmjyjuTQQB8rao/Ll/yNiLM grM1YGhSQCQzq9woS9fpVstxjaNZeXL/QgZVzMOadt0rJHLCUzM7a4cOhH0d4llwSHUG JmhA== X-Gm-Message-State: AOAM5317nye8AdG+YIROBaGkzjVWFw/xmMvjcBdVqT65RyZAtmuoo/WU AnQwFHk2uFR3PLVy3OKkisZeb9IWpVq5sae9AmcoJqtTauDbg0J0NM5Kqe7CBnqPO+BQwGDjBoh jPRYk78cCVZg= X-Received: by 2002:adf:fdd0:0:b0:206:15b0:4478 with SMTP id i16-20020adffdd0000000b0020615b04478mr13626441wrs.266.1649407965376; Fri, 08 Apr 2022 01:52:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRqLFg7VzPUGFyZuzQrHaarDUcRgbWlUwak6IE3xfZBRbBHIjt56yN5nEb4kTyWJCpQKJlwg== X-Received: by 2002:adf:fdd0:0:b0:206:15b0:4478 with SMTP id i16-20020adffdd0000000b0020615b04478mr13626428wrs.266.1649407965097; Fri, 08 Apr 2022 01:52:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:fd00:612:f12b:a4a2:26b0? (p200300cbc704fd000612f12ba4a226b0.dip0.t-ipconnect.de. [2003:cb:c704:fd00:612:f12b:a4a2:26b0]) by smtp.gmail.com with ESMTPSA id y15-20020a056000168f00b002057a9f9f5csm23224387wrd.31.2022.04.08.01.52.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 01:52:44 -0700 (PDT) Message-ID: <05ba9f7c-f124-2696-2673-3d7e6763c8c1@redhat.com> Date: Fri, 8 Apr 2022 10:52:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 2/3] mm/memory-failure.c: minor cleanup for HWPoisonHandlable To: Miaohe Lin , akpm@linux-foundation.org, naoya.horiguchi@nec.com Cc: shy828301@gmail.com, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220407130352.15618-1-linmiaohe@huawei.com> <20220407130352.15618-3-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220407130352.15618-3-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: rd3n1wahoiirezh7b3th5oqxmfan61bd Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EdGaSpR1; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf08.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 245AB16000C X-HE-Tag: 1649407967-5423 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.04.22 15:03, Miaohe Lin wrote: > The local variable movable can be removed by returning true directly. Also > fix typo 'mirgate'. No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/memory-failure.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 2e97302d62e4..bd563f47630c 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1180,13 +1180,11 @@ void ClearPageHWPoisonTakenOff(struct page *page) > */ > static inline bool HWPoisonHandlable(struct page *page, unsigned long flags) > { > - bool movable = false; > - > - /* Soft offline could mirgate non-LRU movable pages */ > + /* Soft offline could migrate non-LRU movable pages */ > if ((flags & MF_SOFT_OFFLINE) && __PageMovable(page)) > - movable = true; > + return true; > > - return movable || PageLRU(page) || is_free_buddy_page(page); > + return PageLRU(page) || is_free_buddy_page(page); > } > > static int __get_hwpoison_page(struct page *page, unsigned long flags) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb