From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5BCC36008 for ; Wed, 26 Mar 2025 06:49:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF37528005E; Wed, 26 Mar 2025 02:49:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA39F280056; Wed, 26 Mar 2025 02:49:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D43F628005E; Wed, 26 Mar 2025 02:49:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B2ED2280056 for ; Wed, 26 Mar 2025 02:49:22 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 36BB21CA257 for ; Wed, 26 Mar 2025 06:49:24 +0000 (UTC) X-FDA: 83262775848.12.04B7D28 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf23.hostedemail.com (Postfix) with ESMTP id 41249140008 for ; Wed, 26 Mar 2025 06:49:22 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ibo9fRkF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of purvayeshi550@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=purvayeshi550@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742971762; a=rsa-sha256; cv=none; b=YQ3q0miHGW8v0iAoTkWdXTWYIoeWrqXic3/NLJHMJ97GT23eGIjsBDMTRF93c5T7dhsSl4 NED1Pdn6ziHRVaQC4Q15OQ28EpiSKBY6ZdolQL2URreqkBveFpIC62yjbAiCr/TF1HE0o6 66GdnzIjyRboMZPHySXCF6f829tq5Z8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ibo9fRkF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of purvayeshi550@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=purvayeshi550@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742971762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fh7lxlRUUOBOSUbl27AL3W8RZwHT1ywyp8vFcMuzW20=; b=jadX7PKeq1tM3JDtOPf6e5lgVIKQFbQR0rFSU/IiTL/M6oUmR/L6okGm3e99+YlreULY/n EOW/RlGgPu6zkM+6jNIP01TeeWm86mqp1kdUmVg9hxWIMFJT9XOXMmKT4/e7cH7TMBUhgq YDqMlYt5yH+2lSwO5LAKEijLIK2xVac= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-224019ad9edso11139885ad.1 for ; Tue, 25 Mar 2025 23:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742971761; x=1743576561; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fh7lxlRUUOBOSUbl27AL3W8RZwHT1ywyp8vFcMuzW20=; b=ibo9fRkFUiz9KyPZCgFT+cllwGkzbe43XtyKMiSy6ocAA9g5abTC9e+9Tl0DvaAKML 1xZbdh0xlBJo6goUAPogTJcFnWIZG5VEp1o26fZbEF8QSb1l5LP+SzKOBG1GYzuOHR17 aq/q7gyalZLWf70yYhmlzQgC8i1/a9ND9oTJuQhriOcANq/BMq8awdUOQvbQXs7nV2we DyGe5jFdsnYF6SfPaPlTlDgx3QgqiTN76qQgoGsqgOTxkIj0ow8NvDcAtwhG5URF2xli xJ1scXeXpy/rsA2xG9/znT8jRr4RskEyPXGCUtmdZijqR4dG3Mv2ZEaAL7c+j1IVzmtq a/xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742971761; x=1743576561; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fh7lxlRUUOBOSUbl27AL3W8RZwHT1ywyp8vFcMuzW20=; b=UaFssqZ6WB5lh3dd9LEdIMJa6uIaW+X0S7uGwkSMu2JGlHXObQebzxImrEPUbDKhHJ L7m78KhKl204jNyFp9YpqE8xRV15+iLMbh2CAyI9JGMye1uUd5vk1HYpE7d6LMd92Ssa m23EYvOP0aDC0dAscSbQacIV6h/SCDeZR8QkoFNE862eTLZkyEI/gprbp1mvf3s5+be7 OMKo9bIz/3yx1bXlQckf9Gge4apTyYTFplb6Sh1ut9zRmPtNh17fkhSbg+r8c8nSkNxy U0h9isgQi4/DwWA6MdFYb0YrxiMgRYPDD8Y3PSF6+pc6PpaC3Ex1YNc1PF4paFjBbNts bWvA== X-Forwarded-Encrypted: i=1; AJvYcCVtnxfKG8u4yoapncCULXtUeiQVHRfGAbHG+JuayAqFqkTgIl0W3ZhVyxx2NW/IahxHAo0RAaXfVA==@kvack.org X-Gm-Message-State: AOJu0YyKSDZPc9YBXjzWOtvwfAQgkKXef/TCW8xu15JSkAJwfnmIJPvQ 09hdGgjlui/qV/O1111zXHJIfWo7bMOlHf36BwbCj+sVYAGsvErWAXHa3+JyAcM= X-Gm-Gg: ASbGncvNHsAiFOX8s8ZYNmWNC7c0wZgVLgRhz+vYF3wqSFx8/rsHNa7Y7Ks0lONmQQR LgTnSboPFuUEHaxCQLSJ9oO1dv04zJfZ74FNrtI/gFeBPX7AB2DDfysVzMY/by7O1q3BMKeSCog vNHnOOjbVjOGGjk5iXSI/V2HQZBsiRS5U2kphG1E+OHbqDnCRC90cctcMzFYARB/qBb2pfOYjuH 37+GaVU/OaabfwH8xHW7pY3JE3lcbdqCDT0jqS13VinXB8EnRmd9g6/psZ9xl+K/NQ2lcBOZkqb AsYDVHfp3rJKVnmpcBn0asQB9wg4nGw1TOqLFZEV+bIganiYgZLU+A== X-Google-Smtp-Source: AGHT+IFgJ+2HbBGQuEYg1ZxuSUeSMUKWIvlavb6kWqrkz+KZUW5NOYqROMfup/1GiG2FdRu6kiom2w== X-Received: by 2002:a17:902:c406:b0:224:10a2:cad5 with SMTP id d9443c01a7336-22780c51255mr320743875ad.10.1742971760798; Tue, 25 Mar 2025 23:49:20 -0700 (PDT) Received: from [192.168.0.239] ([14.139.108.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-227811f66cdsm102246675ad.219.2025.03.25.23.49.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Mar 2025 23:49:20 -0700 (PDT) Message-ID: <05b7ed03-60d8-49c2-9094-4f34903f8a64@gmail.com> Date: Wed, 26 Mar 2025 12:18:28 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmscan: Initialize dirty to prevent uninitialized use To: Yu Zhao Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250325194920.53307-1-purvayeshi550@gmail.com> Content-Language: en-US From: Purva Yeshi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 41249140008 X-Stat-Signature: t8affcj7hisbt4gw4n95mzrggjpr83o8 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1742971762-30956 X-HE-Meta: U2FsdGVkX19s+Hjx9MecY7lw130yUbJRIVP2nhZBH+cGL2KvQmuPIF87o/+8OVaOvF3CNKft1Wa+KSSYxU5vhCGc+NhqBX7t3n79jwXi/UoOCotQjv3o0xd4xQKpFlAbI8cExN5ZYTjeLiDMHjxZPbAtY2at2Ep0ynoM9cDS64xdLeyiRkAqlJoAC0LOOGBt9rzQfIo/LN2wJElU128E6TY9JuJS0oWJf0nfi9QeppyANlb6DG0ENlgqXwROe3iwP5RJwbi5pRE5xsKXH9KdKX1R+C1q/TGhx5y0a5gcghnCG8AE+lVl9fmtFcnudGayn1udMtTZw6iXh6Sa0+3+eCNA5x8R9N2w5tLzV8vZgSRnsNWBZvultLfkN18N2qSgJKiEmW1MV61xcq3JN29dfw6SnMKGeJUFtep0dAstOK1tguHSUssynJDj8aBlkTE74xctFDVe8I/JkJb59rgnVkoByFd9KTs+AporV1xbayh/pWEcsYRr/cbFdwqvPRo4zevowwqkQyK2CK6SemvC6TBItU90Vc5k5JuohKsNkCXGFn27rR7vwtZ8BkqPchMIXPWQf1v3tosampT7bIunIwjt/MderphfTkBtyl4icuoRe8SCEutwZDgObatoy7kENRQ8n/b0uBFtKnH9Dm6MJHaHeOCL2jEXJNzcrA53UyB4W/1PXHtJFAu76jyXD6WhaeUcNp4cutTXkxWKWScIC8b0NkNGvrsZiG7S3O7EWVvCA7qTfb/1SYPlLOsLMYKIbrv7uH+zu/I1X7pO6EJBDB7w0ajyIQAWhqiHOfWRuK94bMTHQMHB2AolFo2akpG5iTjclqU8r0F4Ml2ZnAky4/W4qEW03avL6oIg7flBYDA8Vdo65N2ERmWMTjKS6idgdCynMCm12RvgG5VWOA8KW7jWs4j6D5YKisMujmFn5dNyJWe/Xptevteuud0/YwMCWTsUCMpVhIp30CG6u2D OqWcc1Be G0PSCqGDfPdcOILe9Vhrqg5CHgQf5Od1jiVHXkhZWqnuhWQh99yr27Uc+1czxAPL9W/nYU6xPnWrP+20zx7ic1NXBpTwsMqmiReC3pP5jbH6lbeMnpCfFsYDAaxPJcX/VKd+lkznd1ULBZS7syDrSyvJ6/njCbystbqNpkX7yMF4lDLpGCs9YhNrTOeZVqwRLklbOrOF4FZCtmvUUXn2MWY0X+LI39hAFP8Q0qZYU88oZ+WAVygu/NTfaOMspo8EpPlfnHmEl9Zw6R5KUo13ofL7RRmLHhgd6fMjeb5uexWQ+y+jQ4gpsRvK01KYZ4r55HQWqTkTD+XxJBYfozsNCtaxSI4JcYOsG9ueKwBLE7d0pnxwgvIQsfzBoHx67EhitrJYFDssUGQ9ayM5sBlXJctDKvsbSzKuUxMT3c8p6pCHKfMK/HNmhvDpvxUtkBFXsYiPhI/oqFi2E7PNYio84fjHTr0/q9mpjqkuD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/03/25 02:05, Yu Zhao wrote: > On Tue, Mar 25, 2025 at 1:49 PM Purva Yeshi wrote: >> >> Fix Smatch-detected error: >> mm/vmscan.c:3509 walk_pte_range() error: uninitialized symbol 'dirty'. >> mm/vmscan.c:3522 walk_pte_range() error: uninitialized symbol 'dirty'. >> mm/vmscan.c:3600 walk_pmd_range_locked() error: uninitialized symbol 'dirty'. >> mm/vmscan.c:3614 walk_pmd_range_locked() error: uninitialized symbol 'dirty'. >> mm/vmscan.c:4220 lru_gen_look_around() error: uninitialized symbol 'dirty'. >> mm/vmscan.c:4232 lru_gen_look_around() error: uninitialized symbol 'dirty'. >> >> Smatch reports 'dirty' as uninitialized, leading to potential >> undefined behavior. > > Thanks -- this seems like false positives from Smatch, where the > problem should be fixed. Should we make modifications to address this Smatch error, or is it safe to ignore? > >> Explicitly initialize dirty to 0 in walk_pte_range(), >> walk_pmd_range_locked(), and lru_gen_look_around() in mm/vmscan.c >> to fix Smatch error. >> >> Signed-off-by: Purva Yeshi