From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC614C32774 for ; Sat, 20 Aug 2022 16:36:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2B7D6B0073; Sat, 20 Aug 2022 12:36:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DA546B0074; Sat, 20 Aug 2022 12:36:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87BA28D0001; Sat, 20 Aug 2022 12:36:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 79B486B0073 for ; Sat, 20 Aug 2022 12:36:52 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C7050A02CB for ; Sat, 20 Aug 2022 16:36:50 +0000 (UTC) X-FDA: 79820524980.03.DD3252E Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by imf25.hostedemail.com (Postfix) with ESMTP id 07410A0003 for ; Sat, 20 Aug 2022 16:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1661013408; x=1692549408; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nvlj510pwDSr2D9r08GYwC0oOLAPDKEbOI+Rme7ojmo=; b=CjpaFTKDJ5/nYwutHwJuIzFGJMOCSKEtuLoEYfs4mOqUpjeped28UvRc DlzH23CN505vbrQ0sTwv04TVUcQaUBmq/v4LJRRvHf693fbD/E+MaiEE6 RaEBBVDkoxJuxcBpiFzLo/ZwRAvo//QBu2bZ/lbZ0+QX0lkvTBxD8y/Bb cZiZTSbn3XrCmTkGDpM+LeyRAujSJ1HYX5IviskJmkWVDCHJSyZFz9Y6g DFe7D33bnXo3lqNAGZ02z7i0mPobfRyBhybXUHIzbFEELgWnLeGjkaISM QR9kqgX/vfVnFbKUMPujTk8GUZh2NOoTUrUmSTtVMEgj1xjiwci9zRqul A==; X-IronPort-AV: E=Sophos;i="5.93,251,1654531200"; d="scan'208";a="207675646" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 21 Aug 2022 00:36:47 +0800 IronPort-SDR: bRGwMN0y0gLsgXLqjIwAKD+Ec6xSIrUEd1WBVsl6GAm+JSIvDjYxP9HGUFbaymreFznK9bc6SW swOmTqEaCYwVQQl+ZKZeWRj169FjnF49ZF+s2ilipZx7Tq57TxljzZ/U0gvbbPNZa3hu9bIc8t g9US0yOxmGqBKWZdPQzPkAHpBSH0aDrTuQBCuwccAYwh7OanJFjXvH7JVVK2bzFHmXoY9OF5e2 Ept3tkq4QB+keQq5oJUkF7ZrA9wHr63P22FG/twBrAsH0DDYubdr7prehqW3YqjhDJPfX8TArI H1DPDZ+NykfMDhq3yCzf14s1 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Aug 2022 08:57:30 -0700 IronPort-SDR: 7wDk27LbeqsEVrgYeUcvu4T751558OUt0/X/YQ/zHieEeCEoDAu/jagEsrZFpEQHEe9Zm1JofN RfXfTjU/HE1db5ZU0fm6s+3jGmsuOnLCO4HN4mo8BIF9fRsqNvBkShje2jA3II9/I2VeE0fv2r VR1IOSVrh6P9fy5OyQjDaceQpXitvUPXbawyADPXEYy+6BT1gHupkblfYlscXNZr22t/986WQw WqATbFzYXLZlpnf9mkDyjvuNgDLJAhe3OmHqAZYIAl+RkTZ0pwY/ilBSitLQVNlFnMlEiPK1bh f7s= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Aug 2022 09:36:47 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4M945V6z2Lz1Rwqy for ; Sat, 20 Aug 2022 09:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1661013406; x=1663605407; bh=nvlj510pwDSr2D9r08GYwC0oOLAPDKEbOI+ Rme7ojmo=; b=frvmEaj9ZiicYG44GqFxXEYPdYodlwaZvO6Dd4u9xOpwdRLfVfc TRnnJIF/8eOyf6mNcBYCZy7A3GWe9/AxOak8/5P0wTXkekwobZ1UCGZAQbR7jRrZ d0XuuYHGwDQl1IodFS9qU+X6HC7HaeeGlRt9ltINAa8TuwAMAhmXBk3oRe6Txd2D gH5c5OlAuLvXgq0fWxbXRREYnz4EzASMUkQys4Q5tEpS55BDR0BRk261knd36i3B oQf/+woNXgIplBa7nA6u3HQ/1iyGgacu9UehNZH4GxBnI/IZnItUrJugo8BQ1An5 czGSkBSpuQczFs3CgZAcDegk9G4rtdeWuHg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id AFaDw1XjA_H9 for ; Sat, 20 Aug 2022 09:36:46 -0700 (PDT) Received: from [10.225.89.57] (74r92j3.ad.shared [10.225.89.57]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4M945T2QDBz1RtVk; Sat, 20 Aug 2022 09:36:45 -0700 (PDT) Message-ID: <05b55329-6e55-c3ff-0c41-5254a5625473@opensource.wdc.com> Date: Sat, 20 Aug 2022 09:36:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression Content-Language: en-US To: Oliver Sang , John Garry Cc: Christoph Hellwig , "Martin K. Petersen" , LKML , Linux Memory Management List , linux-ide@vger.kernel.org, lkp@lists.01.org, lkp@intel.com, ying.huang@intel.com, feng.tang@intel.com, zhengjun.xing@linux.intel.com, fengwei.yin@intel.com References: <2e9cf5a6-c043-5ccf-e363-097c6c941891@huawei.com> <43eaa104-5b09-072c-56aa-6289569b0015@opensource.wdc.com> <28d6e48b-f52f-9467-8260-262504a1a1ff@huawei.com> <743867a6-b266-58e4-a8a6-542757916f0a@huawei.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661013409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DIj1gq/RxT1U/Ewm7X4TXbXyEtQujFbYKqk6qTV58WU=; b=iDx2C7ULGUW+YckbkRBKsp4aw6J+JAhvLW2QgJWufD8uWENyWhykdplJQ2eTDxAaTFjdcs 1ivXjfyibH9wWrQDyPdCRTnKN4fMWsH22bvuYYMEjJ8IFHpqw19h37NMLJSWdZizgzKwJR oI27agd5KBKrt45YfSk/i344jEHO5XE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none ("invalid DKIM record") header.d=wdc.com header.s=dkim.wdc.com header.b=CjpaFTKD; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=frvmEaj9; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf25.hostedemail.com: domain of "prvs=22479323c=damien.lemoal@opensource.wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=22479323c=damien.lemoal@opensource.wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661013409; a=rsa-sha256; cv=none; b=RCxqn+bkfspAsirrSN8WmTEVgKFicJ2eDycfws2jPn7tTyAeSoPJ1oG/7XYK7uveAOFuxZ KmhJbn8qvHZ5YYKSTdOEDofnTIV/NVgtPfysdqvya3zG4NLGMWciN+VxGB/4QqhGmXy8uR MV4/fGgWSAWkafuyXB/gsVdNBd3jBf4= Authentication-Results: imf25.hostedemail.com; dkim=none ("invalid DKIM record") header.d=wdc.com header.s=dkim.wdc.com header.b=CjpaFTKD; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=frvmEaj9; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf25.hostedemail.com: domain of "prvs=22479323c=damien.lemoal@opensource.wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=22479323c=damien.lemoal@opensource.wdc.com" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 07410A0003 X-Stat-Signature: bznybrqyxniwypqw1acneoam4jxnoryc X-Rspam-User: X-HE-Tag: 1661013408-464898 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/08/18 23:24, Oliver Sang wrote: > On Thu, Aug 18, 2022 at 10:28:30AM +0100, John Garry wrote: >> On 18/08/2022 03:06, Oliver Sang wrote: >> >> Hi Oliver, >> >>>>> did I do the right thing? >>>> Sorry but I was not really interested in 4cbfca5f77 and I see where that >>>> build error is coming, but don't be concerned with it. However, for >>>> avoidance of doubt, if you have results for vanilla v6.0-rc1 then that would >>>> be appreciated. >>> for v6.0-rc1, it's still 512/512 >>> >>>> I will also send a separate patch for testing if you don't mind. >>> sure! we are very glad that we could help. >> >> As you probably saw, I sent "[RFT PATCH] ata: libata: Set __ATA_BASE_SHT >> max_sectors" for testing on top of v6.0-rc1, and I hope that then we can get >> same performance as v5.19 > > yeah, our test confirmed your expectation: > > stress-ng.copy-file.ops_per_sec > v5.19 - 26.85 > v6.0-rc1 - 23.03 > v6.0-rc1 + your patch - 26.94 Thanks for testing Oliver. I pushed the fix and sent it out as an rc2 fix. > >> >> Thanks, >> John -- Damien Le Moal Western Digital Research