From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE7C4C7EE26 for ; Mon, 22 May 2023 08:29:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BE09900003; Mon, 22 May 2023 04:29:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36D7D900002; Mon, 22 May 2023 04:29:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25CB6900003; Mon, 22 May 2023 04:29:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 15398900002 for ; Mon, 22 May 2023 04:29:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D479F160230 for ; Mon, 22 May 2023 08:29:05 +0000 (UTC) X-FDA: 80817215850.25.F2CB72D Received: from out-6.mta1.migadu.com (out-6.mta1.migadu.com [95.215.58.6]) by imf02.hostedemail.com (Postfix) with ESMTP id CE70B80010 for ; Mon, 22 May 2023 08:29:03 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=LqXBFS6C; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.6 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684744144; a=rsa-sha256; cv=none; b=T3ggHaOyPDT/xE0HT6CFmD1tNQnvrb7tWL1UVq262eGtQ+aKsd87Lg7YjHkOwCY8KKIWwl 2sGpCN4je48CfUCtCWJFqgB7m2DIfuE0BaXnOu7rPkb+3h6LTDadM50Es7N829PqwjE8hi GUij9+k+f3e9MlqR+uETnASKANITZ2M= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=LqXBFS6C; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.6 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684744144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2LMykAnh9K8a8DhpkmHVAinUJdctqspZeCJeDVlxCjc=; b=AybEQfiTG7mQbvJgILh/+StKGb+4Sh73HCPPX0iVihnsnVxHlyfztKnkczxW602phmKed6 Xwk7H9/uaVBgJKZrHeMOXQ9TomYH183+nDbCqHaq443N5swtow55OsCymOYAFbHAfHYiq9 7vJqKyGngfW+Z3su+sFfx9Gon3EVEEI= Message-ID: <05ab340a-d500-e742-fd59-5ef2e4ea86e0@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684744141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2LMykAnh9K8a8DhpkmHVAinUJdctqspZeCJeDVlxCjc=; b=LqXBFS6Cdr/XbW6ug56FJwR2eJFwuNCWNp5foT7HIBJKb2gQRgBGOKwQAdOh32ZBXXSQv0 vo8DmU35b+7B9+Nsmvy16xlVLawLnSci+BhiRonXdG/h04WSXqSZ/IRYkIXWPE95y5vHQq zYJwMe3Uxz+cBNLhjMSy/psfVn5pTe4= Date: Mon, 22 May 2023 16:28:54 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mmu_notifiers: Notify on pte permission upgrades Content-Language: en-US To: Alistair Popple Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, will@kernel.org, nicolinc@nvidia.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, jgg@nvidia.com, John Hubbard , Andrew Morton References: <20230522063725.284686-1-apopple@nvidia.com> <620eef7f-ee01-673c-b097-243d6fe25b09@linux.dev> <87a5xwajn4.fsf@nvidia.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: <87a5xwajn4.fsf@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CE70B80010 X-Stat-Signature: sq9omrdmpshw7agz7jen8uunwzyyu9kk X-HE-Tag: 1684744143-627840 X-HE-Meta: U2FsdGVkX1+n5VShCuTilxGEn6AnCLDLJv+hklWbWfgjgHfuQgSHEaqsGh/8nPwaPg//zKpsdDkICgnnRtla3ec3MYnIp6BT4SbYyuCmD4lt2kRleSBZGI/ZKeYKjI0kmeMoKFdGUol2EjjH9be9+GgpLtOKYB87w5kSDgUMumRec0q2DbUk0k7gTPIx/sk2zOAxyD+WC9v0I8SWR7zwozpe4IOVGxC7CBKX9ujSwUpQ97zJujdgdReltpTMlHPGFfP/NblEIO0d89YKsnRKi4vUlI2i41ETr06ZyzZ3RJC/zqTItK0G9T2wKA4B4t2gieOX4dTvqZonlu/6XtFXaukqltA0JEojsLzyrCm+ZwaUCDSiGTt0lKABV3XvcBigNH7D/0M9X/j7KnI6XsE4CrHzSs9sywAiIo1ELnU39OVfsDK2AgGJ4b8JwYGvVssUjCA8kJmcznZw/E0zirL3y1Jii1Gk/x+Ytvxq8VrsG2Dt0Uvm8fUWFHynmAURrAefiHuDtionrwD2HyYqJloZ3Cuo1ggdj/wKKgSQXdU9FX6mYWZw4mpgfsOkmS2KYd8uDovj+Gz8F39Pf5uzFvqTuS31rKlwiORi4z5BQhHnvfB58/HCoVrOQL8JET+gkJVOHsR/YoD8z1nuYBRUATUPO+g/DDR4ngRa8U2F+hkQD5eKd/35x59CwmPbmSke3rXV4WefQgC6VU2caHyXR8EWZNs/C5s3oYS2wuFkcw2iiXy7aqbT6BLjhNU3bGcil2s2pBKEBcmTJqvQxQNNuAtdPOSte9ftCYe3BhGUKHEOKMVRUTO2gLPj3rl3mSvqKKb+HAaEDYk5weu4JBJom7vhTSfJIBcvhsXzMoEvAo0KYkBcrTGn0pmzHV2QOBxkrmhQCeuYASzlRUho24o6Fl5oPXjMn9lhakEFxkqwLPBBl7/93a14DnAceZj/1gY2zRCru9D4DDgstbx9OAntIAG nCCRYPOp Cv8/6IMtIVrEhO6TPC+xnhY6WeIcS2KM3KgsAPOcvifvEFMs0qF4o0gXI1+tZ4A/7ZyTDQr5+VBRg52mc0ORPiOvB5FX+AzyB+2vP6FU0sR5R112xoTecBhHfEnc8+iIReXdKR2tx4372UT0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/22 15:45, Alistair Popple wrote: > > Qi Zheng writes: > >> Hi Alistair, >> >> On 2023/5/22 14:37, Alistair Popple wrote: > > [...] > >>> + if (changed) { >>> + struct mmu_notifier_range range; >>> + >>> + mmu_notifier_range_init(&range, MMU_NOTIFY_PROTECTION_UPGRADE, >>> + 0, vmf->vma, vmf->vma->vm_mm, >>> + vmf->address & PAGE_MASK, >>> + (vmf->address & PAGE_MASK) + PAGE_SIZE); >>> + mmu_notifier_invalidate_range_start(&range); >>> + mmu_notifier_invalidate_range_end(&range); >>> + } >> >> There are four similar patterns, can we introduce a helper function to >> deduplicate them? > > For sure. How about something like this? > > void mmu_notifier_range_start_end(enum mmu_notifier_event event, > struct vm_area_struct *vma, > struct mm_struct *mm, > unsigned long start, > unsigned long end) LGTM. :) > > As an aside I didn't just use mmu_notifier_invalidate_range() as that > doesn't allow an event type to be set for interval notifiers which may > want to filter this. > >>> + >>> return 0; >>> } >>> > -- Thanks, Qi