From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2AED1714E for ; Tue, 22 Oct 2024 01:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A204D6B009B; Mon, 21 Oct 2024 21:11:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D0426B009C; Mon, 21 Oct 2024 21:11:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 870A06B009D; Mon, 21 Oct 2024 21:11:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5DC8B6B009B for ; Mon, 21 Oct 2024 21:11:51 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2359340E0A for ; Tue, 22 Oct 2024 01:11:42 +0000 (UTC) X-FDA: 82699460466.13.B008A2E Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by imf12.hostedemail.com (Postfix) with ESMTP id 983874000C for ; Tue, 22 Oct 2024 01:11:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=uGa0+Piy; spf=pass (imf12.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729559430; a=rsa-sha256; cv=none; b=G3xpl3/NqF6eQQRLL8DwQy6RkC88t7AERbNunRkJZtAKqClvnIVb3M/q2EVq19yasYyN35 dhWhvqbNGhJVv+Yg6Pg4BrS1eVlHxcEgtwVP1UJvrwz5vE5FiZA55arlDWWgaRws3pLEV0 pUhwC1YWtaZ46kjMX9GX2Ps6fHJMMuc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=uGa0+Piy; spf=pass (imf12.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729559430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Su0JCUUNtQowa7ZUF9W/JcsQXW+zdoUv4LGM6ZfbIrs=; b=wITNEftnAdr58UbK6kdMePxYR3B4yUE8pIgZ2A5F/6D6SVZ8sPA7+xLMgQ8hWqqdWtlqoQ CxkB4z8bksn/qsm5sA492TQesWMS1R1uAAcxE0Yv4vXX2hU6Tz/RBELrzXkDt4TSwtheMs FyfJs1OppsrJVL+qw8QZNWTwPw7/OOk= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1729559502; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=Su0JCUUNtQowa7ZUF9W/JcsQXW+zdoUv4LGM6ZfbIrs=; b=uGa0+PiyvUPYy59ldeL2ZKpGWc8aSwbBviuyTuPO/WBrTWxLyhmvR8Um2+Goq43Oz0Pg205XxWFh+j1yqn0fzvi+od7mwWwUB7oUNPiiQQINTyrFVoeS6Nd52YJuVeWd8o291Xm8KwFFgWA5r3vfA8ZN4Nkw08S0mO4lDLfPNzA= Received: from 30.246.160.103(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WHfusch_1729559498 cluster:ay36) by smtp.aliyun-inc.com; Tue, 22 Oct 2024 09:11:40 +0800 Message-ID: <05a8d26b-b023-426f-879c-7d33be4a6406@linux.alibaba.com> Date: Tue, 22 Oct 2024 09:11:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 3/3] ACPI: APEI: handle synchronous exceptions in task work To: mark.rutland@arm.com, catalin.marinas@arm.com, mingo@redhat.com, robin.murphy@arm.com, Jonathan.Cameron@Huawei.com, bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20241014084240.18614-4-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: <20241014084240.18614-4-xueshuai@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: cny15m1nn3hjbirpbym3ptqaatti956x X-Rspamd-Queue-Id: 983874000C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729559498-385069 X-HE-Meta: U2FsdGVkX19XpgM+B446xIPqiOiMt5SmJqvMUQclaPOnpxI4hk23mn5gVMbFrhTwfBhLiugcqEcwpuoIOv/YpZNonEx2sO8PrYjE3I2qUu1mDoOd+SplGiXljEp5nJMh2NFZXHPo2aAoHT4gCT1lIHE7xczYNuVigIm0euyBVSxpEhnbCHKoCBsq7XUewu6N92WCw6BN4Vtxt7eLvcu84tT6Ol+HarJoetNQnwqnnAbWJMyKfgDyAUpPoQfY42ix+CODvNYHJGoZUzp1aiqPwUjsq3I2ngmO3vpGQPTkDAhnUyZQcnkb1e3BYDvs+Pcuj+pPn3r0aKOFAk1BQtL3iSn+5Joa6fa887R+egGn5KCP9FuUZjgrXRt8zFZGuZPfBz++PaeefKxKIxOlvpTz7iPtigqta6fAcMZuGZTM4+DhOxFkrr9vcpm+EY4sx4exXrdqTPM48AL/sdCWHAwYCjKvzF3TlBCePUs6+cHp3iC/pdOu0hNidKVvFt0GCm71Dlarie2a3uldpFr8SE+YFFo+jDgCYwAEbnO2xjgvdM86WMXJxf7AHk015Mn3fHIitmTM6R4pwz+BvCC4M8YreH3HmRW8BZoEZSs7C90zPP2R+lMFapYoGy1QFFmgVAQyeX7AmCdjSI5WhXfYXykHd6Vem4553d9GAqiQkyomAePXdIScfHm9O/Ld2TFANvzyCur5P81q5BXQWQD+V33DS9Ay5BR1zVZPUwqJT/yJHs7PheZ/HAyR/d3B0+p4Pq2ELiV9uacX7ochF6qfeB8FIS9XC5ybk2K8QwSYtqo2R8NE1t4Vz5mYOAb4w0mVG3t59kOiPnbU56FbLpk0q3yeYIEL1M41tCXg1jRSQH3yxcpLiEQa1w4KZbwl1ey9Uj7jNq1hrnvxW6TpmWjZvlTATp1nNdraT2zAs8BhJreZ9SndPwgF3i7bntN3MXSTPMncIngVsHaRpLumd/rlwmt qT0kd1n7 rkbueH3IpgATovJ7+VTPJ6uRZoEOGLYiSoG8/WU33z/b8kb8sqLvtc/tX4iezgWqW5dj9pNHTH4L0sgFcBRMbwbogyYfQCj4olUlaWwnN04OMYlkRuSUQ105XwQTzDssDLhoVFdQ7OxN23OkDJ/Q4CAXEV/k/dqWr1Hrm4doBtzNAgZeIFPfOonXnsyHgEQP0avRqlBHONGmRUCt047D3dnmtWqTIurG+VJmMtHsvZC+YfXbHLEdB9s5qfrhMSeuqQEr6tNXuP6xvPtySO9QBDBuYVvcd/lwoOD3YmM2Lfrg8MHyXlIaXa6g1ayeEt54ZehKchAi7lJvHxog= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Jarkko, 在 2024/10/14 16:42, Shuai Xue 写道: > The memory uncorrected error could be signaled by asynchronous interrupt > (specifically, SPI in arm64 platform), e.g. when an error is detected by > a background scrubber, or signaled by synchronous exception > (specifically, data abort excepction in arm64 platform), e.g. when a CPU > tries to access a poisoned cache line. Currently, both synchronous and > asynchronous error use memory_failure_queue() to schedule > memory_failure() exectute in kworker context. > > As a result, when a user-space process is accessing a poisoned data, a > data abort is taken and the memory_failure() is executed in the kworker > context: > > - will send wrong si_code by SIGBUS signal in early_kill mode, and > - can not kill the user-space in some cases resulting a synchronous > error infinite loop > > Issue 1: send wrong si_code in early_kill mode > > Since commit a70297d22132 ("ACPI: APEI: set memory failure flags as > MF_ACTION_REQUIRED on synchronous events")', the flag MF_ACTION_REQUIRED > could be used to determine whether a synchronous exception occurs on > ARM64 platform. When a synchronous exception is detected, the kernel is > expected to terminate the current process which has accessed poisoned > page. This is done by sending a SIGBUS signal with an error code > BUS_MCEERR_AR, indicating an action-required machine check error on > read. > > However, when kill_proc() is called to terminate the processes who have > the poisoned page mapped, it sends the incorrect SIGBUS error code > BUS_MCEERR_AO because the context in which it operates is not the one > where the error was triggered. > > To reproduce this problem: > > #sysctl -w vm.memory_failure_early_kill=1 > vm.memory_failure_early_kill = 1 > > # STEP2: inject an UCE error and consume it to trigger a synchronous error > #einj_mem_uc single > 0: single vaddr = 0xffffb0d75400 paddr = 4092d55b400 > injecting ... > triggering ... > signal 7 code 5 addr 0xffffb0d75000 > page not present > Test passed > > The si_code (code 5) from einj_mem_uc indicates that it is BUS_MCEERR_AO > error and it is not fact. > > After this patch: > > # STEP1: enable early kill mode > #sysctl -w vm.memory_failure_early_kill=1 > vm.memory_failure_early_kill = 1 > # STEP2: inject an UCE error and consume it to trigger a synchronous error > #einj_mem_uc single > 0: single vaddr = 0xffffb0d75400 paddr = 4092d55b400 > injecting ... > triggering ... > signal 7 code 4 addr 0xffffb0d75000 > page not present > Test passed > > The si_code (code 4) from einj_mem_uc indicates that it is BUS_MCEERR_AR > error as we expected. > > Issue 2: a synchronous error infinite loop > > If a user-space process, e.g. devmem, a poisoned page which has been set > HWPosion flag, kill_accessing_process() is called to send SIGBUS to the > current processs with error info. Because the memory_failure() is > executed in the kworker contex, it will just do nothing but return > EFAULT. So, devmem will access the posioned page and trigger an > excepction again, resulting in a synchronous error infinite loop. Such > loop may cause platform firmware to exceed some threshold and reboot > when Linux could have recovered from this error. > > To reproduce this problem: > > # STEP 1: inject an UCE error, and kernel will set HWPosion flag for related page > #einj_mem_uc single > 0: single vaddr = 0xffffb0d75400 paddr = 4092d55b400 > injecting ... > triggering ... > signal 7 code 4 addr 0xffffb0d75000 > page not present > Test passed > > # STEP 2: access the same page and it will trigger a synchronous error infinite loop > devmem 0x4092d55b400 > > To fix above two issues, queue memory_failure() as a task_work so that it runs in > the context of the process that is actually consuming the poisoned data. > > Signed-off-by: Shuai Xue > Tested-by: Ma Wupeng > Reviewed-by: Kefeng Wang > Reviewed-by: Xiaofei Tan > Reviewed-by: Baolin Wang > --- > drivers/acpi/apei/ghes.c | 78 +++++++++++++++++++++++----------------- > include/acpi/ghes.h | 3 -- > include/linux/mm.h | 1 - > mm/memory-failure.c | 13 ------- > 4 files changed, 45 insertions(+), 50 deletions(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index f2ee28c44d7a..95e9520eb803 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -467,28 +467,42 @@ static void ghes_clear_estatus(struct ghes *ghes, > } > > /* > - * Called as task_work before returning to user-space. > - * Ensure any queued work has been done before we return to the context that > - * triggered the notification. > + * struct ghes_task_work - for synchronous RAS event > + * > + * @twork: callback_head for task work > + * @pfn: page frame number of corrupted page > + * @flags: work control flags > + * > + * Structure to pass task work to be handled before > + * returning to user-space via task_work_add(). > */ Do you have any futer comments about this patch? Any comments are welcomed. If not, are you happy to explictly give the reveiwed-by tag? Best Regard, Shuai