From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1FD9D2C56B for ; Tue, 22 Oct 2024 15:12:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 678BF6B008C; Tue, 22 Oct 2024 11:12:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 626856B00A3; Tue, 22 Oct 2024 11:12:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C79E6B009A; Tue, 22 Oct 2024 11:12:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 23CFA6B00A3 for ; Tue, 22 Oct 2024 11:12:11 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5D5711A0213 for ; Tue, 22 Oct 2024 15:11:41 +0000 (UTC) X-FDA: 82701578274.25.B1F46EC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 57EB1C0023 for ; Tue, 22 Oct 2024 15:11:52 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="soOuH/iQ"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TB3dEzq1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="soOuH/iQ"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TB3dEzq1; dmarc=none; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729609805; a=rsa-sha256; cv=none; b=cV10gBNtBvOlICPimAtvVEsrG7a1pL+aLJLNYfD+UUjtcDkiOC1EuEjBHnTCCMv29v0tq+ Xnu297lB1W+2FfxRXDVeZ6OWhvTc/skngjCGL6Wyo5oE89uZ6kjpnKLlPTR9Siy/Wk7ePf dtdvssRJ86Oy8TML8ZQkaZAOg1C3CT4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="soOuH/iQ"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TB3dEzq1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="soOuH/iQ"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TB3dEzq1; dmarc=none; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729609805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/WlTj8uHXexD73RUZOVZfSINub0YlimFwP0PyxDDpqQ=; b=iEIaxEzXhP0tTpybySBK0oCaoMoTC9OY+eWJsG+xD7kDAj0md7n3Nn0tcIX1WJxwWbQPTV 0xhbfg0QcHzszYRmxFz9j1YVOVu6Us2775x8Xao+BjbCPVQpMksDmS4b1trnAobySixbda nHQwT+yXRO0INCl5gXqzKXSV9UeV5b0= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C114F1FD26; Tue, 22 Oct 2024 15:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729609926; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/WlTj8uHXexD73RUZOVZfSINub0YlimFwP0PyxDDpqQ=; b=soOuH/iQ5ls1O/pdG/V53Jp+TutFmRqRKBjwcTnP4fGf4E6G4dAqiofBzjVbL61zl9YZPe Fpz/UlJAe1L5j3GhGgd3a+TdGQ8dj/bg3HtHdd7iUP4bCNsrDom2lzuUAHB7dJ/QQgKV+r 7i4TESDjd39bItNZzHbI5MYk8mONFoo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729609926; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/WlTj8uHXexD73RUZOVZfSINub0YlimFwP0PyxDDpqQ=; b=TB3dEzq1CWePhp1NM/TaeQZxAbc+FEXEEOmF+rIH6iqG3rPgCqxuQVPzF77tmmSzyBobkw NikpoZGICA2Au0AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729609926; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/WlTj8uHXexD73RUZOVZfSINub0YlimFwP0PyxDDpqQ=; b=soOuH/iQ5ls1O/pdG/V53Jp+TutFmRqRKBjwcTnP4fGf4E6G4dAqiofBzjVbL61zl9YZPe Fpz/UlJAe1L5j3GhGgd3a+TdGQ8dj/bg3HtHdd7iUP4bCNsrDom2lzuUAHB7dJ/QQgKV+r 7i4TESDjd39bItNZzHbI5MYk8mONFoo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729609926; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/WlTj8uHXexD73RUZOVZfSINub0YlimFwP0PyxDDpqQ=; b=TB3dEzq1CWePhp1NM/TaeQZxAbc+FEXEEOmF+rIH6iqG3rPgCqxuQVPzF77tmmSzyBobkw NikpoZGICA2Au0AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AB47013AC9; Tue, 22 Oct 2024 15:12:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KN1+KcbAF2exAQAAD6G6ig (envelope-from ); Tue, 22 Oct 2024 15:12:06 +0000 Message-ID: <059dead9-51c5-49b9-bbb9-5f3be741c830@suse.cz> Date: Tue, 22 Oct 2024 17:12:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/slab: fix a memory leak on kobject_init_and_add() failure Content-Language: en-US To: "Christoph Lameter (Ampere)" Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org References: <20241021091413.154775-1-42.hyeyoo@gmail.com> <77d5c04b-9b97-4aee-85a9-c5efb2fa21fe@suse.cz> <439eed20-d0c7-8332-2f17-d785321d3310@gentwo.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <439eed20-d0c7-8332-2f17-d785321d3310@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 57EB1C0023 X-Stat-Signature: 4q8r9hk3cgw3z797zj4fh4x763m7youp X-Rspam-User: X-HE-Tag: 1729609912-88827 X-HE-Meta: U2FsdGVkX19FBa4NpEWuiHiy549iszgBNtk1hwme2BtRglrGTVT7+fIWVpbG94B91yrvrHLNfRUoxPJGjawmt2aXqnh20+P57kibbxOFETdR8X28UAGWEBeoikp65zzk6LIGGEr+MO6wp+EdmwRiINKln+Fi92Q/Fgeq34ucntKnT3dqofn2LvlXWAfhLzCLujJCrik8al9Y2W4CApoZ84DxSjUwqhRDZGNqRQNZpwFm4I2whsgtXQLhp17vioOQcFgmh2olVAKIC283UiohA5UczC3Q8hOos/0l3Q6WDbZxzRlMQ02vbbWYE4Uxxh21isrZG16VIHFQlyttJSTEuzdMxfeFbRqCjN0PfPTT/OvzCr3jJPHcRQdlvVMK2j77E/rroAZ0mE/7+Y6vcAFTrUlF63e0TqL+VjKSoO/k4Apr4ST2wcFHIswaDLF9cJHMd/YEhdbudnJoo+32L8nFIpxHRMZNDMLI+5jPDmE6LGib/Jt1wHGKS2c2eXqmJZWhiilZsoia898vAiqC/KYBv87pb2HhCts79nWz7cJBYL9c8NeAvY/BAVaxqhc8o3cYfdNkm6qexxmaPmi0XDham3tK5TjKotfH134xbEbXHWYUQ/5FolXnvzx8FFJhiDSA+/04igX6WR9idwK/hDXyjp1M7TXYnCaB6WV86SStPjKVx4iRUGgRT4b2E12aWGCPILzfeJWj7m6/kN/4ykEpgAYyI4dS2r4ZGtsuKbE/mAqaEGthqCbnJTe+5cdsyD2m7st3p7fRBl4G7hauLdSMaHEXkFooeOnWYRdA3ZA7l4DemdpS6uQJb3WkAuYf5twAdJiEEgpqHQQQQ9e3Ur+t/ptzSJRVlfKdqfICVF51Eo8s/w+GoFhuQB3HYg1763PLO0yMx3Hh1dpGM4E2TBKMC4o7YuvL94Cg2USWui0r4MOm+ZljY05HtrwJgPfWbBfGQRhK6kKFcVfExRC1IyA OLspjbX3 +j0Uij7L93abziqD6VztPpy465z2V+fenmHHYqgHTAAkef5KDcIHuYxucud+7gtL4Tb1b4zJKLfJ6LoMxsvgcbZtdEvYsRWFtb4Ya3yeoH//ccVR1mAGsVokeiIgtiS6QL9InwypsvAPe+EdyZVIAjnSbsUQG9ujJO8fMlrS0roPVs7RWgZLsYpwP6CyChz2BbpaAAcKt+YAqg6Li4thRFoB3Fgy/1E5VUbH8ZaG99sikpszeeCgaZ7MpmGB898o+GPPzMwg48ebaYmIpvYk6oHOTmQbPUf9TSS/VAfljqi8d8jDj7eC1AXAFPRjzS5Rjaj2B1RuFWAMnPfQQW3yQdX2atEggNAw+vOyXezP42YOwWw9eUDmRwoJf2ueiMBH63zzjBUxbIEVxNXHUWOuu+dC5Ug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/21/24 18:27, Christoph Lameter (Ampere) wrote: > On Mon, 21 Oct 2024, Vlastimil Babka wrote: > >> I think the comment "If this function returns an error, kobject_put() must >> be called" means that *if* you want to destroy it due to the failure, you >> must use kobject_put() and not e.g. kfree(). But IMHO it doesn't mean you >> must destroy it because of the kobject_add() failure. > > Right. The simplest solution is to see the sysfs stuff as optional. If it To clarify, I only meant the case of boot caches processed for sysfs later. I don't think we need to start ignoring all sysfs errors. > fails to create the sysfs pieces then write a warning to syslog but let > the cache creation succeed.