From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3EBC3DA6E for ; Wed, 3 Jan 2024 19:43:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B67E68D006F; Wed, 3 Jan 2024 14:43:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B16D88D006C; Wed, 3 Jan 2024 14:43:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DF148D006F; Wed, 3 Jan 2024 14:43:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 89CB08D006C for ; Wed, 3 Jan 2024 14:43:16 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 669EE120896 for ; Wed, 3 Jan 2024 19:43:16 +0000 (UTC) X-FDA: 81639023592.05.A8324E1 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf14.hostedemail.com (Postfix) with ESMTP id C81CF100006 for ; Wed, 3 Jan 2024 19:43:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=gentwo.org; spf=pass (imf14.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704310994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vmaYDbGpGLqnyitRjZRmhnO7ZHTy5ZmkiNjI0RxXgPU=; b=B/01/DgZforvLK81mSlu38jz0zZ6krzfb6nYzKMMdEFwFY+GrSMz3ARXk8lr5ROurHsPLF xMFCWEN94p8X1Ah2+TfvDDjmfohYwkGn+ID2o0Wk7/7RJ5P7GAUMdcvd5CIRlHMT8i6D/2 58BEpregnGIB/fCBSh7FOyfHbR6v1gg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=gentwo.org; spf=pass (imf14.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704310995; a=rsa-sha256; cv=none; b=JEJTpopcR+QmrszU97pqasUuSEe4G8FFbiX72dHgSCcWj5EfMwjdH4a2USjpLdyFPz4eFu Gr5c86Xg0Z1LJMOdndH7fj3dyow/Zm8QQNP/nu38V0VZNTFGmIu7qiTSiA3rfOFdxc6NQm jgYT0DDYaJ0bcb1K65gD4GtDbA3RKPk= Received: by gentwo.org (Postfix, from userid 1003) id 2244F40A8B; Wed, 3 Jan 2024 11:43:13 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 2135040A82; Wed, 3 Jan 2024 11:43:13 -0800 (PST) Date: Wed, 3 Jan 2024 11:43:13 -0800 (PST) From: "Christoph Lameter (Ampere)" To: artem.kuzin@huawei.com cc: x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, luto@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, mcgrof@kernel.org, rmk+kernel@armlinux.org.uk, nikita.panov@huawei-partners.com, alexander.grubnikov@huawei.com, stepanov.anatoly@huawei.com, guohanjun@huawei.com, weiyongjun1@huawei.com, wangkefeng.wang@huawei.com, judy.chenhui@huawei.com, yusongping@huawei.com, kang.sun@huawei.com, linux-mm@kvack.org, linux-modules@vger.kernel.org Subject: Re: [PATCH RFC 02/12] mm: add config option and per-NUMA node VMS support In-Reply-To: <20231228131056.602411-3-artem.kuzin@huawei.com> Message-ID: <059dc132-af10-fd08-7368-302c765a4269@gentwo.org> References: <20231228131056.602411-1-artem.kuzin@huawei.com> <20231228131056.602411-3-artem.kuzin@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C81CF100006 X-Stat-Signature: 7knsbycidmuinuuq1h3x7hqaiad8i8a6 X-HE-Tag: 1704310994-650653 X-HE-Meta: U2FsdGVkX19gT6mzz38LBvxssxANHL9V1JEGAhbmRzrswUmj/cRxSvMpbxr3vxDsEDiFwmFrNOPeqqJdIi/groWiu1FPi/Ycr9S2djZB3fy22m4TxyHjtYCysew6YugxSbOHP3ffLn/bHVBxZvBk6nvH88N2EoUXUFWhdiZXO3pNbiGlsltszQOkr6iQmKe96FhRum776O+0XzCTiBE0f7NB8qi2Z5agocitEDXGffVgxNk1EwQ6hbW7ySvmNsAe8wKw9qM7k4VjnrcF9eQYOk7m6lzt+3hhnyuq9v34viap4ou1QyFXIybxtuimw0fTKeut63jbcFPVR2eCTeDBQ3VF3QLGmkFnyEJziJClvc7+E0nNeiC/IMFvXVD3eIx+9hOajdicsMED1M2n/xzeK7EZfq5fUiuAIR5HMKhpBOG45YF7gSbekaPUPIGrZJU/tdaDE9GQWLyum1rwImg5fMTp+y8kB8w4lSLD5U2HjdSq8VUZguH/tlI/9/f2NL/GUB914mOlDDhmH58bPrWi13CL9OCtOic0laoxbyzeIf2qxcAoyylQOD2aEfdrJygTTjXQ2T70BZsnmphUZ548qWEqt99+8Bh4/jVLEIJsK20+tBWBLooHFapwv3+CVUFTnIOwAzrMLKqW4STl8ZYyvgloW5Lo8RR6DvpSZBfhoDx7iXOCxNQgldjHloRPXiPzHzutN7EBTKPrW3jwiVf8owdvtwlbtlxhGnDhHelTXtVS9YiXP2H9PirkWILt094s+UuBbqxNLD8w03uzrZGOdve2FWAHltqihG0WTy2CtP0+uNmGWmUbS31QgcJDrKbiNMxwWmUuis2eB+wcRiazeje7ejlfbiqaJCN0jM2HckyA58eLl5ZYnUEaeB5VaGuD1/+wsQm8wY3lscdaRfFzur6B/N/iwrlQysfvY/kRwXhvD14D98el4oDAeiVHB0v8axlRRRTda/c2naTN+Bd vSsCaqak MtZxdfFgZJpZujRcRiG/UIbiDCOkP94+AwTlc25al5z9OIxfLffRWD5Odg/xEKWycWPjW3eTkm7i7hHuePcEIkN3J+IAhxm29ulnIkLFsMCXrCrOH2TdvRWjoATZgjFB0vXXY8ISO0tJ0KojTqR4FoZcNvvzAUNJMxcUGOXhvdTXn72Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Dec 2023, artem.kuzin@huawei.com wrote: > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -626,7 +628,14 @@ struct mm_struct { > unsigned long mmap_compat_legacy_base; > #endif > unsigned long task_size; /* size of task vm space */ > - pgd_t * pgd; > +#ifndef CONFIG_KERNEL_REPLICATION > + pgd_t *pgd; > +#else > + union { > + pgd_t *pgd; > + pgd_t *pgd_numa[MAX_NUMNODES]; > + }; > +#endif Hmmm... This is adding the pgd pointers for all mm_structs. But we only need the numa pgs pointers for the init_mm. Can this be a separate variable? There are some architecures with larger number of nodes.