From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AEB9C433EF for ; Thu, 7 Apr 2022 18:45:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4D8D6B0071; Thu, 7 Apr 2022 14:45:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFCDD6B0073; Thu, 7 Apr 2022 14:45:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9EAE6B0074; Thu, 7 Apr 2022 14:45:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id BD3DA6B0071 for ; Thu, 7 Apr 2022 14:45:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8F27923153 for ; Thu, 7 Apr 2022 18:45:34 +0000 (UTC) X-FDA: 79330961388.03.061CBCA Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf22.hostedemail.com (Postfix) with ESMTP id 0A587C000B for ; Thu, 7 Apr 2022 18:45:33 +0000 (UTC) Received: by mail-io1-f46.google.com with SMTP id k25so7893940iok.8 for ; Thu, 07 Apr 2022 11:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6Ji4YlYFHVDR0gxdj/6jpb0FghGwzOywEFt8q/52gXM=; b=QqSdyP3Dq30pUUzEmwW5hyQ4pc+G9DSDB01FoJsLcJ8OLSMzmuJX66C7O08kVxI5GR GP47x+r279qwgojRznD4Ox6yInvx/ZYvGYeDOkdgkAcuFWBBJzjGCpxsvSmAO77Mabnv 2y/OMqdsdW1fDw1aqPJ9itZ4+RiSioZcqunX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6Ji4YlYFHVDR0gxdj/6jpb0FghGwzOywEFt8q/52gXM=; b=KcgYNXmjSI1viDZWN0EyQzduZtwlmYaVKophvBNSJGah2LKM7SWyb+cnAUb6OvFg0Y f1P4mtBSNf7ERCj8aCVTPzsaSlzT/z4z3WdQpOqTOTE9wu1Bhh1aDzhfwXn+r1rljKoY wPo70ZUr+mM3j40G8vcFowoLRXFvcqvzlbwR0OFJDgOUIxBJMJSk4BnzfaM+RWVeO9ed hrCOzp3wdXD5jAYhCFqiixlHrcMYa1NoZfgZT88h7jaKitw0etK7gfWN0ifo2DRa1Vnf fSuyntcO2fEF3uy1Z/bwgtifhzGeoCfH+bXFk5vb4cdA+HV51liieyJ452h4Dj4VRSu4 hSrw== X-Gm-Message-State: AOAM532V+54BnkmrQX+V/+069wPpZe8WmEFEowCb2s368UT8NUvC8PJ0 E4etP/E1wol2O8aLapHvPJLCsA== X-Google-Smtp-Source: ABdhPJwgU4mSkmGOP4lzd2vZXXDmbmz/CKWESrQlvZqHqyu743d967VGiNZihTjDEIKxeEg/WxKIQw== X-Received: by 2002:a05:6602:154d:b0:64c:5fab:4076 with SMTP id h13-20020a056602154d00b0064c5fab4076mr6828405iow.169.1649357133271; Thu, 07 Apr 2022 11:45:33 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id e18-20020a5d85d2000000b00649254a855fsm12811819ios.26.2022.04.07.11.45.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 11:45:32 -0700 (PDT) Subject: Re: [PATCH] userfaultfd/selftests: use swap() instead of open coding it To: Guo Zhengkui , Andrew Morton , Shuah Khan , "open list:MEMORY MANAGEMENT" , "open list:KERNEL SELFTEST FRAMEWORK" , open list Cc: zhengkui_guo@outlook.com, Shuah Khan References: <20220407123141.4998-1-guozhengkui@vivo.com> From: Shuah Khan Message-ID: <059030d7-657a-6403-ae75-3314f790afa3@linuxfoundation.org> Date: Thu, 7 Apr 2022 12:45:31 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220407123141.4998-1-guozhengkui@vivo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=QqSdyP3D; spf=pass (imf22.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.46 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0A587C000B X-Stat-Signature: 6fjssm16rhn6qb9p49qhawrndgfw3u51 X-HE-Tag: 1649357133-153750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/7/22 6:31 AM, Guo Zhengkui wrote: > Address the following coccicheck warning: > > tools/testing/selftests/vm/userfaultfd.c:1536:21-22: WARNING opportunity > for swap(). > tools/testing/selftests/vm/userfaultfd.c:1540:33-34: WARNING opportunity > for swap(). > > by using swap() for the swapping of variable values and drop > `tmp_area` that is not needed any more. > > `swap()` macro in userfaultfd.c is introduced in commit 681696862bc18 > ("selftests: vm: remove dependecy from internal kernel macros") > > It has been tested with gcc (Debian 8.3.0-6) 8.3.0. > > Signed-off-by: Guo Zhengkui Looks good. Reviewed-by: Shuah Khan thanks, -- Shuah