From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE33C4332F for ; Tue, 22 Nov 2022 15:21:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB5C46B0071; Tue, 22 Nov 2022 10:21:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E661B6B0073; Tue, 22 Nov 2022 10:21:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2D376B0074; Tue, 22 Nov 2022 10:21:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C151B6B0071 for ; Tue, 22 Nov 2022 10:21:42 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 71E27AB82A for ; Tue, 22 Nov 2022 15:21:42 +0000 (UTC) X-FDA: 80161442844.21.60307D8 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf06.hostedemail.com (Postfix) with ESMTP id B8E52180009 for ; Tue, 22 Nov 2022 15:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669130502; x=1700666502; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=7pZC/dz8/S5EuOYF3Mhliy+TJEj50Cth3ybWyWk6W2Q=; b=nGzkYxU1pdICWCFZQBM9PURqkaUXagJrKjAhil2toEwsIAxXDQYxsgc+ 5+sMrNEMatRJeFN2iKviuvi87LWE5FD783EAwUL/FJIY01BoFoa4bkYiJ KWfhM+CeH2dQRsXmCNh6xyGJeiDQoCyCRyweTCg7UuW7LB5iOWQvOsryn 8LsCurYgeWfQ5BMw87Meu/Ogw8frDF+B9AMHjJzhdUG2lwznJ7kEBhSvd 7DCnWXVX8E922SiJzG4SO2zTGotL+TGCTwn8OOgY+nIqQ0Gnkmf0n9eVP LLwp7gxqfXAJH0tJex2W8oLhYISs++dOzea5FrR2pn0bieB3YaxPe9fT2 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="375982344" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="375982344" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 07:20:31 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="783872775" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="783872775" Received: from lcano-mobl1.amr.corp.intel.com (HELO [10.255.231.75]) ([10.255.231.75]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 07:20:28 -0800 Message-ID: <058a6033-a5e0-771b-3c16-950fdbb8c1e5@intel.com> Date: Tue, 22 Nov 2022 07:20:28 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 06/20] x86/virt/tdx: Shut down TDX module in case of error Content-Language: en-US To: Peter Zijlstra , Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <48505089b645019a734d85c2c29f3c8ae2dbd6bd.1668988357.git.kai.huang@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669130502; a=rsa-sha256; cv=none; b=x4+bcNElJa7GD5ghWUomYICmkkcRUFGGYLuk3mon58JZD+t5MUm5BbnIJgdkRGbDgb+ExX q5Yr/7uhk4bCEjcSsp7nuAFj5h/XSudgDJQK3KXTnlbTPw6Eh3nsOL6cF18IMr08XUh+Mk hxhNKQc3NqRh9s1wuVnWddi7aX6ySqs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=nGzkYxU1; spf=pass (imf06.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669130502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tjc6Wa2J5uyfJysreZv34SSyM7pyO9IImkHg2zGmMhY=; b=4UEq/coxezLlghIh6/YcEFeXTfJwcaFhYeW+yP2ejDKLxdWeSXCksX03JceVn32bcKqmSd H7C0Uq38YRTxT90i13VSG4nbCRYyHb9uO6v1jsHNIM26IXlOO4U3zdwhSE+Hfu7GXpVHNu EWZNQ84cpoqX8ynsq3ddmZnuylWKfEQ= X-Rspam-User: X-Stat-Signature: 7z57d9gy5gz4zjpefskfrfds7yfyh6p7 X-Rspamd-Queue-Id: B8E52180009 Authentication-Results: imf06.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=nGzkYxU1; spf=pass (imf06.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam07 X-HE-Tag: 1669130501-296441 X-Bogosity: Ham, tests=bogofilter, spamicity=0.004774, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/22/22 01:20, Peter Zijlstra wrote: > Either the Changelog is broken or this TDX crud is worse crap than I > thought possible, because the only way to actually meet that requirement > as stated is stop_machine(). I think the changelog is broken. I don't see anything in the TDX module spec about "the SEMACALL can run concurrently on different CPUs". Shutdown, as far as I can tell, just requires that the shutdown seamcall be run once on each CPU. Concurrency and ordering don't seem to matter at all.