From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B2BD729EC for ; Fri, 29 Nov 2024 17:18:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C77A6B0085; Fri, 29 Nov 2024 12:18:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6771B6B0088; Fri, 29 Nov 2024 12:18:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EFD86B0089; Fri, 29 Nov 2024 12:18:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2C9A76B0085 for ; Fri, 29 Nov 2024 12:18:10 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AE5BA1A13DD for ; Fri, 29 Nov 2024 17:18:09 +0000 (UTC) X-FDA: 82839790530.18.E20E4BE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id B724C40011 for ; Fri, 29 Nov 2024 17:18:00 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RMiSqvZZ; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732900681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YDSw2N6tRHEf0H9cdmSI/du2PHK8t8XyQReZsHleBzc=; b=3w9Xuz9erPLi9mpISql4TIEaf7t1ZdRRZMgrhsIyucJiMpWdLPn1tDOESwGcXaSk08acVZ oeTk2mDubtgj4OO2jY5O34TUYNSd8WGG22Sq1AyZGNImpJC8YVTGYGt/f3mPRWKCqX4dJX XLmlFOjksSHNd9eJ+SLMQ71zUDW/7YY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RMiSqvZZ; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732900681; a=rsa-sha256; cv=none; b=C4R9xvrS2FwofeefumHP3B7w7AA78rTneWrLVjU+L9kmLdxCcmTKZg7erUYPX+EUXQOVW2 AS+Gylgr3wR6hatcFOf94GvCbxoWrOCHQe66o9fjFYW4/FnQlsBZVCzn+cTpQn2p/YT31Z e2IwP8z4r4BdIpEsASnlLwoLWQ77NTA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732900686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YDSw2N6tRHEf0H9cdmSI/du2PHK8t8XyQReZsHleBzc=; b=RMiSqvZZoyrT17kdVmJnnmEEj+rWTYySi4Dtd4lvPs7uAl3mCnXlOyRXsTG1kG1o/nNL9N bEGfZOAZzij5aAfBoAQJ8eXzDur9QSXaxPOl6pnPO+/uZQdCtRtNWk3DV6N5ZRz/thPuRd I1gSvNsd+bslgJUekS5xGGYNpLwPa1A= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-Ub6KGKyTPrqVljNrtSCH6g-1; Fri, 29 Nov 2024 12:18:05 -0500 X-MC-Unique: Ub6KGKyTPrqVljNrtSCH6g-1 X-Mimecast-MFC-AGG-ID: Ub6KGKyTPrqVljNrtSCH6g Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385dcadffebso557253f8f.0 for ; Fri, 29 Nov 2024 09:18:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732900684; x=1733505484; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YDSw2N6tRHEf0H9cdmSI/du2PHK8t8XyQReZsHleBzc=; b=nGL6+zp4+nJnnqbQaN+O+03FTeTxla4MRSYGcCmlRxvt3Zpk9/gbcnlXV2aPbA11wW 71FXLp4G3Hubh1x2bsi4AIiRTU0K2G0zL0vz4m3CcnE/WqYMUD+X/Ysjl4hQ+nIenxN3 whmitpWGWVMegSAl1Zl8KPVQOJ7S9vtwIyQKV9ySLWEocaWLVPKaoYjDc9M1NueutI+Q bC3xGJAwfk0rwyo1fD249DV2Pho0gueZL+63dd/KwKloP0mGrJEsGeWRZaDXouUpUzGt hhgjRb7UaSozXh5aZEekne+C9eSPlXo18VcYVj0fEOcfTM69hcyv6sppWv13W0HNahtx zamA== X-Forwarded-Encrypted: i=1; AJvYcCXPGwuuDdlp656aiw33mlcgtdXZZNN4MHSRpoAXwf+7ve62qTQKjwMN1tJb1+VhJIxYiiTQ8OsCxg==@kvack.org X-Gm-Message-State: AOJu0YwhEwJjvmU8Z+90h1gEJ1PFs+h/rm4wJ/LOLRU2vASoDMo/SDwl ejXX+4kXqezbXcUhLWL5hth2uBKoPMoqVhLrrZ5mWPyg+r6LQ84c6+zOltm91BpMR8TAUPBPrAw 3+T5iiiy3bRIbJESbxMe1oTY5HifLLGJG05UegkLB3OjK3EqV X-Gm-Gg: ASbGnctObsgbnxN/O/Uf/9TG1R//dM7RYZxt/VpDvQIfSS9uKpz7QVhRaboZjV6SNjo KY+iZhKk6FH3Rdq+pFDS6ds3b82cRvWrK5/Ap0Q6m2+38gmQ6K1cw3OLfgCD/B5f/UiZeA43QdF NYdF8bSJDBoi6iIp2+hPmeQyUWeyIi+tserhjCoz0Enda845rVJSSpbTSSfo9XJH1o5jj/+JJLf /CMYjfRxYadv+fTHy9Nx46LrQ9kD4s1cb/tMSbAHfiTq7psx03idbaw3t+9KupWjnYw6alLyPu5 3bqlQi7N3dzCktYyNI8HrSIi7dZTBaWslt49cAhEidWZA2zqvs4vaqOVAfdm6q7i+qE7pBG38zH bRA== X-Received: by 2002:a05:6000:1fac:b0:382:4926:98fa with SMTP id ffacd0b85a97d-385c6eddc05mr12473070f8f.40.1732900683861; Fri, 29 Nov 2024 09:18:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6RAlKNAxyqJaOhXFo9z6UQoC23gdtqo33cBotl5Mj35IGJJNf+k+yZz3Jg4lkppKHosCF/w== X-Received: by 2002:a05:6000:1fac:b0:382:4926:98fa with SMTP id ffacd0b85a97d-385c6eddc05mr12473025f8f.40.1732900683412; Fri, 29 Nov 2024 09:18:03 -0800 (PST) Received: from ?IPV6:2003:cb:c723:5700:2c79:e2af:8108:4d68? (p200300cbc72357002c79e2af81084d68.dip0.t-ipconnect.de. [2003:cb:c723:5700:2c79:e2af:8108:4d68]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385d33a13adsm4090027f8f.73.2024.11.29.09.18.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Nov 2024 09:18:02 -0800 (PST) Message-ID: <0583ccce-538c-4291-89e8-2e0223b2c7fa@redhat.com> Date: Fri, 29 Nov 2024 18:18:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/15] mm/mempolicy: Add alloc_frozen_pages() To: Zi Yan Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , linux-mm@kvack.org, William Kucharski References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-15-willy@infradead.org> <2A0E6E69-5765-411C-8667-C49A2392F10F@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2A0E6E69-5765-411C-8667-C49A2392F10F@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wigk3J_GrtP3ya_JQE6Sis1t7rnhqd8A86IWcF5lHqk_1732900684 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: g8fa64g7kjy1rwkpyta6c3fujyit43y7 X-Rspamd-Queue-Id: B724C40011 X-Rspam-User: X-HE-Tag: 1732900680-272371 X-HE-Meta: U2FsdGVkX1/H6nbgVDG3azMGz0mQ9E+mOilIhGjMK8SPykoPquSO7zG6+6iD+spKud3nxY3DTaNHvV8I2Wbw3jxbdd5hMfd2GJbiIZLET5H2/NUEbG6e7WgPHajV08FcB7lDR+7vdYLdWkKUTItbB6D8Ga+FKpRHbpOKXFXTTJbAfTCzb+XYhya0yNby8Hhj05P51grwATmI1YMgI6akTvtBJw9CK+KY/bfvEl6ochBQ8y4hqkrwIIYdCoYgQjqGYWi+grAiqh5MluQwoWm5ErWi5xkGwFer+iy11I6aLCIwlgXeaXYTsn6FCCYWGui7Cf6/gb691iNdq9MAT87mRuwEJMOg8c/J9uCSSl7gF+oW+8jRGn4kmPmkmPjvi6zvy52crPkn++bjlm5U5k0TxIYCbYmbrJ8FhYCd6QcgA2A8RH7faoUKIHeD039gFerqV/Ee9v+XQmmP0aEFCRjKa+KfEjy3PAQs0FOlIkUbwVuSJTTNqumUJIabOD/t5rNJ4L2BstbKuJ404bkLqZBRLCr8mUSd7xfCZlXwk+6PcZ2acuAqC6Y5qy0f8EU+NDDzltvFSyQDCqQ7VsrovF4IsGLcyD+mZ6Aw5l66MhnuwAg92n22c163d2b0JWr4txffKJFFnOeA2C5qx6WqEYc9dkYkaR4GEez9hqbIWwOvxpDt1aG+/GIj52XID3ykwn9dj/qLufbfI2abRFdlmJU359tKZ2yHLvnHzFpwK5tQZSdLL/AYWC1QeneVLlPdlMFUYNc2dZoKn0Ii60jn+Pad+mhT0uZ2TqSOi+a1NjGdPmWWPcU/uwvF8hCrErbhm2mxCmPzIlxRt2qXH1rhDyVU7eD5MKz041m3i4Iv2lKqnlae/gRehVZM43fSDNfDFybxH0UvBno2uXOFQph75DJduBUKS5YSjzMXDh40+cXTeCcTkRs8ynrk5RGEbMbRUoh+hbjDs90jG8L6RRD45Xq zeEbXTbL szYN8xZVXoRay9UVRkcF2rE4emJSQBL4AX+W3DWpkBPIRZxV40y7gpc9vAJtw27N85K8QHUYxJPYNK8Xf/FNAt+XiKIqvqe+IM7xU2OTJ9XhaRsBb0M+WzSV/0NToVLGmWzsCzGMQ/0b/49cugtIHQ9TiSY3r6rTd0yRMx7eHNO1itbUM8qqpDvB39JU2g+r953894CrijM8hDFVZA7flsih7vPbRNEKsQMhwjwmEZIaA/vG8uzO0Nd0/Z2GMLlEMkOaWqiP9iR0RDRtLKwi0XWtuUCN4G234bc9FqYLTcPaP1L6T0BxDQ3xSCXAfiK3wEvMZbiIBU1k8MML4S1uW267NxEanvfmKk5fT0RyeY9PRYiZdmAeBL5J+/8d6poXikgMBjzefab9+nbL9agzDpA8KRoq49ty7Z7eD+gVxVKN4YURAYWaikRpWqiEmmjiK9qSvBHPViGzPJb5YG96kcHpyTwvw4Y0c1nN1XFBVh8+zNUsAt8TFMt5z2Rg/G8BD6zxEE5POXzFgqp/No9gxDFaLmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.11.24 17:29, Zi Yan wrote: > On 29 Nov 2024, at 9:44, David Hildenbrand wrote: > >> On 25.11.24 22:01, Matthew Wilcox (Oracle) wrote: >>> Provide an interface to allocate pages from the page allocator without >>> incrementing their refcount. This saves an atomic operation on free, >>> which may be beneficial to some users (eg slab). >>> >>> Reviewed-by: William Kucharski >>> Signed-off-by: Matthew Wilcox (Oracle) >>> --- >>> mm/internal.h | 12 ++++++++++++ >>> mm/mempolicy.c | 49 ++++++++++++++++++++++++++++++++----------------- >>> 2 files changed, 44 insertions(+), 17 deletions(-) >>> >>> diff --git a/mm/internal.h b/mm/internal.h >>> index 55e03f8f41d9..74713b44bedb 100644 >>> --- a/mm/internal.h >>> +++ b/mm/internal.h >>> @@ -747,6 +747,18 @@ struct page *__alloc_frozen_pages_noprof(gfp_t, unsigned int order, int nid, >>> void free_frozen_pages(struct page *page, unsigned int order); >>> void free_unref_folios(struct folio_batch *fbatch); >>> +#ifdef CONFIG_NUMA >>> +struct page *alloc_frozen_pages_noprof(gfp_t, unsigned int order); >>> +#else >>> +static inline struct page *alloc_frozen_pages_noprof(gfp_t gfp, unsigned int order) >>> +{ >>> + return __alloc_frozen_pages_noprof(gfp, order, numa_node_id(), NULL); >>> +} >>> +#endif >>> + >>> +#define alloc_frozen_pages(...) \ >>> + alloc_hooks(alloc_frozen_pages_noprof(__VA_ARGS__)) >>> + >>> extern void zone_pcp_reset(struct zone *zone); >>> extern void zone_pcp_disable(struct zone *zone); >>> extern void zone_pcp_enable(struct zone *zone); >>> diff --git a/mm/mempolicy.c b/mm/mempolicy.c >>> index cda5f56085e6..3682184993dd 100644 >>> --- a/mm/mempolicy.c >>> +++ b/mm/mempolicy.c >>> @@ -2201,9 +2201,9 @@ static struct page *alloc_pages_preferred_many(gfp_t gfp, unsigned int order, >>> */ >>> preferred_gfp = gfp | __GFP_NOWARN; >>> preferred_gfp &= ~(__GFP_DIRECT_RECLAIM | __GFP_NOFAIL); >>> - page = __alloc_pages_noprof(preferred_gfp, order, nid, nodemask); >>> + page = __alloc_frozen_pages_noprof(preferred_gfp, order, nid, nodemask); >>> if (!page) >>> - page = __alloc_pages_noprof(gfp, order, nid, NULL); >>> + page = __alloc_frozen_pages_noprof(gfp, order, nid, NULL); >>> return page; >>> } >>> @@ -2249,8 +2249,9 @@ static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order, >>> * First, try to allocate THP only on local node, but >>> * don't reclaim unnecessarily, just compact. >>> */ >>> - page = __alloc_pages_node_noprof(nid, >>> - gfp | __GFP_THISNODE | __GFP_NORETRY, order); >>> + page = __alloc_frozen_pages_noprof( >>> + gfp | __GFP_THISNODE | __GFP_NORETRY, order, >>> + nid, NULL); >>> if (page || !(gfp & __GFP_DIRECT_RECLAIM)) >>> return page; >>> /* >>> @@ -2262,7 +2263,7 @@ static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order, >>> } >>> } >>> - page = __alloc_pages_noprof(gfp, order, nid, nodemask); >>> + page = __alloc_frozen_pages_noprof(gfp, order, nid, nodemask); >>> if (unlikely(pol->mode == MPOL_INTERLEAVE) && page) { >>> /* skip NUMA_INTERLEAVE_HIT update if numa stats is disabled */ >>> @@ -2280,8 +2281,13 @@ static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order, >>> struct folio *folio_alloc_mpol_noprof(gfp_t gfp, unsigned int order, >>> struct mempolicy *pol, pgoff_t ilx, int nid) >>> { >>> - return page_rmappable_folio(alloc_pages_mpol(gfp | __GFP_COMP, >>> - order, pol, ilx, nid)); >>> + struct page *page = alloc_pages_mpol(gfp | __GFP_COMP, order, pol, >>> + ilx, nid); >>> + if (!page) >>> + return NULL; >>> + >>> + set_page_refcounted(page); >>> + return page_rmappable_folio(page); >> >> What I don't quite like is that we now have a bit of an inconsistency, that makes it harder to understand what gives you frozen and what doesn't give you frozen pages. >> >> alloc_pages(): non-frozen/refcounted >> alloc_frozen_pages(): frozen >> folio_alloc_mpol_noprof(): non-frozen/refcounted >> alloc_pages_mpol(): ... frozen pages? >> >> >> Ideally, it would be "alloc_pages": non-frozen, "alloc_frozen_pages": frozen. >> >> The same concern applies to other internal functions, like "__alloc_pages_cpuset_fallback". > > Or all internal functions (with "__" prefix) give frozen pages and external > ones give non-frozen ones, unless with frozen in its name, i.e., alloc_frozen_pages()? If we go that path, we should make it consistent for __free_pages() as well I am afraid. -- Cheers, David / dhildenb