From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mm: Move recent_rotated pages calculation to shrink_inactive_list()
Date: Thu, 14 Feb 2019 13:19:30 +0300 [thread overview]
Message-ID: <057454bf-5f49-2043-9197-68f99a0501a4@virtuozzo.com> (raw)
In-Reply-To: <20190213173327.uhexilxmmztx7fbt@ca-dmjordan1.us.oracle.com>
On 13.02.2019 20:33, Daniel Jordan wrote:
> On Tue, Feb 12, 2019 at 06:14:00PM +0300, Kirill Tkhai wrote:
>> Currently, struct reclaim_stat::nr_activate is a local variable,
>> used only in shrink_page_list(). This patch introduces another
>> local variable pgactivate to use instead of it, and reuses
>> nr_activate to account number of active pages.
>>
>> Note, that we need nr_activate to be an array, since type of page
>> may change during shrink_page_list() (see ClearPageSwapBacked()).
>>
>> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
>> ---
>> include/linux/vmstat.h | 2 +-
>> mm/vmscan.c | 15 +++++++--------
>
> include/trace/events/vmscan.h needs to account for the array-ification of
> nr_activate too.
Yeah, thanks.
next prev parent reply other threads:[~2019-02-14 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 15:13 [PATCH 0/4] mm: Generalize putback functions Kirill Tkhai
2019-02-12 15:14 ` [PATCH 1/4] mm: Move recent_rotated pages calculation to shrink_inactive_list() Kirill Tkhai
2019-02-13 17:33 ` Daniel Jordan
2019-02-14 10:19 ` Kirill Tkhai [this message]
2019-02-12 15:14 ` [PATCH 2/4] mm: Move nr_deactivate accounting to shrink_active_list() Kirill Tkhai
2019-02-13 19:13 ` Daniel Jordan
2019-02-14 10:30 ` Kirill Tkhai
2019-02-12 15:14 ` [PATCH 3/4] mm: Remove pages_to_free argument of move_active_pages_to_lru() Kirill Tkhai
2019-02-13 19:14 ` Daniel Jordan
2019-02-14 10:36 ` Kirill Tkhai
2019-02-12 15:14 ` [PATCH 4/4] mm: Generalize putback scan functions Kirill Tkhai
2019-02-13 19:20 ` Daniel Jordan
2019-02-14 10:29 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=057454bf-5f49-2043-9197-68f99a0501a4@virtuozzo.com \
--to=ktkhai@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox