From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C77F4C38142 for ; Tue, 31 Jan 2023 15:48:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE40A6B0071; Tue, 31 Jan 2023 10:48:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E943A6B0072; Tue, 31 Jan 2023 10:48:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5BBE6B0074; Tue, 31 Jan 2023 10:48:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C823C6B0071 for ; Tue, 31 Jan 2023 10:48:44 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5966A80191 for ; Tue, 31 Jan 2023 15:48:44 +0000 (UTC) X-FDA: 80415526968.29.28692CC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 3AAE116001F for ; Tue, 31 Jan 2023 15:48:41 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PYqP9b4P; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675180121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AuMUrfZRtvlkmAFqawT/rQRdhoiPDUHnVA5JYzWI9R4=; b=LkQ3qsGOa2ipBIPw51lkERjQmNSXdEqrNyc2xGPBGX4bAN2W4MNeMvfMAi9i9sBuFQwIOe bGydhiZPBm+TcjirVpbCjwTJevhvOm714nrOYdaUMikWuPuoy+TZcbOFcbSn9HToI9oie5 runqqTLHmFgcxSDD2OcZotN4Fkp7E4g= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PYqP9b4P; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675180121; a=rsa-sha256; cv=none; b=C1ZtY27UQvoOlAu9e4etY5SAKEdjnovHmuLqRdMrNzlV1dQLWF3zShW4rjgKEj+RueOv5w V7Jw9z7hjvlqL5+5ZQYVJ8fwpoKdYBtgzLMDJXp7bvfU3giNcm95VWPbBbp/3M46hDNlGl WucTrhWN7U1Ee8GzToEvJCcZrb5ymo0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675180120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AuMUrfZRtvlkmAFqawT/rQRdhoiPDUHnVA5JYzWI9R4=; b=PYqP9b4PpsaKY8VJE2/zMEtwnTJwUZ7ReIw29xP+KnOq+MSWS4f6HjIEpUeUpARrbFKhAi iwesP8I3pmHsUlJTUAQ3B9Dmv6zyGRujhoer3BUl4UJjseiUmrqRMZDgHJhn0v61Na2/tV o+2rPMAp6AYtjncXDGJvq9cRakh7C34= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-556-qX59WHKQN4uEbeLxYjV7Pg-1; Tue, 31 Jan 2023 10:48:39 -0500 X-MC-Unique: qX59WHKQN4uEbeLxYjV7Pg-1 Received: by mail-wm1-f69.google.com with SMTP id j24-20020a05600c1c1800b003dc4480f7bdso6482789wms.5 for ; Tue, 31 Jan 2023 07:48:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AuMUrfZRtvlkmAFqawT/rQRdhoiPDUHnVA5JYzWI9R4=; b=RGKCv22YSvPyXwvKicoEnCR3/oxS5u0R5k5d0/Io/joYSUnIpJ3DspqA7KDSvtAl8b rZGjNolFnQUu8TuDDaP3LLV0tbLvMt/w4TX/5hqBYPGs/1yjOI6QI2V6pm/Uap3PmUf6 yrp/DDdMcwoyo5AjJaeHDjckRULtq2uH1fM6WkR3xeio9JLWxMcDCpUl9BkF2fdlT7ZJ NFGvSSNNtD3+6O1pIl/TBC3tPOSMyvkljwnLM7/9aSAXhNh5xim4bQaFVWOpTtpy/Pxt CIsCISfmE3tFmRTmDBPYiqHc9gYt9ZWNdYFtYriynvQw+HxQH1w6zzDbKJifmCK8VtWl 7dIw== X-Gm-Message-State: AO0yUKVqhFLwAVt53ojYK8U/2k+aRJrMSZjn29OC4gSVTto8t/cIevB/ tg0z75aD3T8XbYZ1+aY2eNm81SuJTcM7ibr3KGbs6P7ys/Y5s4OGQlRxPqiHA+joYJKP0HN6jiE 1Vbb9BvXU3L4= X-Received: by 2002:a05:600c:34c5:b0:3dc:4b87:a570 with SMTP id d5-20020a05600c34c500b003dc4b87a570mr12905666wmq.35.1675180117985; Tue, 31 Jan 2023 07:48:37 -0800 (PST) X-Google-Smtp-Source: AK7set8kopvgornNa/3eCsVmMH6PQqtvbGhtwEQ6BLZLQ9Q8wQrLpxLNtEK3uRU/nyy7bunIPWt9Uw== X-Received: by 2002:a05:600c:34c5:b0:3dc:4b87:a570 with SMTP id d5-20020a05600c34c500b003dc4b87a570mr12905646wmq.35.1675180117733; Tue, 31 Jan 2023 07:48:37 -0800 (PST) Received: from ?IPV6:2003:d8:2f0a:ca00:f74f:2017:1617:3ec3? (p200300d82f0aca00f74f201716173ec3.dip0.t-ipconnect.de. [2003:d8:2f0a:ca00:f74f:2017:1617:3ec3]) by smtp.gmail.com with ESMTPSA id l35-20020a05600c1d2300b003dd1bd0b915sm3722974wms.22.2023.01.31.07.48.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 07:48:37 -0800 (PST) Message-ID: <057142a9-b190-905a-5539-02d9d8a5d26e@redhat.com> Date: Tue, 31 Jan 2023 16:48:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] mm: move FOLL_PIN debug accounting under CONFIG_DEBUG_VM To: Jens Axboe , David Howells Cc: Linux-MM , "linux-block@vger.kernel.org" , John Hubbard References: <54b0b07a-c178-9ffe-b5af-088f3c21696c@kernel.dk> From: David Hildenbrand Organization: Red Hat In-Reply-To: <54b0b07a-c178-9ffe-b5af-088f3c21696c@kernel.dk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3AAE116001F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ct116qjb44wzjfoa1zpaurjphjxf7ie5 X-HE-Tag: 1675180121-259550 X-HE-Meta: U2FsdGVkX193d30bFpfOhrApMiAoCzAcu/T0nCeyaTIsNKG0OBADJumCCKGH5+qTGslpSEtmoEmzoCO5/wGhk/FD6nolpTw4yWZ4k+LTWpPenTnrhQS4bDlLFvRUNFcYeZxLfnXy7tbYB6Sg+W46p8ojyNuR70srIup8OXIXsAIwuk5qbCbrXRW1rQoagGON/Nu72AsJsf+NuSNdnjyeTLGgorAx1u6qemB3gBc8i4+pbtX4qSbAxzt5IIORms0MgFLCZb3zK8wfA9V0KdvsVY3+Td5xRyhv7omX36/IQBCdf/sKHnS3zaY1hKqS13Zy1Zls8AHj7ePFWH5/JfvFWCBjy1y7Ix/XhsCjAgwVie1xZKcogWVPGNJngJZS4uRBanpy0yInYLDPsG3yidU/vGxFsBaHQDfBChnQUz+Cs7LUF+ng6VH1lH5OXPHwtfoNX0yoH/BH+a3jKHcqcxUsSaQxv+eTE+oXTFub9zo1ShmIaOSg1CGmvcYUJ7FB2Zy4xOsA1mhPQNp9+rGWcYl8/mK7iWjmhy/6z/o7UnNMwkfhy6sys7FhQ7eI7R9eC0cCjoUWqOvKsReN9/QyjkQ2UVnMiZLhi9Z7pdC1/SCNj4Uz47ugVQHPu8YyA1iB1DhNsRa13IkEb/T3XgeH76sAWurhu21FkNuJoYkEAohS33hN8fJWNw/kdP8TWU4CYorIlr9IvFxOclI++vo8vb1Llp31Bo0xEc/BXVSGMrDYvh5AigwbxFcD3d4UGNXwQgZfjrD9sUGXD1g/etDpanHHV2nlYhhL0D3o8QnbzZBPtEsE9Oz1KO7m0GaYu+Kl6lfX0hz4dhkYGMHV/u21twLVvc5uL2cPfrbjIZ314pcm6BMWCdJZY8HRjz/y6h1nPkzbrSDyA0fqbYK+3EHnDifJRp9u3iwW5i23nOqRB4IDUBsM+kkuVxZ2hBfhdLRXXwopyDpJM3bK/oVNs4vkF/B 8n6Rccbo fNzWLGnXS1iqH6OHxNlP1hQ8BBfqATiFhDo62MEIqdosv+NAoi9RAFsGzMH6YuZbP9doADpkDDV3nvC+3CPiQgxmQKh6ADcQcWynxIlZ2bA+aUZIlFXo6zNLHF+0+Mp0PqExiFjeusrANm1M57rQC9kp8RP4GhJqt4nMR0A6ZPLmCh7L2eaJjNsmwZejfYqZJP/Ngg2x5NfnPsZ7IDl8vs1jzOtmVa2fvXWEtf6wOMTixhhjZ7I4dt6VVxSQAqPklj+aLqjfCHtbZ8uvMnqKGcjWJo2YvuOy5pk5zTfrHbPbupE5ebSe+Dd2yk297Kkf1OuCHtKIqTshCytP8yy9p6hqkIZhycx9xb99GPmRUFOQCm4/fYxXufgm24FcceSCuYix6QFzd1in5T/QccaTk6EzJc0dPNUyNeLRrC8/1wkA4NT9m4a9xTG4JwG7yOOpl/gbPw05oG1p0u3tCLAWl6M6Anx6zd/R5QRX7NXZ/jfWFs8Y+1kQx2+nQ3Af+OdTWKsaTyx+YGOzrCLwfC9pkxAAWoEgtTnra1wTTMX/6YfpNccJpzr5Y9hzpjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.01.23 16:36, Jens Axboe wrote: > Using FOLL_PIN for mapping user pages caused a performance regression of > about 2.7%. Looking at profiles, we see: > > +2.71% [kernel.vmlinux] [k] mod_node_page_state > > which wasn't there before. The node page state counters are percpu, but > with a very low threshold. On my setup, every 108th update ends up > needing to punt to two atomic_lond_add()'s, which is causing this above > regression. > > As these counters are purely for debug purposes, move them under > CONFIG_DEBUG_VM rather than do them unconditionally. > > Fixes: fd20d0c1852e ("block: convert bio_map_user_iov to use iov_iter_extract_pages") > Fixes: 920756a3306a ("block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages") > Link: https://lore.kernel.org/linux-block/f57ee72f-38e9-6afa-182f-2794638eadcb@kernel.dk/ > Signed-off-by: Jens Axboe > > --- > > I added fixes tags, even though it's not a strict fix for this commits. > But it does fix a performance regression introduced by those commits. > It's a useful hint for backporting. I'd just mention them in the commit log instead, but I don't particularly care here as long as the commit ID's are stable. If still possible, I'd include this as a preparational change for these commits instead. Anyhow Acked-by: David Hildenbrand -- Thanks, David / dhildenb