From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B2C5CF9C6B for ; Tue, 24 Sep 2024 20:11:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A1036B00AB; Tue, 24 Sep 2024 16:11:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 029CF6B00AC; Tue, 24 Sep 2024 16:10:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D96C36B00AD; Tue, 24 Sep 2024 16:10:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B399F6B00AB for ; Tue, 24 Sep 2024 16:10:59 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 290A91C527D for ; Tue, 24 Sep 2024 20:10:59 +0000 (UTC) X-FDA: 82600725438.16.6A7164F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id E782B160019 for ; Tue, 24 Sep 2024 20:10:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LV3nvds+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727208525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oSLm4Kl8UBZcqRPKiEhKkXlXaEuga8M/MvmM/NauC6M=; b=3sosLr887JLqxLssw5USDJIi6NnK+IaEkhdBcc+RlHImPi0YiKRjCb8vLXjZjI5nCiQgue aaSXB4Y79SJ5prMtVdY7CAHzlVpNoMGSJIg5iMKgl/lUa7EX26UtFIm2tFlS01DxLDXEwm VHRSLwVovo+VS8AAGXCVhd9d1bL0Hic= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727208525; a=rsa-sha256; cv=none; b=ITQYH1KEbMDc8AQFxWLceNQnYV3aCEjpbhkekG1JQ7Ioiy2JD5+d5Ul2Pf7ZkB6zhXgxro Jkap4E3YG4GFJv9j3ukY1yKzJSsBxbUEZkbMD2Vw1ol7qKeClbsv20wdnxJiK31RufKXn4 BlOLKRe6GDnfCZDQujDTQNYZ3oGjC5o= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LV3nvds+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727208656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oSLm4Kl8UBZcqRPKiEhKkXlXaEuga8M/MvmM/NauC6M=; b=LV3nvds+5t1nQ9RsoDVWInfmMTO9fpk3ELq4c+qdQGZr3YCxYSiBlNtuMtUmmTE1wdt0tF xZz3Sj3RbV4jvjKXpgwKKcohG8ruh0zkwIIx34TgK3J4N3/5zgQTbjs5MSximzcxp1YoQ0 a5U20H2QTa+so3HNACwKsR4ET/0UxFg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-A9_d_--UNAqgnFLIrZdZuw-1; Tue, 24 Sep 2024 16:10:54 -0400 X-MC-Unique: A9_d_--UNAqgnFLIrZdZuw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42cb89fbb8cso39571495e9.0 for ; Tue, 24 Sep 2024 13:10:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727208653; x=1727813453; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oSLm4Kl8UBZcqRPKiEhKkXlXaEuga8M/MvmM/NauC6M=; b=pjWaqpVBEvuGkz6EMWwgjdTAg1FNgO68wNvzPng4y2tyfAT9he5Xt5wqSzdDZmGEL0 Rt7cYAKEcUof0ZF654IFdzc3pcTyJgVh8JJx93fHMqtcAtNesoUi1YgNkKDRIzHhFQyY OJTaygysfdH7yqqWitWNvy34dADzfvDacxLW4ddUWCYQcm2cJtgv0kc8jOhQZjyy/NwB Awxq3Oy7S0moXAJCRLgTdyRFByhWc9Y66ZJ7GYdWFYD2RuHkAy5gUg62nnvQUdDCDhH/ nHr1hpc7rqcC+v/Tv6G0nRh1LHG8dAFv7LSuiucDRW8j2DXkxUhVPV5D3DpLMacK2mKq 6S+w== X-Gm-Message-State: AOJu0YzFJk57v3oyq0voz8f6opl/SvokGkuw41TUa0mjQ1lW8sonpOBZ 1HnSCtOgYmJ8ABGSRT9nnXEvS6BhUgLdJ2b9ejcEFgHSu0PCc0t7h/0k5Xfsut4hmeUhrZHLdKl YenYNqtidOwB/n4guSdKXEUUMWAMazsO8IrgOdRoKGyhJOrGNs7CyaRq5iGg= X-Received: by 2002:a05:600c:348e:b0:42b:a88f:f872 with SMTP id 5b1f17b1804b1-42e96248f96mr1623345e9.32.1727208653305; Tue, 24 Sep 2024 13:10:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXXi6Pvc0wS7aYEcHiW7TC+6GNRfttgfcykmeGusFirCpPxaFD8GgM9jJ5qWMnVfdW9Dr2LA== X-Received: by 2002:a05:600c:348e:b0:42b:a88f:f872 with SMTP id 5b1f17b1804b1-42e96248f96mr1623225e9.32.1727208652875; Tue, 24 Sep 2024 13:10:52 -0700 (PDT) Received: from [10.1.26.69] (ip-185-104-138-71.ptr.icomera.net. [185.104.138.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2f976esm2348031f8f.69.2024.09.24.13.10.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2024 13:10:52 -0700 (PDT) Message-ID: <05549846-d813-44ad-966e-e42001570d0e@redhat.com> Date: Tue, 24 Sep 2024 22:10:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: Make SPLIT_PTE_PTLOCKS depend on SMP To: Guenter Roeck , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven References: <20240924154205.1491376-1-linux@roeck-us.net> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240924154205.1491376-1-linux@roeck-us.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E782B160019 X-Stat-Signature: mmmzinten9d6gg6iiim5h67pn8nedzjn X-Rspam-User: X-HE-Tag: 1727208656-570126 X-HE-Meta: U2FsdGVkX186ot/UwjxciFxz7yCNAbUI4pQdRtoqdYhaVgnXeHpB8JVdFv63GCKoLHsFDBrITGcwdpJJsG4Jl7+sho3v6UisSCLs8tcA09BnJBLevVFslDGWQG40ETjKNBm5Z9kM5Pvushk/gcsGrPdlmmtjKvOeFK3HcLp9K3mZ/y6CebNhf776PvJ/rl7Ex7vLdYnTfs/1gzZD1Zl4ZUEmaOySlEbFVeGLp9cahwEKsxhrLAqQxmdcD2d0soXhBSRGX+sdy3sUfRUrrme7lHnnYnVYkx9ZzrIHgT1HEmiA0W5JqFzTyl/PDWv3RBVGWqufohOSyWmMWKq0t0j8YacE2Cc4j4MeOSbaTUSjsEVQnvyE65wOU6oYczYULXiN3LerOWWk8joNIh+V/dGvSTlhdpiE9I/mT5tx+UPosHjlsUrHAaCOYtfOitnYs1Xwoj+IpynnfsUc05XM73fvibRsE9sDQL1YWFrC4yMir0w9yZVExSNXb0EsqmdzeXa5jxogmjKQ0OCPJn4KCyVIyAaVSZsYhgEwH90QShPuzwYKG7MPB28iK3BDKesVgm7SJh82ph7y6tOLScRtduduaVkIFlacY2iu+67sWZ629LBXkjI+rVDOXbolVJgGkCkGOdhaEMAOnJqsd6hEy9FdLhWDfGdqHIlex8/y1Hke3K8cxChw1C9VZawd5jJWSUIMhCTjOohprfD3CB7d42wEngVOSYQUxCfYsURW4rrGpTnjVPe72Ohhq7AWBAGMDhekf+zjpQEuOn+7R4y1k/UrjX1yPlB4hCR521TuBy4p+z+7AY/L5yzlsAHfVBG+0k1Ym3H9MBN5GgAcU5hGCEFgzYggevhCDF46wOXV6udcieIGr7/lodUBabOb/g2suQHcPSNyYPExfDLj/U+gkHc8DObvVyeaLCf3crtIwKxQZrnXaMZOfNNXAVZ9VsmpYwTMP2YHjku78v7sVu/GkRx lIWO7gkV yFOu85I573+dHbIdB7nEHbC+WPkHFZtwou0KfTkIywo+oY5m9TNkv6AnPURuHDPw/+lltpd/RpE9NqfUZUUhIscySSXkvVmgcnS+BgyfDnLcTNedMA3XJdcWyucfnqEMLE8g+Ot0b/1SpqxmnkCP7VMPTj2D1BarH4RI7EjAScIRi6rKwk2UgcANNdjfTLfLbvCql+XZkN204dVz4YLbhZrGYxzLZ8vArrvKeOmT+D2H3c8fGOzi/vC8GXlXyfsOGC5ZpxY05jtl158mw4Kv19tgV/mBSVRitnMfBfQ/+uhIWTAs24DwrPC6evIQcZHBYkqsn47K7iQh3S6rJAyqmtq/BPV7N0sh4F4GfHKSZz3/nx/84au5HWl/Oq0qpOr0Ux+iWezGZclD31TtMGIiGbWnMfK9ig6q+Re01DwqbpvI3TJrBZAHQQB2wy7qAY16PmeMxiEd3FsCMaI+1Tj3Zx57jElswrz3DtSnmu0t1C9iZtHvCj89wzJlsyvaG+PG6HW+y31ePEC2J0M2mrHe9OCNpbADrlj1nnR6XsaHiihjv/a7f0y+rXXAVeCZD25uJOjBJNx6iFjqxVCfTjSui2tY1QMJ9RL5PF+9lekwGKTqd9Ts3IsW0wi+x7HXjmrnyFT/qtPjlKCc8xjCt+nzclgitmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.09.24 17:42, Guenter Roeck wrote: > SPLIT_PTE_PTLOCKS depends on "NR_CPUS >= 4". Unfortunately, that evaluates > to true if there is no NR_CPUS configuration option. This results in > CONFIG_SPLIT_PTE_PTLOCKS=y for mac_defconfig. This in turn causes the m68k > "q800" and "virt" machines to crash in qemu if debugging options are > enabled. > > Making CONFIG_SPLIT_PTE_PTLOCKS dependent on the existence of NR_CPUS > does not work since a dependency on the existence of a numeric Kconfig > entry always evaluates to false. Example: > > config HAVE_NO_NR_CPUS > def_bool y > depends on !NR_CPUS > > After adding this to a Kconfig file, "make defconfig" includes: > $ grep NR_CPUS .config > CONFIG_NR_CPUS=64 > CONFIG_HAVE_NO_NR_CPUS=y > > Defining NR_CPUS for m68k does not help either since many architectures > define NR_CPUS only for SMP configurations. > > Make SPLIT_PTE_PTLOCKS depend on SMP instead to solve the problem. > > Fixes: 394290cba966 ("mm: turn USE_SPLIT_PTE_PTLOCKS / USE_SPLIT_PTE_PTLOCKS into Kconfig options") > Cc: David Hildenbrand > Cc: Andrew Morton > Cc: Geert Uytterhoeven > Signed-off-by: Guenter Roeck > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb