* [PATCH] Correct minor spelling mistake in huge_memory.c.
@ 2025-12-18 11:20 klourencodev
2025-12-18 11:54 ` David Hildenbrand (Red Hat)
0 siblings, 1 reply; 4+ messages in thread
From: klourencodev @ 2025-12-18 11:20 UTC (permalink / raw)
To: linux-mm
Cc: akpm, david, lorenzo.stoakes, ziy, baolin.wang, Liam.Howlett,
ryan.roberts, Kevin Lourenco
From: Kevin Lourenco <klourencodev@gmail.com>
No functional changes.
Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>
---
mm/huge_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 40cf59301c21..5efd2cf4f073 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3220,7 +3220,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
swp_entry = make_readable_device_private_entry(
page_to_pfn(page + i));
/*
- * Young and dirty bits are not progated via swp_entry
+ * Young and dirty bits are not propagated via swp_entry
*/
entry = swp_entry_to_pte(swp_entry);
if (soft_dirty)
--
2.47.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Correct minor spelling mistake in huge_memory.c.
2025-12-18 11:20 [PATCH] Correct minor spelling mistake in huge_memory.c klourencodev
@ 2025-12-18 11:54 ` David Hildenbrand (Red Hat)
2025-12-18 12:21 ` Kevin Lourenco
0 siblings, 1 reply; 4+ messages in thread
From: David Hildenbrand (Red Hat) @ 2025-12-18 11:54 UTC (permalink / raw)
To: klourencodev, linux-mm
Cc: akpm, lorenzo.stoakes, ziy, baolin.wang, Liam.Howlett, ryan.roberts
On 12/18/25 12:20, klourencodev@gmail.com wrote:
> From: Kevin Lourenco <klourencodev@gmail.com>
>
> No functional changes.
Subject: "mm/huge_memory: correct minor spelling mistake"
Then a simple "Let's correct progated -> propagated in a comment."
You can drop the "no functional change" part as you only modify a comment.
>
> Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>
> ---
> mm/huge_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 40cf59301c21..5efd2cf4f073 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -3220,7 +3220,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> swp_entry = make_readable_device_private_entry(
> page_to_pfn(page + i));
> /*
> - * Young and dirty bits are not progated via swp_entry
> + * Young and dirty bits are not propagated via swp_entry
> */
> entry = swp_entry_to_pte(swp_entry);
> if (soft_dirty)
Are there any other spelling issues in that file so we can avoid more of
these patches that don't add a lot of value and only consume reviewer time?
--
Cheers
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Correct minor spelling mistake in huge_memory.c.
2025-12-18 11:54 ` David Hildenbrand (Red Hat)
@ 2025-12-18 12:21 ` Kevin Lourenco
2025-12-18 12:46 ` David Hildenbrand (Red Hat)
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Lourenco @ 2025-12-18 12:21 UTC (permalink / raw)
To: David Hildenbrand (Red Hat)
Cc: linux-mm, akpm, lorenzo.stoakes, ziy, baolin.wang, Liam.Howlett,
ryan.roberts
Hi David,
I have found no other spelling issues. I also did a deeper review of
the mm/ directory in general and identified more than 20 evident typos
across various files.
I was considering cleaning all of mm/ in one go to provide a more
thorough and consistent update. However, if you feel that doing so
would not add significant value and would only consume reviewer / my
time, I completely understand and can refrain from submitting them.
Alternatively, I could create a single patch that addresses all the
typos at once in mm/.
Please let me know your preference.
Best regards,
Kevin
Le jeu. 18 déc. 2025 à 12:54, David Hildenbrand (Red Hat)
<david@kernel.org> a écrit :
>
> On 12/18/25 12:20, klourencodev@gmail.com wrote:
> > From: Kevin Lourenco <klourencodev@gmail.com>
> >
> > No functional changes.
>
> Subject: "mm/huge_memory: correct minor spelling mistake"
>
> Then a simple "Let's correct progated -> propagated in a comment."
>
> You can drop the "no functional change" part as you only modify a comment.
>
> >
> > Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>
> > ---
> > mm/huge_memory.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> > index 40cf59301c21..5efd2cf4f073 100644
> > --- a/mm/huge_memory.c
> > +++ b/mm/huge_memory.c
> > @@ -3220,7 +3220,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> > swp_entry = make_readable_device_private_entry(
> > page_to_pfn(page + i));
> > /*
> > - * Young and dirty bits are not progated via swp_entry
> > + * Young and dirty bits are not propagated via swp_entry
> > */
> > entry = swp_entry_to_pte(swp_entry);
> > if (soft_dirty)
>
> Are there any other spelling issues in that file so we can avoid more of
> these patches that don't add a lot of value and only consume reviewer time?
>
> --
> Cheers
>
> David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Correct minor spelling mistake in huge_memory.c.
2025-12-18 12:21 ` Kevin Lourenco
@ 2025-12-18 12:46 ` David Hildenbrand (Red Hat)
0 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand (Red Hat) @ 2025-12-18 12:46 UTC (permalink / raw)
To: Kevin Lourenco
Cc: linux-mm, akpm, lorenzo.stoakes, ziy, baolin.wang, Liam.Howlett,
ryan.roberts
On 12/18/25 13:21, Kevin Lourenco wrote:
> Hi David,
>
> I have found no other spelling issues. I also did a deeper review of
> the mm/ directory in general and identified more than 20 evident typos
> across various files.
>
> I was considering cleaning all of mm/ in one go to provide a more
> thorough and consistent update. However, if you feel that doing so
> would not add significant value and would only consume reviewer / my
> time, I completely understand and can refrain from submitting them.
> Alternatively, I could create a single patch that addresses all the
> typos at once in mm/.
>
> Please let me know your preference.
Hi Kevin,
then please send all of them in a single series, combining them in
patches where reasonable.
For example, the feedback I gave you should be applied to all patches
(e.g., subject prefix, patch description).
Imagine doing that as a reviewer to 20 individual patches from 20
individual contributors :)
--
Cheers
David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-18 12:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-18 11:20 [PATCH] Correct minor spelling mistake in huge_memory.c klourencodev
2025-12-18 11:54 ` David Hildenbrand (Red Hat)
2025-12-18 12:21 ` Kevin Lourenco
2025-12-18 12:46 ` David Hildenbrand (Red Hat)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox