From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0BDC76196 for ; Mon, 3 Apr 2023 14:43:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE62C6B0085; Mon, 3 Apr 2023 10:43:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9654900004; Mon, 3 Apr 2023 10:43:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8541900003; Mon, 3 Apr 2023 10:43:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CB5AC6B0085 for ; Mon, 3 Apr 2023 10:43:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9957B40B72 for ; Mon, 3 Apr 2023 14:43:16 +0000 (UTC) X-FDA: 80640347592.25.4B15056 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 4D457100010 for ; Mon, 3 Apr 2023 14:43:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Elevh4Zd; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680532994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/eYb2XMUpR9VXDleQG1dvUeP259a87ERPUWeMJE/H5g=; b=TElapg6tOoWGRNptAiOMOUpGLNAKwl7qzsIfVftlkquTip/BDNIWBMPkYBnEHhGc+8eWSj CSYRuldlfIF467ombFmmGrp7MSfL61gDgqQ2xLIKBSRF2cnGNchuqE2BfJG0urVMc0JDZb dIjDicAdkxSslG0oQ9JNLiU6G+UsOKM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Elevh4Zd; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680532994; a=rsa-sha256; cv=none; b=P47KENcctU024bG6zkqGDBe7fMjZHpyFPP1oICklTM0GVQl7uq4FU1hqOjQKdy0lbYZgk9 2qm5RH5djSpIWo5Vh0YTUUZleSy70sPSCE7ZOkF9ZtPshBtxZrUr1NCVvWNTcT7mdJ0i8E REeFLMtv3BhXq8+AZNG52E3lmhYuis8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680532993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/eYb2XMUpR9VXDleQG1dvUeP259a87ERPUWeMJE/H5g=; b=Elevh4Zd3aW7+wpa9VK2FHEI4B1i1v4uVsKQt7PwTv6OJy7yI1x2xZNv8AdRoqhH23ZUfF T5cW4lhrpW7cj//V7iNAoLB7qpzuVT8yIbRq72P3OT4yxmMFm9jMGyTbASAzMS2y/OqQKl j6B9l6Il6kwO2aKB41ZI5heMDF+lc+g= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-G9ErwgaoOzeLE6MZC7g6iQ-1; Mon, 03 Apr 2023 10:43:12 -0400 X-MC-Unique: G9ErwgaoOzeLE6MZC7g6iQ-1 Received: by mail-wm1-f70.google.com with SMTP id m27-20020a05600c3b1b00b003ee502f1b16so14650011wms.9 for ; Mon, 03 Apr 2023 07:43:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680532991; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/eYb2XMUpR9VXDleQG1dvUeP259a87ERPUWeMJE/H5g=; b=nOxX3+wx7q34ZS69LswV0yhHk2QMcCqaTBn3HddIUDHQo03qmQDmMNrBezZ5DFVYb6 FHXXE14ZBdaPicnN0yVU7ApCT70GhQ/WxvOP2EnIuHqt8nBiQkdLfkuPyAY9J7W58I/i wRkv/Ks0/6RHvV52CD1Yo6ZEL4pGPgSr5GamTdu6mKWyLuQhtk55FjbbeXKyxqnEZ7Vn m37+vw7In+SgOb6Rhekr/DBOJAO7tKUCCiOoTJGnOUqb68/OM9yLHKsiHw/CpUf1Y4O/ F/sclt7tqD3spebvjFl4GYzuIAQKp9Oo0i73Fxe/iHzAHDFCYzt/u1d3lbN2i6JWbfnJ UySA== X-Gm-Message-State: AAQBX9fC54a1r5Yg6l9FJMfSevUueXOs7ckcr9kBxjNyzwdbH9nNXcSu dWvbNe808elVOGj+odO3MEZk8OT9rqsmsSZq9a477Gdk5O3iefK0Hirp4csmBtkzDy8QbwGUhk6 +jBvOhZl8bf0= X-Received: by 2002:adf:fb0d:0:b0:2e5:17a4:7d65 with SMTP id c13-20020adffb0d000000b002e517a47d65mr9852985wrr.39.1680532991154; Mon, 03 Apr 2023 07:43:11 -0700 (PDT) X-Google-Smtp-Source: AKy350Y08+lpc/XjAnUg5I1OrKi5tNhWj0ZeUnj6X2UCuKEr2raMcQhFTlwQjTgwu1vHm8iFtim9pA== X-Received: by 2002:adf:fb0d:0:b0:2e5:17a4:7d65 with SMTP id c13-20020adffb0d000000b002e517a47d65mr9852963wrr.39.1680532990772; Mon, 03 Apr 2023 07:43:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5e00:8e78:71f3:6243:77f0? (p200300cbc7025e008e7871f3624377f0.dip0.t-ipconnect.de. [2003:cb:c702:5e00:8e78:71f3:6243:77f0]) by smtp.gmail.com with ESMTPSA id i17-20020a5d5591000000b002eaac3a9beesm169318wrv.8.2023.04.03.07.43.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 07:43:10 -0700 (PDT) Message-ID: <053a9ccd-4205-7a76-70c3-c256bd995a1f@redhat.com> Date: Mon, 3 Apr 2023 16:43:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCHv9 03/14] mm/page_alloc: Fake unaccepted memory To: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel Cc: Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Dave Hansen , Mike Rapoport , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230330114956.20342-1-kirill.shutemov@linux.intel.com> <20230330114956.20342-4-kirill.shutemov@linux.intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230330114956.20342-4-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ukyp8zzcist1qq4hft1mjgfsyyhq5qkz X-Rspam-User: X-Rspamd-Queue-Id: 4D457100010 X-Rspamd-Server: rspam06 X-HE-Tag: 1680532994-444394 X-HE-Meta: U2FsdGVkX19aazwtXl8+5kV8tNVFPhzogOV3k7g2ATYibpgnidmbDi27/0MQN/5P4qcwt93CNsj/8mbXp82e3ipy6xH9BVa2/M3vT6qEdvZ+DhFL7Rt6FDSElr5iMkiQvyXikACgG7KTiMvBhEtd0cEZAf8vNg8e7w9Znohr49t+zEz9BDu7SvHO4O/30L3bLYpuRtlv1/kmbpN1IDPnLjE4KwVLIZeBoFMrm3QmhOiolWBG+i9+1P88LF50X/vM6Yf3ik8TSs3Q303zbgpZJ3T0Y7t93oJVtgxxcOFFCDZjtG2lvECl508hxO177DaSiKhMYTlziDttwM1m/ULLvFNmH+V/Uu4ibOsXS/4Hf7YJelVzT4ntLKCoUy8W1y5lRP9yAUexJ2wBPlms2UI8qLMoePQeyagifTjRTmzqO0fauuZdg8KmbEmvzJXSwhtJ72UKwKYOuFqzWdvxUnrgr6EdCU6jv2WyAmluV8FFHPPDeqtGbjlfqKzSUydY100nzYMD71LlBeO7RpV/KnsvzxMKaq8waCLu+6SBZ1xsBWY0xq7iZOnrMs1hCWrmPK/lXaQOwDXWDAxRhG9dcavCu1nGD008OfHNgQgq3LQw3xxZ5EqAYB4U+PIfSCDeU+PD6zgoaQlV17KCoRqVjH29lP0Q03U6hDgqturnVwOwLib3PKxl/sbVj+WziLCmEm8zXnIE9tUYcPgObbhp2ir6o0fBRExXcng3pPkLZypEyn4073TPrf3fJgPQi4DIEPv9wk24LMi22/UOjxdohwC8Tbk44mqTI9cHHDa9l5LOUsCruKArENX9AyiLn6mZrcW+eEZdbgwnYAXEQwvmR2f2oHkv4QcLgHab60SgW8+dnqUPEWVzAs8O2DveQ2GYx4wjSWD6xZmr1XdD4OrfglMGdnSll+IcNA9QRQdLNsuH9/GibMdMfDD9zOZF2BRtD0IRyK2ELYvT9nyDO4hZhhf 8lUK6yOW HLgA9/dqGza2Xh9NgvQbGb/wNMihfNyXf1OkLl8SEv1krODYlpoaFP7NOlXyTPZIllMUwBLpYRGkpdefNChIHPw/ewrcxd/4LecKdBQHUJmGj3musifO6VPj39fM8hqelxSl5J+u7OlLe/9Imv94xsSrlqz2T2A6qeD9nzatF/gkLgy/bd+5JgciXIKC7suZ/Pibi6Hgae1I9p5414dkTf+PQHAHR5Y0RZhDpi7G1lTcYtGvwmoobLr8FuOm5kjYdXbQWh1nFqOoaPEc+rOwNQqpwC24LGnKeFl8D4S9bikb4cyRrOWz/eomM9GQn9ogDEtjsk4BBEAEpsSbNmz15N4IZ6wW+EkRgzbTQRqa+w8drmyHBsiExZssNRVYhwkNGbd9QMeJ7wFCpZua5HjW6GTqgWX2QGFUZzp6V9pgRBpE+Hhh3iBtFgdj8RH/ty/uHTqQeanJUU/jmUMjnJk81K3v5nnYB7NBzbayF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.03.23 13:49, Kirill A. Shutemov wrote: > For testing purposes, it is useful to fake unaccepted memory in the > system. It helps to understand unaccepted memory overhead to the page > allocator. > > The patch allows to treat memory above the specified physical memory > address as unaccepted. > > The change only fakes unaccepted memory for page allocator. Memblock is > not affected. > > It also assumes that arch-provided accept_memory() on already accepted > memory is a nop. > > Signed-off-by: Kirill A. Shutemov > --- > mm/page_alloc.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index d62fcb2f28bd..509a93b7e5af 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7213,6 +7213,8 @@ static DEFINE_STATIC_KEY_FALSE(zones_with_unaccepted_pages); > > static bool lazy_accept = true; > > +static unsigned long fake_unaccepted_start = -1UL; > + > static int __init accept_memory_parse(char *p) > { > if (!strcmp(p, "lazy")) { > @@ -7227,11 +7229,30 @@ static int __init accept_memory_parse(char *p) > } > early_param("accept_memory", accept_memory_parse); > > +static int __init fake_unaccepted_start_parse(char *p) > +{ > + if (!p) > + return -EINVAL; > + > + fake_unaccepted_start = memparse(p, &p); > + > + if (*p != '\0') { > + fake_unaccepted_start = -1UL; > + return -EINVAL; > + } > + > + return 0; > +} > +early_param("fake_unaccepted_start", fake_unaccepted_start_parse); > + > static bool page_contains_unaccepted(struct page *page, unsigned int order) > { > phys_addr_t start = page_to_phys(page); > phys_addr_t end = start + (PAGE_SIZE << order); > > + if (start >= fake_unaccepted_start) > + return true; > + > return range_contains_unaccepted_memory(start, end); > } > The "unpleasant" thing about this is, that page_contains_unaccepted() could not be used for sanity checks because the result is static. For example, something like if (page_contains_unaccepted(page, 0)) accept_memory(page, 0); BUG_ON(!page_contains_unaccepted(page, 0)); Would work on real hardware, however, not for the fake variant. -- Thanks, David / dhildenb