From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A081C43334 for ; Fri, 10 Jun 2022 09:01:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A355C6B0118; Fri, 10 Jun 2022 05:01:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E55A6B0119; Fri, 10 Jun 2022 05:01:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 885D36B011A; Fri, 10 Jun 2022 05:01:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 760A96B0118 for ; Fri, 10 Jun 2022 05:01:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 386D331FB6 for ; Fri, 10 Jun 2022 09:01:31 +0000 (UTC) X-FDA: 79561732782.19.1A6C15D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 75B21A006B for ; Fri, 10 Jun 2022 09:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654851690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HtEXO+GIed8HmHtMw93u9qaevp+TbZ6ZLmBndSXD2aU=; b=BOrbM1519xSQAMewRfRcR3TTBzdfVREy2fnYpcqdenfynXoMByAfVv6X46oW+pgHqmZmfz 1zJ6vbc5+54JcbO6Dwyly1UPZPxs+m641sK4vmtkH5RWkZvyFH1B+YVVZMuwRAo5kmd8zQ 3bp7nAgLYzplJs6Uho4ZrEs3YW2Ww+I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-19-drSmz03ZNvulu9zpsEFzgQ-1; Fri, 10 Jun 2022 05:01:29 -0400 X-MC-Unique: drSmz03ZNvulu9zpsEFzgQ-1 Received: by mail-wm1-f72.google.com with SMTP id bg40-20020a05600c3ca800b00394779649b1so1022871wmb.3 for ; Fri, 10 Jun 2022 02:01:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=HtEXO+GIed8HmHtMw93u9qaevp+TbZ6ZLmBndSXD2aU=; b=7zGvyOV4NvXw/r8du7iF4HAuBYB4PGUoBO4nJDkJLBpzbtTYWNKFTvwwqk9/nvX9ZV h4qwfgz6ldvmKMLdCjwLMsL6WR2Q5fnio75vUzedZf3As7dUt8ZnFCHJAX8cX7Ir1JWA 3mrsQpwRHn8cgMsUQ2nRbc6uOcW0mlPc9iiCak2PfmPh6IzAfE1Lo6+h0hMsQ/T+HcQp e60o3yz5FjcruZ9mW5MAjGBaR8cpb7YrICV97/PUcDPjiVKv++1hW++/wqD86llfG7kW EahSF9KQJNm1vzqrYVtX7Q7lki2ycEZpq9dgOuYOw9kf5RCIywPSXIPQnFq/0BpgPZ9C USxg== X-Gm-Message-State: AOAM532in/1lfcz3QxhtahYxkcOjEV8lNKORc0pLq4zYvGGhUVVWVDml gv6uOPJb7mdTnbFsubVEdXvOq6H6riV1uePKZGi+bRe+yrX5ok0EC1G4UCHIiWd0VhjnFvccbCY lboKQ09gW4gc= X-Received: by 2002:a05:600c:354a:b0:39c:4ebf:fb4c with SMTP id i10-20020a05600c354a00b0039c4ebffb4cmr7830405wmq.142.1654851687792; Fri, 10 Jun 2022 02:01:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwCej9HvRZ5HrvY23GNVdzc3yEGlPxHuh1YuQtD1VyfXSrsZpSQ7s/EzwOBAn/DLCELlOfeQ== X-Received: by 2002:a05:600c:354a:b0:39c:4ebf:fb4c with SMTP id i10-20020a05600c354a00b0039c4ebffb4cmr7830369wmq.142.1654851687440; Fri, 10 Jun 2022 02:01:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:1f00:4727:6420:1d4d:ca23? (p200300cbc7051f00472764201d4dca23.dip0.t-ipconnect.de. [2003:cb:c705:1f00:4727:6420:1d4d:ca23]) by smtp.gmail.com with ESMTPSA id j26-20020a05600c1c1a00b0039c54bb28f2sm2294299wms.36.2022.06.10.02.01.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 02:01:26 -0700 (PDT) Message-ID: <05301a1a-6020-aa52-d539-c2e0ba147181@redhat.com> Date: Fri, 10 Jun 2022 11:01:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3] madvise.2: Clarify addr/length and update hugetlb support To: Peter Xu , Mike Kravetz , Alejandro Colomar Cc: linux-man@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Axel Rasmussen References: <20220608234517.117295-1-mike.kravetz@oracle.com> <3cf768b3-4d09-de13-7975-ebb74a68752e@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654851690; a=rsa-sha256; cv=none; b=LsRnKlcj7jxeuLd6WGLg/uKGj1XAtP2FgNBKewk60GPV1QvXHO51SKI6LqbP3g73OUrSw3 4RzJxqyjhbiNUlV5qA3Vx4WA5Gu9uv5mv7NZvWywDdzF0LTQsqeahNTEGH65urLL/EwO86 I+e+bW1uDSiV2XNLhJYf/Iu5jXBtKfs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BOrbM151; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654851690; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HtEXO+GIed8HmHtMw93u9qaevp+TbZ6ZLmBndSXD2aU=; b=z7Bfggh7lczbgPj2bVB4cwpuhx5A56ZjCYlk6cozv5s9otDA3toQeN9wiM2N6y/NA7ZzaZ Quu2ibKD5RtNtIPZ9ZFxLUtoI3pPKUqlIwH3gdI7vSq2OU+tcG66QuZN4rutm0wHBO/+CL iDtfwODqz+vrftZR2G/Bg1AJ7arBK+o= X-Stat-Signature: xanwwiziikhp1mztn8hhsg7qtgb4kiyw X-Rspamd-Queue-Id: 75B21A006B X-Rspam-User: X-Rspamd-Server: rspam10 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BOrbM151; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1654851690-593591 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.06.22 22:13, Peter Xu wrote: > On Thu, Jun 09, 2022 at 11:48:06AM -0700, Mike Kravetz wrote: >> On 6/9/22 06:24, Alejandro Colomar wrote: >>> Hi Mike, >>> >>> On 6/9/22 01:45, Mike Kravetz wrote: >>>> Clarify that madvise only works on full pages, and remove references >>>> to 'bytes'. >>>> >>>> Update MADV_DONTNEED and MADV_REMOVE sections to remove notes that >>>> HugeTLB mappings are not supported.  Indicate the releases when they >>>> were first supported as well as alignment restrictions. >>>> >>>> Signed-off-by: Mike Kravetz >>>> Acked-by: Peter Xu >>> >>> Please check some comments below. >>> >>> Thanks, >>> >> >> Thank you! >> >> And, my apologies for not looking at formatting requirements. >> Will send a v4 shortly. > > Alex, > > Do you think we could add some of the semantic newline requirement into > CONTRIBUTING file explicitly? Although there's a pointer to man7 man-pages > but the semantic newlines rules seem to be easily overlooked. > > IMHO there can even be examples as you quoted in the link on "UNIX For > Beginners": > > https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/man7/man-pages.7?h=alx/main&id=6ff6f43d68164f99a8c3fb66f4525d145571310c > > Maybe that'll ease both the maintainers and the contributors? Maybe something similar checkpatch in Linux/qemu could point out a lot of these possible issues and reduce Maintainer overhead. Nobody reads docs after all if not forced to ;) -- Thanks, David / dhildenb