From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA20DC7115A for ; Wed, 18 Jun 2025 09:31:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48BC56B0088; Wed, 18 Jun 2025 05:31:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 462F36B0089; Wed, 18 Jun 2025 05:31:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3787C6B008A; Wed, 18 Jun 2025 05:31:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 27EB36B0088 for ; Wed, 18 Jun 2025 05:31:11 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 75852120E6B for ; Wed, 18 Jun 2025 09:31:10 +0000 (UTC) X-FDA: 83568002700.20.E9A7222 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 1F38A140012 for ; Wed, 18 Jun 2025 09:31:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XfRK2f6X; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750239068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DAAxpkDR64hsnaI9Udos0W7mCWFzGT/DUlyAtDcPHQM=; b=EPLBC1rhTLcHMpGbJX4aT5FzOysPm0wLoknoKf2mfrOKGWqHC8CekDoRgOag+I3nYunVne 1eA64pSdiyEyajHpK6K2n361szgX7whraXRP+zm3guZYuhfQQTqsM5CeY8DUp2oKcLe9bU N9Dz/5X5wWooIxFpBk6/6hVRAus9/9o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750239068; a=rsa-sha256; cv=none; b=GCernnGDNMDbt3WMVv5Iu9TVJmKvWH8asSwauhUuP/jw5kqI0/2piREAAVmY1ddDCAmqD/ DR9BiWlsXnvyOpyilafrRjCpZxOEFf+mpCgLRp8MTkowJTRuqPaBux57LEQm482r1NGoNg ZuTQzFUILSeLG8hQHl4oRIQlYnOVS+M= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XfRK2f6X; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750239067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DAAxpkDR64hsnaI9Udos0W7mCWFzGT/DUlyAtDcPHQM=; b=XfRK2f6Xk0iT8cmMZXk815s0t3tgxz+oyOZWSVz+uW4+p+qa8jmYy4l02WoJfkmXsOZmMc VfXqBLUNi2O+68Kz2Kw9vK+lybCs/GkbBmwoKXuCyXpzBstruW6ad8lfns1w/mgLG1Hd2K Dy6GbhyvB+smAKK56F/oOL1WdRs77+I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-CFYvDcxFOU-uGF9TMkNGvQ-1; Wed, 18 Jun 2025 05:31:06 -0400 X-MC-Unique: CFYvDcxFOU-uGF9TMkNGvQ-1 X-Mimecast-MFC-AGG-ID: CFYvDcxFOU-uGF9TMkNGvQ_1750239065 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450d64026baso45500695e9.1 for ; Wed, 18 Jun 2025 02:31:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750239065; x=1750843865; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DAAxpkDR64hsnaI9Udos0W7mCWFzGT/DUlyAtDcPHQM=; b=T7rrlOZIH9sTJOdVMMxVIdtKbnxvAxoobNDhi9gqDeQRLjJlCEcmynjdzC8XhAWPYr Ssi+BlB1MgB9GLQ4x5y6nTu0D1X0lT5s4XBVxQootZMLQHAFFcgBKo6yR4PpkyxCQH4q 4wI0IyW4vkIbzzdAGRINV5tgETAAD7puLbK2xTUj/sXmYyV7MCFKj0AwaQaUjIl0aRqe fSkgy9Z2WNIG+2SK3qHKhvxGzlDP+5rePIl6S5zl4wQB22i/VoZF2P8p0m2dQHl8ZIqc UF7AsnWcjTacU95lXwtI4jofTDmpOh2OU4ky9wbmYVoV/YHHRUg1k7+2KDxjHqsLC2XN 5itA== X-Gm-Message-State: AOJu0YwxtxBI8aGiRYcKfLdP2MD+A1NdzPkmDpe4SRlJOKRoSBSgo6ZZ o2dpe73SGeZzvlmasZNSiQjHf1w0oGi/FC2uZYfnRAsq/kooVFN4+o/gOdsO0yjuRSj/94/fZRj xRFQUM8Z3WURifYqp3YtEodnGbFE+alnxHfIuNqi/mXAS1jH+JeoF X-Gm-Gg: ASbGncvpOq8Fy28soYzn3+utPsY1/RPuu1SU72D0f7I9efXDHVH2zTC//LHywW5bGsm RemUJzt6+0xM35SPOlQfopKcjPDo3oSbGyOAQiGSlfXA7uWaNMAH1bUyzAbNo93UNLW5KqEJ1zd k772H1LOFF0rAsRCn5fRa6edrj1GnJYQMpEff7Jp88LUSDZXnmm+K0sLYpnPKJ+qe27b6xn6fko Xno8YPkOD7s6GREZGmWara5J4dPe7xr4ocSTjE+KAYhayaklwasHl8d+UWk4Ej5Wm8g68eOB9Rr cUzjrDMkrrC/6vRFF9RG+nOb8lm7FSKiW8Bv+9aKNZtt2RJ9iZwTn4lPi9D6QdiBZY8P3NaBuAY BkpHLVBwvwVJtln6cFmoVgJXRztlno082VuFHIy7rIpFhscQ= X-Received: by 2002:a05:600c:5396:b0:43d:172:50b1 with SMTP id 5b1f17b1804b1-4533cac8fdbmr151178485e9.29.1750239064924; Wed, 18 Jun 2025 02:31:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFE2lmgl3UBomQIO41tOZKwEtVJWCPsqqDyTr4SmltEOYbKotteA+xAeGqRpDK/3zaPP374g== X-Received: by 2002:a05:600c:5396:b0:43d:172:50b1 with SMTP id 5b1f17b1804b1-4533cac8fdbmr151178015e9.29.1750239064488; Wed, 18 Jun 2025 02:31:04 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:2400:4052:3b5:fff9:4ed0? (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a73845sm16606417f8f.35.2025.06.18.02.31.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 02:31:04 -0700 (PDT) Message-ID: <051f769d-3a0e-409e-bd40-22000f10b986@redhat.com> Date: Wed, 18 Jun 2025 11:31:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/14] mm: Convert vmf_insert_mixed() from using pte_devmap to pte_special From: David Hildenbrand To: Alistair Popple , akpm@linux-foundation.org Cc: linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, jgg@ziepe.ca, willy@infradead.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@Groves.net, m.szyprowski@samsung.com, Jason Gunthorpe References: <5c03174d2ea76f579e4675f5fab6277f5dd91be2.1750075065.git-series.apopple@nvidia.com> <1709a271-273b-4668-b813-648e5785e4e8@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1709a271-273b-4668-b813-648e5785e4e8@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bu-cVqQNs71xXdhpzGo4UkVtEreawBhu0QIRListFqU_1750239065 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1F38A140012 X-Stat-Signature: jh1hffp74nwsyjcrzmqq5cfpojs3mfwn X-Rspam-User: X-HE-Tag: 1750239067-180773 X-HE-Meta: U2FsdGVkX1+NSjv7vsWeMM8TRVaLoIo95aguSfS6uku2hoKclPrDLHymcaQbJhtER/dKR2pez+c4wJf6/OtFMkcU/YbYBZcl1jbaXOrx6yYqZGtzxb+ltkP9EUe8eZPiqwcbi/VXEWBEmC9B7M7ShPO/VerqBn6SqY4pLwufpWxrCJTw+zvxD9zGw4jwg6MeIFhU3fC3a9kZ8ObFTyKZUWwNuA9s/MMRnZq+OmEERgKX01quJKLOk4EPd5CwKVnJzfazgGTo+6OopVTLrqMnKVZlcC9GKDvRawDcbMy0A56VzQX78SjJk6PwqeC4ia+4fUxzbXtVA5oJEB3tUStVE25SRkuQpkuyCmVr6fwPiFTpSWGn5kBvPBsHvPYE8C9DBzXczSERzluxPdfpU+CM0syNfa5IrhHWJ6a1Y6nRDLNGKcJZJBfjYrEm2dWJuPDxKDM/vmqQYduL1b59ylcDw1t/KzC43gkkr95cLvRTNiWHJOKJ2XY6y//L5SUVy/q3WJkf0DdJ7Pzxo8UgQEl4pVdaGtLaJX3JAUf98MFZBpH6x3Sp0RxoJEsPNKcWn3mkde/e1d9dGqla1VA4wttfVxDwDBu0m58zvcMBWBNFM1eATACRfkcarG0+eJgTO2bQXel/6bd6jOSuMUo1QEmEF3psWBg0e5A12jIxE6Ywb5GF9Tg43MHpRUisBeBCkpINzt8xgcNFFTUlKTpkonKxRsmt4O77uTrJrPIyWZglo/SmtjibKA92TcG7DOLcVyncKCEIbYYmUJgSv7X6gSXyjDe943+upDxJy4xWbwpU+k8i+e+Zfv0gLr9NNBQt4WZThPAUz2ECQQGInUrVxTatqa2O1/g6Va8Ha3wzqIt2v2bjkKzM3wq76rfAaRToqi/swF9sKh3CQ373cMvy+mV3HI1aL0JbIluyJnhn4Lu6iWNixUs/yyT8XydeIeqM5Hxnr93y6jJqJSFq+Yo3n6K gkhjV/+R 06569W4GDmiEIrw/fz7X2LuXWQtXBT4P89wYY9FD2W787p5RbP4SUEOtPE9HrivlKEGojUbcIBobgaLEajVlmNILX87HJST3Y/ChQYfC+ktoKX7Om1I64Ng8kGGt+eQJzpDsO/rpQMTxu4YUDOc6FEAf9NUnB4am1a5hVQhShY63zWKeUydfrQvAluzgacL13IldhKtQn8Y7umQTc/zYttxk9PmXPkjlNNo5NU3nXB46qiQVXC9uWjUoAE3mxvkxhSOJ5I+/dw+xE0hof1t4r13457MktjmnGJtC9U6GEoUJrWpd+ahesp3MgImIQ7zHdcpGXc7+kI+4iUCmY6bL1f8ryMeWpgiHJ1Abtcw2oSXLYVqcIa+rbluv69wArrkB6XJ70yvY7REYQC/ROY/2Kja8aOu+t889Aw0+ITCMZU1Ul/qbuxNN+A9ESIWrSDRG1DH/vYgq99O20oSgY4k4fQyTIO/q54YzPrMLVDfqART4YCQecM1pA5N59KItCi+0f+6usuhYee1B8Cy3mxhD+0EwpdfQ4NW1n4B9BOPj/12JB7UQW/e2sWd7ZmzpLjD4Wxqla X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.06.25 11:49, David Hildenbrand wrote: > On 16.06.25 13:58, Alistair Popple wrote: >> DAX no longer requires device PTEs as it always has a ZONE_DEVICE page >> associated with the PTE that can be reference counted normally. Other users >> of pte_devmap are drivers that set PFN_DEV when calling vmf_insert_mixed() >> which ensures vm_normal_page() returns NULL for these entries. >> >> There is no reason to distinguish these pte_devmap users so in order to >> free up a PTE bit use pte_special instead for entries created with >> vmf_insert_mixed(). This will ensure vm_normal_page() will continue to >> return NULL for these pages. >> >> Architectures that don't support pte_special also don't support pte_devmap >> so those will continue to rely on pfn_valid() to determine if the page can >> be mapped. >> >> Signed-off-by: Alistair Popple >> Reviewed-by: Jason Gunthorpe >> Reviewed-by: Dan Williams >> --- As Andrew notes offlined, there is no content here. I sent this by mistake after replying to patch#6 instead. -- Cheers, David / dhildenb