From: A K <akaraliou.dev@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
minchan@kernel.org, ngupta@vflare.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/zsmalloc: simplify shrinker init/destroy
Date: Wed, 20 Dec 2017 11:29:29 +0300 [thread overview]
Message-ID: <04faff62-0944-3c7d-15b0-9dc60054a830@gmail.com> (raw)
In-Reply-To: <20171220071500.GA11774@jagdpanzerIV>
On 12/20/2017 10:15 AM, Sergey Senozhatsky wrote:
>
> On (12/19/17 15:27), Andrew Morton wrote:
> > I did this:
> >
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Subject: mm-zsmalloc-simplify-shrinker-init-destroy-fix
> >
> > update comment (Aliaksei), make zs_register_shrinker() return void
> >
> > Cc: Aliaksei Karaliou <akaraliou.dev@gmail.com>
> > Cc: Michal Hocko <mhocko@kernel.org>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> looks good. thanks!
>
> -ss
Thanks for updating the code, Andrew, but removing return from
zs_register_shrinker() leads to triggering of 'warn_unused_result'
from 'sparse' on the line where register_shrinker() is called
(which was recently marker as __must_check).
May we leave previous variant to avoid that ? Or it is not critical ?
Best regards,
Aliaksei.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-20 8:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 9:21 [PATCH] " Aliaksei Karaliou
2017-12-19 10:22 ` Sergey Senozhatsky
2017-12-19 10:49 ` [PATCH v2] " Aliaksei Karaliou
2017-12-19 11:04 ` Sergey Senozhatsky
2017-12-19 11:56 ` Sergey Senozhatsky
2017-12-19 15:13 ` Michal Hocko
2017-12-19 15:25 ` Sergey Senozhatsky
2017-12-19 15:41 ` Aliaksei Karaliou
2017-12-19 15:58 ` Michal Hocko
2017-12-19 17:45 ` Aliaksei Karaliou
2017-12-19 23:27 ` Andrew Morton
2017-12-20 1:00 ` Sergey Senozhatsky
2017-12-20 1:00 ` Sergey Senozhatsky
2017-12-20 7:15 ` Sergey Senozhatsky
2017-12-20 8:29 ` A K [this message]
2017-12-20 8:34 ` Sergey Senozhatsky
2017-12-20 8:53 ` A K
2017-12-20 9:08 ` Michal Hocko
[not found] ` <20171220091653.GE11774@jagdpanzerIV>
2017-12-20 9:25 ` Michal Hocko
2017-12-20 9:30 ` A K
2017-12-20 10:21 ` [PATCH v3] " Aliaksei Karaliou
2017-12-21 2:29 ` Minchan Kim
2017-12-20 11:05 ` [PATCH v2] " Tetsuo Handa
2017-12-20 11:38 ` Michal Hocko
2017-12-20 11:57 ` Michal Hocko
2017-12-20 21:20 ` Aliaksei Karaliou
2017-12-21 7:25 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04faff62-0944-3c7d-15b0-9dc60054a830@gmail.com \
--to=akaraliou.dev@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox