From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD92DC3DA42 for ; Wed, 17 Jul 2024 07:49:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41D896B0095; Wed, 17 Jul 2024 03:49:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CE226B009A; Wed, 17 Jul 2024 03:49:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2957F6B009B; Wed, 17 Jul 2024 03:49:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0BFE16B0095 for ; Wed, 17 Jul 2024 03:49:02 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B3B81404DD for ; Wed, 17 Jul 2024 07:49:01 +0000 (UTC) X-FDA: 82348468482.22.4CC2E7C Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf04.hostedemail.com (Postfix) with ESMTP id A71F540014 for ; Wed, 17 Jul 2024 07:48:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721202495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eBHTvp3HyVxtBSHJufgxLzUtFARGZVUELPBZlWg/CSQ=; b=5mrLQAx2jejarM705JrlkxdJ/4sTg4uttjfrtlnSE+Pj2WSJGabT94hm98Lq56j/pG9VCg 5cXVBtlSiKUL2WkfB1JaL50Raqbvh1Yd7FMhNn5hvUPuhJpPRAkSgEMxHp/HQXHOHEBKPr iun8s6Bi+lfmK8yIP0x2dC3kqVsXSqY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721202495; a=rsa-sha256; cv=none; b=3cN6D+YVRbHAUOk5387FpRwwObX9Lt+CL18mYbsje4tP0lsJX4HY0cKYXUYUZBJGzn9Hnm UW3NEKFYakt/GYgyTz18ABRXE7+K/9l79aCltb2E0bdatGnMkInRGxHxOgYAmd1qqG3oj6 /m3KWkHAl8AWLJAKp+klclEIycxM7BU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WP7Lk3rZmzdj7G; Wed, 17 Jul 2024 15:47:10 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 3A4A114037B; Wed, 17 Jul 2024 15:48:54 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 17 Jul 2024 15:48:53 +0800 Subject: Re: [PATCH v2] mm/hwpoison: reset hwpoison filter parameters in pfn_inject_exit() To: Michal Hocko CC: , , , References: <20240716033516.606582-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <04f8db38-9a53-a81a-82ac-21653f795e08@huawei.com> Date: Wed, 17 Jul 2024 15:48:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A71F540014 X-Stat-Signature: bfujoyxysdd9bes8f3qdytg6xudw6pp4 X-Rspam-User: X-HE-Tag: 1721202538-124967 X-HE-Meta: U2FsdGVkX19TBhFwON/dqmparl3zOpwomc0guj4P+uCxqjsbhWLbptjg4fCZ8Gu58nXonRS+4ClCNYhV/kVUlyFY630IohewUGdHojXMBLO1Ed/TUmgVfGxd99+NShQit6VdYK4xC6OPo30toBclnRkorZXzsqn0ppdNV23C3/UUhhy5RU3sqJ964uwJu7XOdARhS5a6eGgQg4YEiO0i/8yqGcZRzQclh5XdVU0q8qeNIS0u/MxNlqeGC+Do+TIGmGBr0G0wD17Lq2Wh9EAzCKDWmquHLcKmtJJ1J1y8SGfgPsU9ZI7que71b9YvO+40SevzsILtxy8tr4KDaBpZ96dMpKD2Dnp7QUmo46H3fjxH0nt5NfaBMXZ4WhCA6cmYm/pIY05/LO1LMgTd9HWX6Uvkj/pcD3O37L8t7kpPjY66tU7A429++ZJKoESyzBZyLF6SbUPop+kvuuvv/Lsoc60XiLhgH3Qw0YMtt52ItA24Ks5UmYgKqMysYmO0u6olH9ir+b3UXcyiHPI1uev4FM9XmIDzORNKlznl4Pp1Ga9b47qQPmSeDSqPdNVAPGJaiqjs+nKNVNC9pQl6xhPyujF2sVLkz6usQ2Jfno/akwexKedCg5BRRQBZqgrtNKxT5nGY1FR/p1Ou3Z3Ww41Emz56AZ9TFnCf8sPhOQsjarEoHHU6jH1fV5PQZxrBrCPgEgKThHFdQ/2d/3bJIE8DNY387pz92kgeZu39A/GvgKb3NjBW/XX3WDkEMHMEwDf32f5pd/hAdQbKwRQ3pbjk9VbrYwnFyr9bsLwWKxXMTL3CtMORcT9udIHYTdxagA4JMOz+1GtwUEIqpCdR2u8P6YlcBfMSxcPkoPDucQxp0L3b0v/xJ0bVoXIUHOnZtuCrAF//FkRdVUwe5ITdmDKQpXNNHJg5fI+lm2zCV0yWaH3EVJqd0PTdDAm6I1QdD/O9m5yeTD0wECkELW8H1j3 CVwA6yRi FJFZG/H3RhgVAUy8hkL8f12J8Ui+lympHmsyynhjGcjRNUxIJCUomcGh2LgIvFl/Mqw9bOvs/Z4xgshrf7JQvEsM1aS/Nw/dwkpLCrqYGufsDZKscfKBrLEssKOPGAobHciKKIaweGxqjCzXuSbCitG6kJOPfeGM2RbrIN8IUKfzH8hdzTvKSqCkF7gt5RoZBvUg8iDDJqafL7nz97obr+Qin2Cbc0JxlVnYp8oFfmTT++26VmWJAuk8Piw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/17 15:25, Michal Hocko wrote: > On Wed 17-07-24 14:59:40, Miaohe Lin wrote: >> On 2024/7/17 14:18, Michal Hocko wrote: > [...] >>> Why does this need to be done through different modules? Why it cannot >>> be part of the memory-filure.c? >> >> This is a bold idea for me. :) I think it can be part of the memory-filure.c. >> So CONFIG_HWPOISON_INJECT should be removed from the world and then make >> hwpoison-inject default on when MEMORY_FAILURE is configured? > > I would start by moving code into mm/hwpoison-inject.c. Whether this > should also remove CONFIG_HWPOISON_INJECT is a different question. I > am not really sure a debugfs interface warrants a config option. Anyway > two things for two separate patches > Thanks for your suggestion. :) Will try to do it when I am free. Thanks. .