From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9126FC369A1 for ; Thu, 10 Apr 2025 02:52:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 338ED2800C5; Wed, 9 Apr 2025 22:52:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E79D2800C4; Wed, 9 Apr 2025 22:52:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FD542800C5; Wed, 9 Apr 2025 22:52:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F3F362800C4 for ; Wed, 9 Apr 2025 22:52:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 003E45C0D3 for ; Thu, 10 Apr 2025 02:52:30 +0000 (UTC) X-FDA: 83316610860.04.D80589E Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf29.hostedemail.com (Postfix) with ESMTP id 25343120009 for ; Thu, 10 Apr 2025 02:52:27 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744253549; a=rsa-sha256; cv=none; b=tORQD2ADnaAcbo01K97QxTjXAkOzB/1n0aop0lSSsaoMp8/7TVVPHOUK2CExQHRjyg4t6E lza1nShcAYQ/q9wQOw8faTUSZk+OcgXtDmbnFNWM+phEG7I9dh3fM7+szxMCmi55jOLPP3 B/JxYxlwPRGNQfSjLLcFR3+9vVQBs2o= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744253549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NhlAlAgrMjrXeu3cV+Zf+3vS2pZpg3EV8PLQnUhEbKg=; b=TZpiy0AMVqiOPJ9FJfbWxshpMRqZ87SEzFnX7UbzTmesySDJTOgaja1q7OZB8Ty9dhifak CeNag6wsUNSCkk62/uqSs76YxKYTk6saoIVpBGoy5BIkT0scMxpz2Ac/k7/+Ofg1gG+iM6 0T4xDnn+3Nz/GXnhwSMZAIqb/U9cqCo= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4ZY44h41zSzvX2s; Thu, 10 Apr 2025 10:48:20 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id D3FE6180468; Thu, 10 Apr 2025 10:52:23 +0800 (CST) Received: from [10.67.120.129] (10.67.120.129) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 10 Apr 2025 10:52:23 +0800 Message-ID: <04f4cff4-be7c-48d8-b24e-535ccc67d908@huawei.com> Date: Thu, 10 Apr 2025 10:52:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] alloc_tag: handle incomplete bulk allocations in vm_module_tags_populate To: Suren Baghdasaryan , Andrew Morton CC: "T.J. Mercier" , , , , References: <20250409225111.3770347-1-tjmercier@google.com> <20250409171238.494fd49979b4607bff9791b7@linux-foundation.org> Content-Language: en-US From: Yunsheng Lin In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.120.129] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspamd-Queue-Id: 25343120009 X-Stat-Signature: zd9ruudgr7qqmr15bs9mqg55yxzwmuax X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744253547-575996 X-HE-Meta: U2FsdGVkX1+LED+Mofte1LVM5HKOgxrVrCWosSfLTb9+Ti0uuYg2FEaIazpy6gRheI7IQcbRVN+OEWzY8aEOf7/ARX3jVud6LbyNKBzxs4jMW5TmHlOs+oDZapvhqQU8GIA8GuM+ZaiDtmn+9fCpIqTLaszkunBOd23OMtzMWR2icGbY/jwPaUsmTXZz7qQkjOFWrf1I4CB4PgwBMBx8NOEVs6xpTELHyN/V52nzNjlaKCxquqo/NCgt4FDj/Zwo7WgKhd40irJ3qzUufh77aUiY2yRWJoVosnEWXuPf1FIYeV9xlYxYA7m2q9nSGaXgkpP/6prWeNz+7qQN5aN6aEKLRSI1gKJL/3E+e5vofJr6hxxjP5sMmj4XXpnLyYoBCoiZenbzM51HKfeqsis4yTSZPtyIGRm6wljoZYWqW/0axusb1tbGUDq9e2JCDrF3EbwgK1D8CDN1p6wtef3GEYH+WmBnqlHSQoDY2W6RMUCELnuJVrB2g/HGjvXObvMYfOEGbL9YZjIar/ZMuDCS5QHhE1v4fXICKq1gNJuvVBGoIS7cNs1IK6ES4nG1s1IHgq8EFRj/x+fxpbmY/cKKMLKKfs0ODqCjrb9H/9C8FV6VUaxtVij1UZqKHbTfJcaW8BK7jgJncS+St3zU/cc2nwa+A1aOikfp7j3dvYj/wb59dES5GAcyXtjzqQivXchAdKh+HoHeQrwOTw/wUS4eSXxQNwsH/rAeMnTLRo6dfhMLklv1doBcNGjj545TFKQZySUnhr3JQDySPTWe5IiKIu7GKJ4s0YB2W7cBmcufjRa2eJ23KSKpPG6H9UGiB4apITw/+3Xr1zD8gXm6lOKtlgfFDImxlztHmXledDILYcCrDzE55Kyc4M3qTNmPYnR6AzXHWiZ+Od4pFP3aRF9N1dw/2iOsXhFmtfj/zdJuGQhd1jcx5dOHOiLdusGybcHdmZz5Jz1TSpfzUF37gkL xVQPG7jN 7IcfrhJ/C+LNauyiOE8JHmvqP7EEZbRuEhbSYloCAPgckOiaeWzlY05fVjdaKuOIBhMzhyKR/Tfajs2bYXbX0GWcY5n80EqMYRNMID96BndzRD7kLQ1HzqX8RPKwphzUQb4hcv2g7tmsCAlpA2QPq26H/1KMVet6M+S1uCyb3T4UrDMWGmduHldhn5cHCH2MswjVyMeDt5vAf2GQiKnPxxRR9q61F8cbYqmpvAO2g0p6gs9IphNP/XksLsHZVHgqzTRak91yQVtRmsFgHO5MDpUW5SUbIJf693AXTeStsTLtEqwv0ey7XHMg8GfmY/aUx8ciAJ0jq/soSnhw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.043874, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/4/10 9:44, Suren Baghdasaryan wrote: > On Thu, Apr 10, 2025 at 12:12 AM Andrew Morton > wrote: >> >> On Wed, 9 Apr 2025 22:51:11 +0000 "T.J. Mercier" wrote: >> >>> alloc_pages_bulk_node may partially succeed and allocate fewer than the >>> requested nr_pages. There are several conditions under which this can >>> occur, but we have encountered the case where CONFIG_PAGE_OWNER is >>> enabled causing all bulk allocations to always fallback to single page >>> allocations due to commit 187ad460b841 ("mm/page_alloc: avoid page >>> allocator recursion with pagesets.lock held"). >>> >>> Currently vm_module_tags_populate immediately fails when >>> alloc_pages_bulk_node returns fewer than the requested number of pages. >>> When this happens memory allocation profiling gets disabled, for example >>> >>> [ 14.297583] [9: modprobe: 465] Failed to allocate memory for allocation tags in the module scsc_wlan. Memory allocation profiling is disabled! >>> [ 14.299339] [9: modprobe: 465] modprobe: Failed to insmod '/vendor/lib/modules/scsc_wlan.ko' with args '': Out of memory >>> >>> This patch causes vm_module_tags_populate to retry bulk allocations for >>> the remaining memory instead of failing immediately which will avoid the >>> disablement of memory allocation profiling. >>> >> >> Thanks. I'm assuming we want cc:stable on this? >> >> btw, it looks like the "Clean up and error out" code in >> vm_module_tags_populate() could use release_pages(). For the 'Clean up and error out' part: next_page[] array might need to be reset to NULL if user is able to reenable the memory allocation profiling when the above happens as the current page bulk alloc API are only populating NULL elements. > > True. I'll add that into my TODO list. Thanks! > >> >