From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F4C0C04FDF for ; Mon, 31 Jul 2023 12:08:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDE6B280035; Mon, 31 Jul 2023 08:07:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8F10280023; Mon, 31 Jul 2023 08:07:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5647280035; Mon, 31 Jul 2023 08:07:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B45E9280023 for ; Mon, 31 Jul 2023 08:07:59 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 609D11C99D0 for ; Mon, 31 Jul 2023 12:07:59 +0000 (UTC) X-FDA: 81071783478.22.DF86422 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by imf25.hostedemail.com (Postfix) with ESMTP id 6FFC6A001D for ; Mon, 31 Jul 2023 12:07:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ckvKa3Zx; spf=pass (imf25.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.53 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690805277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RtmERFMlZOzYX/xBspxMX5ThTF00TCl7wQ49mzpQ0/E=; b=m9LncBGs7/+5cj0UQ78/H4RSi8JGQiNcquUTI3TJJsF0B/iLqmaUV7GR+TMEjdcYZweV2r 1drC+aywMfpoDpI+32eNje797xg/FfPt5U+/4TcdRSs7+237Za8HDo0uvOhIcPOTr/E0Ni pwOpN3a1vHZqNSes5JC5LuvqsPSkmnM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690805277; a=rsa-sha256; cv=none; b=nXpPbRnjJh6Mis6/aBhJ6zoPOfcieUk75cOqo3u0airIxlxUH84PYReWS0ZpzXK6dBqskn CyxIdq3YKiPUrdmGlzKlFsUnWMvGeT4KwJch+30Ewgc+nR1/V4nHmgGf4pBixL0dG1cyd4 cLcG1abr0l1gbXZOu6mXVMFhbebYr3w= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ckvKa3Zx; spf=pass (imf25.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.53 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-31759e6a4a1so3980390f8f.3 for ; Mon, 31 Jul 2023 05:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690805276; x=1691410076; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RtmERFMlZOzYX/xBspxMX5ThTF00TCl7wQ49mzpQ0/E=; b=ckvKa3Zx6KLTC/M6VWdrDZz/SSn75QqFRlMc0INiSsSBx74N0XLvwMHXr/+1kT27eP 2VJgFZt4x2XA8zK/QCSOllF4qlJL0zdlWeiSenxoo5XA6bg0BWmo4iAsdwWj5iJRGauk wDEn65j7MAM1S5M1tIugT7l19Cfb4tdy6ef+XqorZf5v2By4dSwzVTenowDcofckzNyO K3OktzO+ncq6RAs2ijzNHWsQJJW4olboxJSVETmXZPSjGFq7VH+zra5n0r2r2pTXta7N Q1Jy7aFI41e+av0nqqcbhUAS0OF7+1gTr+jZqBOc0NfGDi0XeErtkvl+rKkCg5HXkczs 4qsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690805276; x=1691410076; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RtmERFMlZOzYX/xBspxMX5ThTF00TCl7wQ49mzpQ0/E=; b=EuiZ3O0t5O5No4MvY0C6rRjB10vGmx8xaSY43ugjKPIcY0ffCwKhC379wkG8YPE6Y7 NVocJ1D54wfAPQDuWskp6z/8xtj2+f30JdbYaTIZiRnzLlfndspF7bjSRb+HJkMTPb2R stPFrlCNaZxGLqbPgwu701KvRo+vEJKh+D4SWXjkxcTUxzT8/+sErkzLhlheUAxpyVYR BZEDvLifIe1B/RdhSF6xAyp5uGk0rZIAMsalD8wxXfaERmFo+9m2ED+1bbGODrr/HoYv u8meaQ8NYOohWGfUGBsLhDuNi06vA6mkTIYZY1GcZJ02LAiwjWbM35L/WE9qmhhvLNa+ spKg== X-Gm-Message-State: ABy/qLat3ysOsIAUDBAwiHZA/x5x7e9Q/AzT6nleNDUO4DkDqn8BiJWo ksMcRwQP6PGbJJE7rhGmOYQNcw== X-Google-Smtp-Source: APBJJlFr6e04BsmGj0Si0aJ/H+RJXUxKxJY/Gls37u74uRa2g6gDjuh0SZ+KHpB0+aEfGznvQoXMRw== X-Received: by 2002:a5d:6889:0:b0:313:f548:25b9 with SMTP id h9-20020a5d6889000000b00313f54825b9mr6424281wru.40.1690805275895; Mon, 31 Jul 2023 05:07:55 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id q15-20020a7bce8f000000b003fe20533a1esm3193045wmj.44.2023.07.31.05.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 05:07:55 -0700 (PDT) Date: Mon, 31 Jul 2023 15:07:52 +0300 From: Dan Carpenter To: Steven Rostedt Cc: Valentin Schneider , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 06/20] tracing/filters: Optimise scalar vs cpumask filtering when the user mask is a single CPU Message-ID: <04f20e58-6b24-4f44-94e2-0d12324a30e4@kadam.mountain> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-7-vschneid@redhat.com> <20230729155547.35719a1f@rorschach.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230729155547.35719a1f@rorschach.local.home> X-Rspamd-Queue-Id: 6FFC6A001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: yx71891hd71455btud9465kiy6t89rud X-HE-Tag: 1690805277-869985 X-HE-Meta: U2FsdGVkX1/AJVEZC7ttPoOV9E49CcCKDdDPnMw4UO6QRcns0K9OauxbFqg7sDx3rp8ovNeT90XYzDCpmOYKMbIKYeztaJm591oCK9GAJiQZkEm6Gj32uNTVXg+bquMOPuOlP68uWF9At4mQ63E0T6q9dPH8o6hrb1gWOKD042emB7ZzoLmP1j6Hq48nSKEuzX6H4kNY3azw/dAfefxl8K0e1W0weOQ359tN57/Sck2qmQnESUsexHbY1HrzjYv3e8oTdVFP2KNaEM0/uoY3jIrJ2/pQOy26ZpaTtUFKCSMmRXWsOnmggV6XI6SmhmFabpktxSmu34ffTGevVFeOHS83svOdOllT/xc21jEpz6DswQOF1K0/h9QZjx903Mlwy7QIn6p9jC+UKJ3I2tg4TeXMZPHmU6Gt90IDnfxFp2NHkbjLfz9IyOBERCnL+FsJuCx5gtM9QTLkXp6t8/MkG9hJMEr3470cF7W1uLcKfNVsRnOgTBTY7hRnHPj8jq9HZVoVGLarByIUgTHF6Q4+nrhYXlkIS9JmO4ni9aukkFY31HgJrUMEGQg+R8fc7aLHMGw+AHRwgOZDooy+HzOf2eVK1wTB9c+F2fBFZZU1/2L1s4TcmcUNH9gPahNORsnDD7oCSqINruvfEodDMnO3CgIJ9RQ15QevmqVWb1r7+C1bcVoSxBigFYOUBHZpMqGz14h/PYFQkqtj3nCuR7x230EHAcVssxKM7gdfjuJHvSeoML1qtDdPR5b8E3WWjV/SHjrk848xbSUOOQFQjLbOCVHzhCzL0k5iU/ps8XO+Ow0bNm9USX8G3cAlguvD9stwXIuInKYh0xRDaRYH3Q1ahcMx+32OFLjbeODs/oK1/9eL+X28g8ITvWymicJ1JEAGcDwJBw6kfg5Hami9pj8l9FdmDSPytB1eFVi136PeJkWj1ETcTcRgFL0Eq2J1oZbNDVyUjlta1rGRp7wDdH8 E5DGT3ye MR2a5k3Pydwefra8JL98g4R6KRBl+Y8ssvnXygIv4+ACApboGpRhZ2TNmhFOYACqBADzj53rAdFM0ulF3XqEyA2TMJRE8gFW5m7tF/LLG0I8vLRA44tAIrp3eSgUuZ/oPx22frZXu8tUg612RmmZOnVte1aClh2cvEcNRAtT3bHbYclce7ThZZhUCdI6vRoJSnhvNIJUvIsJ0IKsNKvEkG8bhvIN1jh5V6eHbiNp5yMNHrLXn7eYcTkUtXXqNnW7DaA/1wP9C6sAAeYd7VuaiP7t0Azya800CeVVcgrLZZUBDvlVY5KMDuSJClmuKQWDghmjxmHLBTu5WRvivTsdShQK5hbmOqg9/MNDUOpDoWsx/Xorf9z0/wEKFX0NUt0WVTCTN2J0yHY3aFNNhfacnxjPN3BjzEzZTREiuVN2shQVT+z1lfsQsajk1wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 29, 2023 at 03:55:47PM -0400, Steven Rostedt wrote: > > @@ -1761,6 +1761,11 @@ static int parse_pred(const char *str, void *data, > > FILTER_PRED_FN_CPUMASK; > > } else if (field->filter_type == FILTER_CPU) { > > pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK; > > + } else if (single) { > > + pred->op = pred->op == OP_BAND ? OP_EQ : pred->op; > > Nit, the above can be written as: > > pred->op = pret->op != OP_BAND ? : OP_EQ; > Heh. Those are not equivalent. The right way to write this is: if (pred->op == OP_BAND) pred->op = OP_EQ; regards, dan carpenter