From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F7AFC27C52 for ; Thu, 6 Jun 2024 20:18:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A033F6B009B; Thu, 6 Jun 2024 16:17:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B3286B009C; Thu, 6 Jun 2024 16:17:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A19B6B009E; Thu, 6 Jun 2024 16:17:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6C14E6B009B for ; Thu, 6 Jun 2024 16:17:59 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2253B1A1713 for ; Thu, 6 Jun 2024 20:17:59 +0000 (UTC) X-FDA: 82201575078.21.FDA46DA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id C0A1A1C0013 for ; Thu, 6 Jun 2024 20:17:56 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=D7ll0qYy; spf=pass (imf18.hostedemail.com: domain of "SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org"; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717705077; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NLn3SKG7Qv9or2Q9LQbXVEirNT7NtLFu/Ub1LTXoT/E=; b=XFlQgBYpTCc6gcFkDbLWJrmdnOecgWyC8mxmMnQ0Cj7mTWxSniWxWJ5Z1l1YNg5cGY5oDH LMPQfpzLxnGqYVIA0sj5IG/ckZcN6cuGwaBWJgTe8Wj6AcBASYBM7cIcj6xwvXbaJeZI6z ooIaOJI8M5AZ60rufAKfFh0OPSvIlSg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717705077; a=rsa-sha256; cv=none; b=YQyxQw+YVxCCxQXw3vOPrBLNUwTC+nonJKa5v79lsaH9D14FnGBYycM/0+VUMLZtNw1Te1 IOFb57AQIvpXrHxJp8vDNILHsMiaTfn81RNG+IiXSxNOqYXtTZjWrT0XzfafemxCTScEzZ pLwpv0wEqVZISY6ncOoEWb7ptCSXJag= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=D7ll0qYy; spf=pass (imf18.hostedemail.com: domain of "SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org"; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id F3F82CE1BC2; Thu, 6 Jun 2024 20:17:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44B77C2BD10; Thu, 6 Jun 2024 20:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717705072; bh=dx6bcYfXV1SsrXcEAk9+8Tahom5shjEJqNgJxSC5+uo=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=D7ll0qYy2mDFGwsDsvQitNmg+2UP9O14St6XtZh9w4br7741OM3l8DJQT8tQS4lfh XJ9adLYcZf0XKVJjXldGS8c52Ma2ppN9VivDNgbAXeq2Jz7GK8R++SxKNgjwW5yA1i Ym7E6ZspfBUGgANB3cskL8clbMs2fLnoK5+UCeeiF4Q+8APfjTSAuakKk41CNs96UT XteNmOyTHd32UpIkfoWVh5zts7OlHP0HDYQYS7RV5xyeP/bpHZvvvy/TdzP/BZeWVG wI84S6aqgY1Tch3cmF7mSrXUXGz/Mbxx+ieybuCyzR6B2QEraXuNxejPkGsdnvFuLq SC2AJHDetbQYg== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id E7A41CE3F34; Thu, 6 Jun 2024 13:17:51 -0700 (PDT) Date: Thu, 6 Jun 2024 13:17:51 -0700 From: "Paul E. McKenney" To: Mike Rapoport Cc: Jan Beulich , Naresh Kamboju , open list , linux-mm , lkft-triage@lists.linaro.org, Andrew Morton , Dan Carpenter , Arnd Bergmann Subject: Re: x86: WARNING: at mm/memblock.c:1339 memblock_set_node - Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead Message-ID: <04eb89b7-9d63-4b06-b553-2cb2095539db@paulmck-laptop> Reply-To: paulmck@kernel.org References: <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop> <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com> <20c484a5-d797-4782-b5b5-bea5fcae9284@paulmck-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: dmzfdyindhr5kwmsdzkz9bui68aeh7gn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C0A1A1C0013 X-HE-Tag: 1717705076-859092 X-HE-Meta: U2FsdGVkX18NVCMA+/PaR2yYMBDq1FnmSk5XtPbVRzI77/6Cqbejqx5XjE9ike5dll6Aa+2L58NEsvgAT+//0jONBJuuKET5mlUlZFs0sw7gsPOLV1BcWKN214xi9Tbzw+my9pd4cFsL3LAoyvx3clMt98aXTX3FjLkO8+JEmZFFW9g9B5C06lp8opkCpyJrE1FGWUkNNhLaS/44M6LDbQ06bDqZm8+1yQRq5YM2jojB7J3K6cikOTh/1/CX4VRthNEplc4xaihuCDlPJtCl/Gg2ZJ+vi+klMg2E3mwypz2HEpnyYZ+gEpMPdHseOVr7GKipqiszn3cdLU7hFkU032uRD6+u9s3rg3b5sYjskk9gW8jqc05dbQ7hWHAzHIStETJtQX4Kt5sf2EHaw+pyhTxfqFfmlNBiXWlu6eB3IRxuDsy6ooTDfjlq+xnFqMeIJ7tIDhgfKjj+50s/avAV/VydAJZbG8N0cQWmDXAjTptgRVtnwjCkF143Av1cRd02d7NcvnD7az4d5q3fIE6eBM+oJOAVcRosj5VuB+ISn1duEtMiSZP8BWBMRHjbtJg15zbWz0/Q6lQfGOuS3nZ9VjWrD+RQFWlaq+j44TillocxYAuc1D+yOf046eSImj6gl0wnhb2Ynx1Msi1/ke3yfVgHb4WQL868nyibz4Qfs2wW2+JEBv53hn+G3JOVt8RM/PCT3uqyE2LjoyIKNJB1MakiMwaawPPLLu7y/hR74qA40zP2LUYdzABes++rnWwJ0rJcTlU1wnQZvIj2ibUlHlKmHZRJPkageLlLPEqLo8dq+44S881g3ch/GvIc5C3oynoiG7wODyIiaf6yAydM7H5lVku4mC5dvnllh07mjWtqDAlEA2SRt+fAQN/RJf1S3aSlTUM9dqKo9O7rAfDH1h02kYrKDB0XE0aXyp4M3xUpfCAdAdzN0vi9Es5Bd2SM1PzLiaZRVTeX+a17LAA QYcvl/DY SpZsAWhhSczf4ghjrMgQ39CB4OePujiECuuw3Ytp52WS/xTFXKR6Hw9JAzRnmUGLIWs9/XXlMMAc5FizvEdeKx/QJIrxdM9ZLP5R3BayltkOi/ODZda9A8XUQCCEE+FnSD854bM0/GvdAHkLBFY7rPCiqMZRJjUlml4cacMsjlKiIx47q0jEljf+JwnBzWWOwEKZ3l1udg4IbPB2mJ8c0JPBLUozSj5CdG1JJxDGpBLKGRGtM5GMKzvhKtSLAPZk/daK+vdSzV9HTgxPkC/JxuGLbRQ5uiJCzKJDq6QncNSbN1vXESMwUfEFTdP8cGlzzygHzGX9L8fFHCANVMoVx2TSEcA5J5JW8loOqUJejlEcG/dI9NEgNXJXQeLW9w71Jl+H3fBYIy3AAEIN61vgDLbfBv8sMAxNbu9Jm1IjusCTxhzlX4WZ5dnQ+mK3B/xGz1th9IIhvV8by9Vj7GbPjp/U5BlJY6d62cxABDWku5HXLRp4mZ3U/USr6Qmat9aLHN6z+m4z2Yte2Zb3z52eh3E4NT4DQDHRDOtTlFP/qvN4sPS14PGZqxGCoVOMNGUkVcSTOC6HKecerNOXzUG7TO6qWOeNLKI+GQi2n5m/MzDn/vC2fGd62ey0CofLhu07uxUBptoG3LtayjHmHyr4wXLlOm1ECXfNGaaqa51Yk74EMB8Syh00dzRm3M/8o0VoQU6DL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 06, 2024 at 10:48:01PM +0300, Mike Rapoport wrote: > On Thu, Jun 06, 2024 at 11:04:30AM -0700, Paul E. McKenney wrote: > > On Thu, Jun 06, 2024 at 07:19:40AM -0700, Paul E. McKenney wrote: > > > On Thu, Jun 06, 2024 at 08:13:17AM +0200, Jan Beulich wrote: > > > > On 05.06.2024 22:48, Paul E. McKenney wrote: > > > > > On Wed, Jun 05, 2024 at 09:46:37PM +0200, Jan Beulich wrote: > > > > >> On 05.06.2024 21:07, Paul E. McKenney wrote: > > > > >>> On Mon, Jun 03, 2024 at 07:19:21PM +0530, Naresh Kamboju wrote: > > > > >>>> The following kernel warnings are noticed on x86 devices while booting > > > > >>>> the Linux next-20240603 tag and looks like it is expected to warn users to > > > > >>>> use NUMA_NO_NODE instead. > > > > >>>> > > > > >>>> Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead > > > > >>>> > > > > >>>> The following config is enabled > > > > >>>> CONFIG_NUMA=y > > > > >>> > > > > >>> I am seeing this as well. Is the following commit premature? > > > > >>> > > > > >>> e0eec24e2e19 ("memblock: make memblock_set_node() also warn about use of MAX_NUMNODES") > > > > >>> > > > > >>> Maybe old ACPI tables and device trees need to catch up? > > > > >>> > > > > >>> Left to myself, I would simply remove the WARN_ON_ONCE() from the above > > > > >>> commit, but I would guess that there is a better way. > > > > >> > > > > >> Well, the warning is issued precisely to make clear that call > > > > >> sites need to change. A patch to do so for the two instances > > > > >> on x86 that I'm aware of is already pending maintainer approval. > > > > > > > > > > Could you please point me at that patch so that I can stop repeatedly > > > > > reproducing those two particular issues? > > > > > > > > https://lore.kernel.org/lkml/abadb736-a239-49e4-ab42-ace7acdd4278@suse.com/ > > > > > > Thank you, Jan! > > > > > > A quick initial test shows that this clears things up. I have started > > > a longer test to check for additional issues. But in the meantime > > > for the issues I was already seeing in the initial test: > > > > > > Tested-by: Paul E. McKenney > > > > And the longer test ran without errors as well, so again, thank you! > > > > Any chance of getting this into -next sooner rather than later? > > Should be there tomorrow. Thank you very much! Thanx, Paul