From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1C2AC28B2F for ; Sat, 15 Mar 2025 18:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 366A9280003; Sat, 15 Mar 2025 14:03:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 312E4280002; Sat, 15 Mar 2025 14:03:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DC5D280003; Sat, 15 Mar 2025 14:03:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EB031280002 for ; Sat, 15 Mar 2025 14:03:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AEE1757B18 for ; Sat, 15 Mar 2025 18:03:12 +0000 (UTC) X-FDA: 83224557024.15.31CC2C4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 5CD4D40005 for ; Sat, 15 Mar 2025 18:03:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pOvvnAfv; spf=none (imf27.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742061791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TxcYWvWfTpFytX2D5Aa/xv5rAouDt22VcPR3LokvoEw=; b=s0p81qKcUXERtQ+PbwMKc3G20K4Zh2l1oHwgJkrvcW/Dv8o3U8myxfd6vMjFHF07j+ZCU3 2jKBKagKAFYbPVfHrscKwak27/90v0Eklell1Q7iMO7SP7VouqO0bVBj5rK7navo2Mhdm3 mGFv3KGtG+zJuzWmf58QjSK+yc3Jvws= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742061791; a=rsa-sha256; cv=none; b=P+Z46fkl45sc9zWFr7xdeoyRcLvttC7vuuxz90oXep1o2M6I2O2gubfGpNqNIUSDNXMSp/ TT0XX+AbuWRv0uGgVFdupQL/IlgNIC+ZxV6ANfdZ2WOu5HcWB+B3NLFgnNkbVLHCMxHNvl Gk5hVgY7V/E0Hoy3peejAEs5aBpf7do= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pOvvnAfv; spf=none (imf27.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=rdunlap@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=TxcYWvWfTpFytX2D5Aa/xv5rAouDt22VcPR3LokvoEw=; b=pOvvnAfvZ7o61cTyL4/lUajVig 9YiQVI4OybWgNI5DYghOhAKjcN6VInSb+GgUAfY3a4e4c2kD/lCDg1tqroTn8KKftmYcnNRcUjS6Q 5wkiyNJHELVsy9EDSUSJePFsyZCYBJqPjs8fHAm13PY9/Q+tuAGqMvwTtDKjdtI3kX5Jg0pd+4+x+ FDTlCX2XXmLVo12aJuWxHXhSEdJR59hC5wn+aEOLQN70li/VQuhSYzF7U0t5D3rQ3K0sBSrvvdPMO RZAgzcBVAHep/5DORO2meRd3PiTyxg6g/CDIpD0jZ/1wT92ImW/ooHNUXdQDENm1r3fYbrU0S6iGa VzYUNgJQ==; Received: from [50.53.2.24] (helo=[192.168.254.17]) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1ttVq1-000000044np-2gfS; Sat, 15 Mar 2025 18:02:45 +0000 Message-ID: <04ea2c10-39c5-46ad-a4f9-e5dc98c77eff@infradead.org> Date: Sat, 15 Mar 2025 11:02:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] slab: Introduce kmalloc_obj() and family To: "Gustavo A. R. Silva" , Kees Cook , Vlastimil Babka Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Gustavo A . R . Silva" , Bill Wendling , Justin Stitt , Jann Horn , Przemek Kitszel , Marco Elver , Linus Torvalds , Greg Kroah-Hartman , Sasha Levin , linux-mm@kvack.org, Miguel Ojeda , Nathan Chancellor , Peter Zijlstra , Nick Desaulniers , Jonathan Corbet , Jakub Kicinski , Yafang Shao , Tony Ambardar , Alexander Lobakin , Jan Hendrik Farr , Alexander Potapenko , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, llvm@lists.linux.dev References: <20250315025852.it.568-kees@kernel.org> <20250315031550.473587-2-kees@kernel.org> <17076519-33fd-4fac-a718-784b9597c9e6@embeddedor.com> Content-Language: en-US From: Randy Dunlap In-Reply-To: <17076519-33fd-4fac-a718-784b9597c9e6@embeddedor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5CD4D40005 X-Stat-Signature: xpufkwxjx3jhxc5f4a3rt6cfi1dhh1nn X-HE-Tag: 1742061790-602697 X-HE-Meta: U2FsdGVkX1/n9Po50YGcXEoI3F3sJea+qex5ONx6l/Z54ySpq1UMALL/CRqlY9Hyn4zJ1wZllCpEbpbPMZCzpxx4eMIq1m3e/TebV1QqAAh39qzGZo5UJsfqMy28nXfGuW1PH1zAh/nUUJVkn9TzS1fP22A2ZOEnvIkZFG2X3ItKpUnBxHr76sQA2V/KOfCXCMqVf1DyvRGH5cIl4UzC9K9K4Y8QpI1bB0Byoi9EeEt5FPcMmoF20hO2MI0PVmI1PKu6mhmnhQQl3+KUpJ8A3dABq3+WjoOKCOBxNRgmCkAzcSaW/w0EBtJbjjfMU7CFPp2izCWOo1eQI0gb1wP+VJKjpHQZQgpzt2opEQbabHEzzpeJ+1RqYGtUM2fjDEK6KJvEviyGUPyjWpv6dzBgDlISFgeoNQoFRLVDbIvzIc8od095Rc5u8dl4XxqeyaJkdeDjzp1SgY8Qor4thUc3okb2s6rMHrx8rHUQeuH0BRn4CK2U2MnpMACz13LlDHv8Ds4+L2PMnrOXuQcCLotFxNA/DKXnDQPuahevgca5hQWGoxKS9uXg/m8kZpEbav7lcqs/VV7ibxRCaUL9S7JjkN9tsHA+SS29WmtX0zQeD/nX253hUQ5DP4zhxWKZ98RdL0R7PGYIsADakXArctikU7k8eln53EOr0Y7HtkVA7pPss2A29TbFgVVC5sDKBE7/hK5PPm3DX9r0T9WG/8ipsYV84I5jl4YYzEtGdk2JCUSD6vzhAicF7kwWvICtrWjapVmzkC21haav/9q2ZlsquBWtIh+fPFRu6IqDlylyGWCJJGzshzSvPNlDy9sEZ/XchuXzsGhgl9r65s3QhLfxcQXUhCxIWIxaDOuYVDj+Eh+sShM4SX8pevCzxsP4Y+NwLm0PtAZNNHfuj+SI6ZCearb7R/RUYr6m4+zT9WY6BN6T7RXcpNUYZ1lnUvjQrI36mAE+JJmQjE8KS/XMbtj w/w4vQIr ZuG5e7kiKQjGkxp8s9Q4BP7unRKaOFps1s3ng+0V6npmYyT01u34jfEoUA10xz3VnY2nmQcfJLE0ca9805sGzc4l2lfk1w53xpfueDVgsFo5GUNmyDkJp8GBL2N4/vI0FZf7GLCstBsNMt+UrMwbSCm3gSnUtiFQMjA+iQbH9DBy7Y74vCQ7xoUgSEU/x4WjtX+a26oy3by29X0yKOSTs+Lhatpo9WHMmpL+bXlU5Y1l4UWosvwuTu3lHZ8FRqFNYsm+fD1WRnKC/dhuNQL9U4XcLJe+IJiGJbmoxjsHy5mDKSJYcAPuzcpZujKlqii92jwTE4q5I9s+2FMOOCYCHCKk/CBd6WjaMcjoOeXnPYL3I61XC1TssFWBHYyg8fvMwFXnAueq3RDVoqbjzaOxbW9toZYQCU6RVkDFw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/14/25 10:18 PM, Gustavo A. R. Silva wrote: > >> These each return the assigned value of ptr (which may be NULL on >> failure). For cases where the total size of the allocation is needed, >> the kmalloc_obj_sz(), kmalloc_objs_sz(), and kmalloc_flex_sz() family >> of macros can be used. For example: >> >>     info->size = struct_size(ptr, flex_member, count); >>     ptr = kmalloc(info->size, gfp); >> >> becomes: >> >>     kmalloc_flex_sz(ptr, flex_member, count, gfp, &info->size); > > I wonder if it'd be better to keep the gfp flags as the last argument > for all these `*_sz()` cases: That was my reaction when I reviewed the patch also. [I just didn't express it.] > >     kmalloc_flex_sz(ptr, flex_member, count, &info->size, gpf); > > Probably, even for __alloc_objs() -- ~Randy