linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Wei Yang <richard.weiyang@gmail.com>,
	akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
	ziy@nvidia.com, baolin.wang@linux.alibaba.com,
	Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
	dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] mm/khugepaged: continue to collapse on SCAN_PMD_NONE
Date: Wed, 12 Nov 2025 10:51:09 +0100	[thread overview]
Message-ID: <04e8e813-b43b-423e-8ad9-fb13ac953055@kernel.org> (raw)
In-Reply-To: <20251112020031.25350-1-richard.weiyang@gmail.com>

On 12.11.25 03:00, Wei Yang wrote:
> SCAN_PMD_NONE means current pmd is empty, but we can still continue
> collapse next pmd range.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
>   mm/khugepaged.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 7e8cb181d5bd..4c2217076ad3 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -2835,6 +2835,7 @@ int madvise_collapse(struct vm_area_struct *vma, unsigned long start,
>   			goto handle_result;
>   		/* Whitelisted set of results where continuing OK */
>   		case SCAN_PMD_NULL:
> +		case SCAN_PMD_NONE:
>   		case SCAN_PTE_NON_PRESENT:
>   		case SCAN_PTE_UFFD_WP:
>   		case SCAN_LACK_REFERENCED_PAGE:

Looks ok to me.

I am really confused about PMD_NONE vs. PMD_NULL.

Is my understanding correct, hat with your patch we can just merge both 
into a single NO_PMD_TABLE or sth. like that?

-- 
Cheers

David


  parent reply	other threads:[~2025-11-12  9:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12  2:00 Wei Yang
2025-11-12  2:37 ` Lance Yang
2025-11-12  3:40   ` Wei Yang
2025-11-12  3:58     ` Dev Jain
2025-11-12  9:10       ` Wei Yang
2025-11-12  3:33 ` Dev Jain
2025-11-12  9:51 ` David Hildenbrand (Red Hat) [this message]
2025-11-12  9:51   ` David Hildenbrand (Red Hat)
2025-11-12 11:27     ` Wei Yang
2025-11-12 11:41       ` David Hildenbrand (Red Hat)
2025-11-13  2:44 ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04e8e813-b43b-423e-8ad9-fb13ac953055@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=npache@redhat.com \
    --cc=richard.weiyang@gmail.com \
    --cc=ryan.roberts@arm.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox