From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403EEE67805 for ; Sat, 2 Nov 2024 18:56:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7EC56B0083; Sat, 2 Nov 2024 14:56:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2E6E6B0085; Sat, 2 Nov 2024 14:56:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CE2A6B0088; Sat, 2 Nov 2024 14:56:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6E6F26B0083 for ; Sat, 2 Nov 2024 14:56:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DDA3F1C70C6 for ; Sat, 2 Nov 2024 18:56:30 +0000 (UTC) X-FDA: 82742059470.01.C03DF79 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf22.hostedemail.com (Postfix) with ESMTP id 03444C0003 for ; Sat, 2 Nov 2024 18:55:51 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZxGN4Dtc; spf=pass (imf22.hostedemail.com: domain of mtodorovac69@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=mtodorovac69@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730573626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NWC+gjEyCqr5E3blGfY3A7hEvdkevCUpxwSqcipkieA=; b=d8pbfEd8lJUV8EV7h1X+PuRFlwBuNlSEp8DeGW+L7vuFJ15T6JX+BOk5gBWRcG2oKlaeL+ amEDjGZDKMnP1jG+XpdzzFysgdXXfBdIJRIIbjGXshVP0uj8Hw5Do0mWmeWr9k9e73Sg6a FE3G8y9UNtgEIZtpJy3GDfjmlTe0Ux4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZxGN4Dtc; spf=pass (imf22.hostedemail.com: domain of mtodorovac69@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=mtodorovac69@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730573626; a=rsa-sha256; cv=none; b=aWs5SWw8HgbB2xVBnZ5pjTk6rXkKa2+wGB5QTyR6jhG9sTUysSDSigUjDIlHqpn5Z1T6dv I1styTHB5uFq6hKT+lumX7tMRM+CnaGkk23znacCyard0R4/QxAo0p2kO1ocoiEAMDIBgx l52vTun26V5kwh5TuU1/45p5fTtD4rA= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a9a0ef5179dso467309266b.1 for ; Sat, 02 Nov 2024 11:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730573787; x=1731178587; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NWC+gjEyCqr5E3blGfY3A7hEvdkevCUpxwSqcipkieA=; b=ZxGN4Dtc8oBVm1zKJHXWbOPTuhj6UFqGhZCHQzgSbddoBxo9ihy6Q/JT5Ntwmq6Etd 27g9qsfbftGw76NtxSCZ5B92yJdxHMxSeEElVm32Ab7CwiQHRWLl4tuZrZrPwSE+66ll rj6/QZRRiahiz9gvpTEybk1KIJ9CnHU68dXtiCuLIHG4mPSR18JngU7Y8gDypFFkezmC s9CWTgpR/IU0GPqQq9c4ElucLxUC3Tq3n7y54ZJBM38U54+8zHAHBeeX4C5XAq12kUB5 KAVV9Z7dDSsF4DKnN9qL+MfT8/e8Xzb2EpMlsW8tX1U/7+8oZGIbTKI2sWaej+2ECXtV V9ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730573787; x=1731178587; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NWC+gjEyCqr5E3blGfY3A7hEvdkevCUpxwSqcipkieA=; b=bl/9jzY4qx+t2L+Cd5OHL3gwbo3y6j69HPqNeXWRC20XNbGnNA+h2UuRmy6iVqjmrL HXSkXiXpkkl+bcMevc7FPSBpoZaP4xDwPavuAL1oiFckCF3spkPW060olRkQ5YbhLiyg o3JjJtPksA3KybdxiE82xyV9/hvxCIWYxhecazh09oHWyUvO2cGSWkkGAQMBXqKeS7YO lEZ/6CqsqWBMEbp6oB8tLau9+LwWPRvx6whhxWN7GLV5W8pZRdba8L06URBb6MgUg+/6 IyzNtG3SEdNfVAbN6Gp7kpLpkBorAK3N5YTkKx/AR+x5JwXvUSgyg1Ln8/7p5Fc+w3JN 5RnA== X-Forwarded-Encrypted: i=1; AJvYcCUBj7m0URT4QUI/PGDmAhKBKTwapWTf5wvQ3ISCQ1OAOTKd4UzZbqw4A50WnmIUZ6OpKRm6j/UBcA==@kvack.org X-Gm-Message-State: AOJu0Yz82Nhx8VxzRFB+cUAyHfwUa3/WZv9h8wEOlNOXL5k+Spkw41Z7 Kzk6Xr45jjaoEalNCiYhcIEj1CADROzjMd8eA9rjD8x0D56trP50 X-Google-Smtp-Source: AGHT+IGEQWz6ooYjGaCSgLNXrz5MuxJzqSOc83IxilSTdsdldQljy0mpnCM/Mqu8m3Q48kAxrDNPOA== X-Received: by 2002:a17:907:31cb:b0:a9a:296:b501 with SMTP id a640c23a62f3a-a9de5f660a2mr2709296166b.26.1730573787115; Sat, 02 Nov 2024 11:56:27 -0700 (PDT) Received: from [192.168.178.20] (dh207-40-94.xnet.hr. [88.207.40.94]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9e566812eesm334973566b.194.2024.11.02.11.56.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Nov 2024 11:56:26 -0700 (PDT) Message-ID: <04b9c37a-d39f-49eb-b7d9-fced64eb12e8@gmail.com> Date: Sat, 2 Nov 2024 19:55:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] selftests/x86/syscall: fix coccinelle WARNING recommending the use of ARRAY_SIZE() To: Muhammad Usama Anjum , Andrew Morton , Suren Baghdasaryan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" References: <20241101111523.1293193-2-mtodorovac69@gmail.com> Content-Language: en-US From: Mirsad Todorovac In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 03444C0003 X-Stat-Signature: sqa1myk4rkkjxfrfe79ghoa1w3qymbrz X-Rspam-User: X-HE-Tag: 1730573751-626875 X-HE-Meta: U2FsdGVkX19kRED5cFci8RQzfNbhPWsN/as144UG4zVak3selTFLmaI1L5ad7TWsJYI3WUOQNMucgsYaQ3pHCUDNYdLWp0qfwKJYm82Okj66bmIgN+R4eOra14lmrpqNtHUiGSM0SkyfXOm7ua9n50W7D7+R/PuWCaJ3eluJZka0Nu8OF+WUNN2sDJDJhEKfvwUk2MBSJJeDAx6Q85Hnh9renQ0IXAG/zzv7qzBKUlgvhFniEhUPLpMi82GN3c+zcESfmbr2kyWcMX/ejTga3AAIjy04hoWfiLEFKoy5o+F+lzJA5oUQHZG20FAV1XllNgn6fS6hqpGGWm0UCwJZqBH6aQp6smHgRc3IJCY9WKrT7DaI1w7Q2gv2njtU4CBIi4dSFhHuyCh/QL8GMHekJmkZ5jsPBfcKLQ5XEed533T727jgYiHlBDl2MDpzPOD4WDh9YdhN72YY19pWStkbEb7Ziskeb26+5xVW056U41wnS/y+7THmrLVpkyXzh0YeAp/dEaSzcVt3+JI5GZ8ZjOxB6Y4KLk0EHwqvHt/T/ieKOlR1RT+mZPTKU/j4VmsA+xJ5T2QK69xDhvW58TZUNgw75cG+HKXdRLQH/Z8xaTHPHebRaXl03xOKL/1P4WTD5dJlyg5Ls2KnYQdtnkL797vVjEarMsInDTxZ/3U6wp9ej/wPyrwW517RHGzkHDh3mDruyZT5bm592Z77Cch3p1tnVivdzDx9bWatLciqYsx/uzkdsz+Xveh5V8pw8V8SuUCkS/Ee1TArOQKfOdsGElq73uApVb6mNiXTAc5tzCb02lGdisk04gGVWVOqgJBxyMSC2cmKoK/PNFE9rqmE3I7ktPqJpnkthYDMTeCreAZ9cWWEPhbyW9A6QrbXiPtTkIRJdRjLB+DfrZG47zy5AQNcDL4P+LjTVk3QR8B5oSPVtuYKbMN2Cfqoh2LO0l+FRcpr5LUBmtpDqRASqRg oGSswltn SaxHlpgSbroWTXo+havbqUg0eTnUXbAhGhZd6XqXgv6CxpTeKkRdoZeZ19naCOxfFs84Xiu41+zFnTidlBtINypYjd8FI3xf2kl0bS8PtPb8LPCG+mg4Vdw+HnMCRTsjfhD08VTgVMP0YZlhPAp30AJOrvwuNiV9oCf8PadMbq2iEWSzAcDuo/RsiBGsZTI+A9yRBYxAZb34N5y1OiOVBuG1NIWhxZF8NIXdOqTfm2TviLyYFe58eqtt5jgfOEXJTxPAVM1J/eVK6lMzcXNDK1xw5cpWwrPumnDpzMQH45Orfc4upKC2P6Nxcy582FAf2DrY6kWjXy4ok8OGIhlV5tdH5k2tC/3aurYe0k4l83GvqRauoYqg7LrXe5yLV+WlGfXnkKwPwpgdssRZvnoRx3FywdAxLY5nozCogTArLTSdXn8N27kvtC6hAwJ2NObvBcvlDxt4+KzhK7kCpCKz8+5EXa+E62u999LiNZsdAxZ8qhJ76wxtFvhxUg8e96yTEsQT+6ccQT045IXrIhyottbLpg8aMGJAPFSdZg+vbmevTllzAOp/9XZqSowWdVsFbdUrxtYAt+o+AYZLgV/eDEpFYnefdE7sWmC01y5pRIW60yvaoeauena1Nhk2SXZhjmAL8IZ6G+oJvXbozin2IwLNkJQ3XoLaOL6KF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/1/24 13:04, Muhammad Usama Anjum wrote: > On 11/1/24 4:15 PM, Mirsad Todorovac wrote: >> Coccinelle gives WARNING recommending the use of ARRAY_SIZE() macro definition >> to improve the code readability: >> >> ./tools/testing/selftests/x86/syscall_numbering.c:316:35-36: WARNING: Use ARRAY_SIZE >> >> Fixes: 15c82d98a0f78 ("selftests/x86/syscall: Update and extend syscall_numbering_64") >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: Borislav Petkov >> Cc: Dave Hansen >> Cc: x86@kernel.org >> Cc: "H. Peter Anvin" >> Cc: Shuah Khan >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-kselftest@vger.kernel.org >> Signed-off-by: Mirsad Todorovac > Reviewed-by: Muhammad Usama Anjum Dear Sir, Thank you for your positive review of the patch. There are much more suggestions by the coccinelle check, but that's a substantial work to do. It would help to set some priorities in this by some more experienced developer. Thank you. Best regards, Mirsad Todorovac >> --- >> v1: initial version. >> >> tools/testing/selftests/x86/syscall_numbering.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/x86/syscall_numbering.c b/tools/testing/selftests/x86/syscall_numbering.c >> index 991591718bb0..41c42b7b54a6 100644 >> --- a/tools/testing/selftests/x86/syscall_numbering.c >> +++ b/tools/testing/selftests/x86/syscall_numbering.c >> @@ -25,6 +25,7 @@ >> #include >> >> #include >> +#include "../kselftest.h" >> >> /* Common system call numbers */ >> #define SYS_READ 0 >> @@ -313,7 +314,7 @@ static void test_syscall_numbering(void) >> * The MSB is supposed to be ignored, so we loop over a few >> * to test that out. >> */ >> - for (size_t i = 0; i < sizeof(msbs)/sizeof(msbs[0]); i++) { >> + for (size_t i = 0; i < ARRAY_SIZE(msbs); i++) { >> int msb = msbs[i]; >> run("Checking system calls with msb = %d (0x%x)\n", >> msb, msb); >