From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25E9CC3DA4A for ; Wed, 14 Aug 2024 16:28:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A885D6B00B2; Wed, 14 Aug 2024 12:28:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A388E6B00B4; Wed, 14 Aug 2024 12:28:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 900986B00B5; Wed, 14 Aug 2024 12:28:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7008D6B00B2 for ; Wed, 14 Aug 2024 12:28:14 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0C0F6C1050 for ; Wed, 14 Aug 2024 16:28:14 +0000 (UTC) X-FDA: 82451383308.16.C175241 Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) by imf26.hostedemail.com (Postfix) with ESMTP id 2889E140022 for ; Wed, 14 Aug 2024 16:28:10 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=proton.me header.s=izgnb2xml5epbownengd5anrua.protonmail header.b=QQsAdwZs; spf=pass (imf26.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723652879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NDeEv674K9CkcHgDcHkn+qiS/pKjJ9GtImDj4uiP3aQ=; b=uLefRV1g07FOAzt97KZvAYdBlqdo1r+d5XDmQ0m75ZIMcv1EwldjvlVEprNaZOFNKZ+2EM Z6ADzj+Pbs7Xv8vT2isiJC2VZah7T58DcAdJZpGv+Ab7H8udlA4U5iUq5nNB2G9Ubih6R1 Togx682XjcE4g/UxKXZTpxaVLAw98Lg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=proton.me header.s=izgnb2xml5epbownengd5anrua.protonmail header.b=QQsAdwZs; spf=pass (imf26.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723652879; a=rsa-sha256; cv=none; b=mtGfNxq0JHn2ZI8FWSCGKaZE5JHZNsIT/6CdknlRROSr6YSRPAwjOETFsaYVnZ2AK86tN2 6W2P1z/Mxaq0qu6TxNn7FuwLvlqPiXSVvK1jQvMKYdwTSxf9ekYGcAByXOVXYI8OQh5XIZ B0Yl9hqtPIDoO+uJ9DfC1e5q3GAuJYE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=izgnb2xml5epbownengd5anrua.protonmail; t=1723652889; x=1723912089; bh=NDeEv674K9CkcHgDcHkn+qiS/pKjJ9GtImDj4uiP3aQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=QQsAdwZspwhYXiBTOLgkyaYacs88TeDdy2W62teQVW1o3zcV47SasonfXnROSt1DY HiPafgcGhh2U0OVBrOjQxozFaI9lsSRSa3gR3HDfHsMEQ8weTXufXdfLN7boi8xwzS dqv3vdBpyhgExQTSXLaweXFQjoGZYItymUpSvyfKla3vB/+g9Qsnahi8oSx9iVc/Tv ya4+0gY39dODpqe3fSTDT1KUjDxT/ZBp3mPKV+lAWbv9HgCq8sToVCeDVg79ZZzBbP 1ZdoeVYvTkDq8jrk1rCto8d+lPv1D6fwn/iSz+4kLZvxPvsnk8JgMuJ0ONGXF50DqX Mm+QL2FHmN4wg== Date: Wed, 14 Aug 2024 16:28:04 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` Message-ID: <04b0fd96-c91c-4f38-90e9-8acee31e8445@proton.me> In-Reply-To: <20240812182355.11641-5-dakr@kernel.org> References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-5-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 88f8c24039c7706740f395f5716dfb216a4a06aa MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: iszjedt51aizhn5w9a949rduzefxte8p X-Rspamd-Queue-Id: 2889E140022 X-Rspamd-Server: rspam11 X-HE-Tag: 1723652890-656462 X-HE-Meta: U2FsdGVkX18g6fpYqW4ZTAGfT/q65+OyfDIWs1/LO0GUSpqZI5r75qdxYT3GWKnBCwrm6WxP+pQqhQGW4VncbiS/TUNOiyr0frRrGLoBngP7ONO1hg/c28dOVGSuMYQJd1BRfqJJ3V0CH91ZdIchIRXu/6FmSub9y+1AcxO4y54wjJWR2kgN4gUGrjn7zLf2/zdqn/K/97LOiY1P0cZlWT4Dsp/qUGFiPyHhC/5mmdsF/Q0xGqTQHJqay0euyn2qBm4jAJ52Toi+3C0lmsDrFV9Q0AP0ZO+LcvYxeazlWizgPxbzGlL3A8I/iX+WpRqo0vRzkqHQnbsFiXsIMxqr2Roclt79tyN9pf1QWSkNNjfiN5yiX5iWxJNxnvoq+ksSyl/kgumq+ju2lTHlzeDTL36Hb5CheYFahimOTnNwarjvrgqBVb7Dnt7UNxhW3L/m1V4h1K9qgenamgbbXbdmoTsZQWgX0lqFy8S2UgQcRgDRz/9OxCSoBHLOtfcSjDInsn7JOQKJiRKV2XFYt6E1iJyPcivp4SqsDpCe+Q+2/wiGMdYviKdSoMy+cMVrx6XOfFQa6RkVQqv5Y7EJT9P3K8AMj/US2Ge6RSGUOJKrbjMN/JlCt0lh/b9Fn+0PWDU44uMK66WdXx9MV+CtBHx15DU2kmKw2YdKG2J/RcQ2M+8BVoAhu+0xKWOuXPNwXYSyYqKXS3HVN9spIeHL1NIh58GtBrDWaSzygNB0GmQ4dT56xeiPXsoBRkuxjBb9CZIAiPE+KNKdLaqL8eBqIZdZJ3iCPsRIzpkECSfUE+M4FQfvRY4FaNXMi3Mn5ylK4xDQOS31pTZYu/MNG15pt3hxGF8mhEga1fKQm+4ogd5UedxJw0ETsNHr0KRbsWZuHR4gdUD/WHDAnDyHp00cLQP+U/0/DxRBDfxLDlphh+1jMCDoPuOWxkPxzUXbHEnUzXblw3oPmUjWtjGnE/Dk4FX 5jzp1VVU +6K8XJuxII+rhs/3wC1gHWiJiyl9hpGKMLMCvWpUWyhQ5eRpTjt9IO5HyWq7tADhwav9/uLsz3/tuKF9gSgf2eNpR9HtJfHfcxJzsGtwBTSmZHCV834/A6+KaCSVcwoGiFqAiQUxVZW9URrSjublhHV5cjvTwzdnL3XlnaBTsf5BA0MzjNmO+CANteUqBmo92GtFubJ5l5/8t6l0TYL6TF7b7ZQd61Jy4JF2biINUG1pbQzMkZUKCvHtbkdBsVw5A5Zh+1ZYP+JNbTizvw2JHako1E+ktfXtZ2kIVYlhzp2UnYwaNHmJWcXObO4vXM+mT0X7MKQIWpbXXhi4Ef8zG40tZIbsLmkojpp+xmYOmuDbN467PSb0E131jwg/aYiczXNqdB1QIl3NTzfI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000121, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.08.24 20:22, Danilo Krummrich wrote: > +unsafe impl Allocator for Kmalloc { There is a missing SAFETY comment here (and also for Vmalloc, probably also for VKmalloc then). --- Cheers, Benno > + unsafe fn realloc( > + ptr: Option>, > + layout: Layout, > + flags: Flags, > + ) -> Result, AllocError> { > + // SAFETY: `ReallocFunc::call` has the same safety requirements = as `Allocator::realloc`. > + unsafe { ReallocFunc::KREALLOC.call(ptr, layout, flags) } > + } > +} > + > unsafe impl GlobalAlloc for Kmalloc { > unsafe fn alloc(&self, layout: Layout) -> *mut u8 { > // SAFETY: `ptr::null_mut()` is null and `layout` has a non-zero= size by the function safety > -- > 2.45.2 >=20